Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_cloudsearch_domain added source_fields attribute for index #24915

Merged
merged 12 commits into from
May 26, 2022

Conversation

daftkid
Copy link
Contributor

@daftkid daftkid commented May 21, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #24814

Output from acceptance testing:

Sorry, I'm not able to run acceptance tests right now, may I ask you to run them, please?

$ make testacc TESTS=TestAccCloudSearchDomain_sourceFields PKG=cloudsearch

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/cloudsearch Issues and PRs that pertain to the cloudsearch service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 21, 2022
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels May 23, 2022
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels May 26, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccCloudSearchDomain_' PKG=cloudsearch ACCTEST_PARALLELISM=2  
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudsearch/... -v -count 1 -parallel 2  -run=TestAccCloudSearchDomain_ -timeout 180m
=== RUN   TestAccCloudSearchDomain_basic
=== PAUSE TestAccCloudSearchDomain_basic
=== RUN   TestAccCloudSearchDomain_disappears
=== PAUSE TestAccCloudSearchDomain_disappears
=== RUN   TestAccCloudSearchDomain_indexFields
=== PAUSE TestAccCloudSearchDomain_indexFields
=== RUN   TestAccCloudSearchDomain_sourceFields
=== PAUSE TestAccCloudSearchDomain_sourceFields
=== RUN   TestAccCloudSearchDomain_update
=== PAUSE TestAccCloudSearchDomain_update
=== CONT  TestAccCloudSearchDomain_basic
=== CONT  TestAccCloudSearchDomain_sourceFields
--- PASS: TestAccCloudSearchDomain_basic (606.20s)
=== CONT  TestAccCloudSearchDomain_update
--- PASS: TestAccCloudSearchDomain_sourceFields (1570.78s)
=== CONT  TestAccCloudSearchDomain_indexFields
--- PASS: TestAccCloudSearchDomain_update (2172.68s)
=== CONT  TestAccCloudSearchDomain_disappears
--- PASS: TestAccCloudSearchDomain_indexFields (1769.46s)
--- PASS: TestAccCloudSearchDomain_disappears (815.94s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudsearch	3605.054s

@ewbankkit
Copy link
Contributor

@daftkid Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit e57b5f5 into hashicorp:main May 26, 2022
@github-actions github-actions bot added this to the v4.16.0 milestone May 26, 2022
@daftkid daftkid deleted the cloudsearch_index_source_fields branch May 27, 2022 09:34
@github-actions
Copy link

This functionality has been released in v4.16.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/cloudsearch Issues and PRs that pertain to the cloudsearch service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No way to specify "Source Field" in aws_cloudsearch_domain
3 participants