Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Data Sources: aws_service_discovery_service and aws_service_discovery_http_namespace #25162

Merged
merged 19 commits into from Jun 27, 2022
Merged

New Data Sources: aws_service_discovery_service and aws_service_discovery_http_namespace #25162

merged 19 commits into from Jun 27, 2022

Conversation

brittandeyoung
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

This pull request should fulfill the remaining request in the following issue:

Closes #14881

Output from acceptance testing:

➜ terraform-provider-aws (f-aws_service_discovery) ✗ make testacc TESTARGS='-run=TestAccServiceDiscoveryHTTPNamespaceDataSource_' PKG_NAME=internal/service/servicediscovery 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/servicediscovery/... -v -count 1 -parallel 20  -run=TestAccServiceDiscoveryHTTPNamespaceDataSource_ -timeout 180m
=== RUN   TestAccServiceDiscoveryHTTPNamespaceDataSource_basic
=== PAUSE TestAccServiceDiscoveryHTTPNamespaceDataSource_basic
=== CONT  TestAccServiceDiscoveryHTTPNamespaceDataSource_basic
--- PASS: TestAccServiceDiscoveryHTTPNamespaceDataSource_basic (107.35s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/servicediscovery   110.760s
➜ terraform-provider-aws (f-aws_service_discovery) ✗ make testacc TESTARGS='-run=TestAccServiceDiscoveryHTTPNamespace_' PKG_NAME=internal/service/servicediscovery  
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/servicediscovery/... -v -count 1 -parallel 20  -run=TestAccServiceDiscoveryHTTPNamespace_ -timeout 180m
=== RUN   TestAccServiceDiscoveryHTTPNamespace_basic
=== PAUSE TestAccServiceDiscoveryHTTPNamespace_basic
=== RUN   TestAccServiceDiscoveryHTTPNamespace_disappears
=== PAUSE TestAccServiceDiscoveryHTTPNamespace_disappears
=== RUN   TestAccServiceDiscoveryHTTPNamespace_description
=== PAUSE TestAccServiceDiscoveryHTTPNamespace_description
=== RUN   TestAccServiceDiscoveryHTTPNamespace_tags
=== PAUSE TestAccServiceDiscoveryHTTPNamespace_tags
=== CONT  TestAccServiceDiscoveryHTTPNamespace_basic
=== CONT  TestAccServiceDiscoveryHTTPNamespace_description
=== CONT  TestAccServiceDiscoveryHTTPNamespace_tags
=== CONT  TestAccServiceDiscoveryHTTPNamespace_disappears
--- PASS: TestAccServiceDiscoveryHTTPNamespace_disappears (109.40s)
--- PASS: TestAccServiceDiscoveryHTTPNamespace_basic (117.75s)
--- PASS: TestAccServiceDiscoveryHTTPNamespace_description (118.20s)
--- PASS: TestAccServiceDiscoveryHTTPNamespace_tags (145.62s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/servicediscovery   149.005s
➜ terraform-provider-aws (f-aws_service_discovery) ✗ make testacc TESTARGS='-run=TestAccServiceDiscoveryServiceDataSource_' PKG_NAME=internal/service/servicediscovery 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/servicediscovery/... -v -count 1 -parallel 20  -run=TestAccServiceDiscoveryServiceDataSource_ -timeout 180m
=== RUN   TestAccServiceDiscoveryServiceDataSource_basic
=== PAUSE TestAccServiceDiscoveryServiceDataSource_basic
=== RUN   TestAccServiceDiscoveryServiceDataSource_private
=== PAUSE TestAccServiceDiscoveryServiceDataSource_private
=== RUN   TestAccServiceDiscoveryServiceDataSource_public
=== PAUSE TestAccServiceDiscoveryServiceDataSource_public
=== CONT  TestAccServiceDiscoveryServiceDataSource_basic
=== CONT  TestAccServiceDiscoveryServiceDataSource_public
=== CONT  TestAccServiceDiscoveryServiceDataSource_private
--- PASS: TestAccServiceDiscoveryServiceDataSource_public (112.24s)
--- PASS: TestAccServiceDiscoveryServiceDataSource_basic (112.56s)
--- PASS: TestAccServiceDiscoveryServiceDataSource_private (114.42s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/servicediscovery   117.829s

...

This pull request includes the following changes:

  • A new data source for the aws_service_discovery_service resource.
  • A new data source for the aws_service_discovery_http_namespace resource.
  • Added the http_name attribute to the aws_service_discovery_http_namespace resource and updated testing and documentation to support this new attribute

@brittandeyoung
New Data Source: aws_service_discovery_service
9b3cb8b 
Adding a new data source for the  aws_service_discovery_service resource.
@brittandeyoung
New Data Source: aws_service_discovery_http_namespace
aca442a 
Added a a new data source for the aws_service_discovery_http_namespace resource
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/servicediscovery Issues and PRs that pertain to the servicediscovery service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. labels Jun 3, 2022
@brittandeyoung
Copy link
Collaborator Author

brittandeyoung commented Jun 3, 2022 •
edited

hmmm the semgrep test seams to be failing on a different file each run. It is failing on files not modified in this PR. Any direction on how to resolve this test issue?

I do not get this same error when running this test locally.

@matt-land
Copy link

matt-land commented Jun 3, 2022 •
edited

I am very excited to see this PR, however, I don't think this totally closes #14881
I do not see the following data sources in the PR:

aws_service_discovery_private_dns_namespace
aws_service_discovery_public_dns_namespace

These seem to be covered by aws_service_discovery_dns_namespace

@brittandeyoung
Copy link
Collaborator Author

brittandeyoung commented Jun 3, 2022 •
edited

@matt-land that is what I found as well.

The singleaws_service_discovery_dns_namespace data source covers both dns related namespaces.

@justinretzolk justinretzolk added new-data-source Introduces a new data source. enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 6, 2022
@ewbankkit
Tweak CHANGELOG entry.
ff00d5a
@ewbankkit
r/aws_service_discovery_http_namespace: Add 'FindNamespaceByID'.
69614af 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccServiceDiscoveryHTTPNamespace_' PKG=servicediscovery ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/servicediscovery/... -v -count 1 -parallel 2  -run=TestAccServiceDiscoveryHTTPNamespace_ -timeout 180m
=== RUN   TestAccServiceDiscoveryHTTPNamespace_basic
=== PAUSE TestAccServiceDiscoveryHTTPNamespace_basic
=== RUN   TestAccServiceDiscoveryHTTPNamespace_disappears
=== PAUSE TestAccServiceDiscoveryHTTPNamespace_disappears
=== RUN   TestAccServiceDiscoveryHTTPNamespace_description
=== PAUSE TestAccServiceDiscoveryHTTPNamespace_description
=== RUN   TestAccServiceDiscoveryHTTPNamespace_tags
=== PAUSE TestAccServiceDiscoveryHTTPNamespace_tags
=== CONT  TestAccServiceDiscoveryHTTPNamespace_basic
=== CONT  TestAccServiceDiscoveryHTTPNamespace_description
--- PASS: TestAccServiceDiscoveryHTTPNamespace_basic (110.25s)
=== CONT  TestAccServiceDiscoveryHTTPNamespace_disappears
--- PASS: TestAccServiceDiscoveryHTTPNamespace_description (110.41s)
=== CONT  TestAccServiceDiscoveryHTTPNamespace_tags
--- PASS: TestAccServiceDiscoveryHTTPNamespace_disappears (102.85s)
--- PASS: TestAccServiceDiscoveryHTTPNamespace_tags (139.59s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/servicediscovery	256.550s
@ewbankkit
d/aws_service_discovery_http_namespace: Add 'findNamespaceByNameAndTy…
44ca1af 
…pe'.

Acceptance test output:

% make testacc TESTARGS='-run=TestAccServiceDiscoveryHTTPNamespaceDataSource_' PKG=servicediscovery ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/servicediscovery/... -v -count 1 -parallel 2  -run=TestAccServiceDiscoveryHTTPNamespaceDataSource_ -timeout 180m
=== RUN   TestAccServiceDiscoveryHTTPNamespaceDataSource_basic
=== PAUSE TestAccServiceDiscoveryHTTPNamespaceDataSource_basic
=== CONT  TestAccServiceDiscoveryHTTPNamespaceDataSource_basic
--- PASS: TestAccServiceDiscoveryHTTPNamespaceDataSource_basic (108.40s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/servicediscovery	115.143s
@ewbankkit
Handle nil Namespace.Properties.
bf292d7
@ewbankkit
r/aws_service_discovery_private_dns_namespace: Use 'FindNamespaceByID'.
b90b4bc 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccServiceDiscoveryPrivateDNSNamespace_' PKG=servicediscovery ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/servicediscovery/... -v -count 1 -parallel 2  -run=TestAccServiceDiscoveryPrivateDNSNamespace_ -timeout 180m
=== RUN   TestAccServiceDiscoveryPrivateDNSNamespace_basic
=== PAUSE TestAccServiceDiscoveryPrivateDNSNamespace_basic
=== RUN   TestAccServiceDiscoveryPrivateDNSNamespace_disappears
=== PAUSE TestAccServiceDiscoveryPrivateDNSNamespace_disappears
=== RUN   TestAccServiceDiscoveryPrivateDNSNamespace_description
=== PAUSE TestAccServiceDiscoveryPrivateDNSNamespace_description
=== RUN   TestAccServiceDiscoveryPrivateDNSNamespace_Error_overlap
=== PAUSE TestAccServiceDiscoveryPrivateDNSNamespace_Error_overlap
=== RUN   TestAccServiceDiscoveryPrivateDNSNamespace_tags
=== PAUSE TestAccServiceDiscoveryPrivateDNSNamespace_tags
=== CONT  TestAccServiceDiscoveryPrivateDNSNamespace_basic
=== CONT  TestAccServiceDiscoveryPrivateDNSNamespace_Error_overlap
--- PASS: TestAccServiceDiscoveryPrivateDNSNamespace_basic (110.66s)
=== CONT  TestAccServiceDiscoveryPrivateDNSNamespace_description
--- PASS: TestAccServiceDiscoveryPrivateDNSNamespace_Error_overlap (175.76s)
=== CONT  TestAccServiceDiscoveryPrivateDNSNamespace_disappears
--- PASS: TestAccServiceDiscoveryPrivateDNSNamespace_description (104.60s)
=== CONT  TestAccServiceDiscoveryPrivateDNSNamespace_tags
--- PASS: TestAccServiceDiscoveryPrivateDNSNamespace_disappears (109.18s)
--- PASS: TestAccServiceDiscoveryPrivateDNSNamespace_tags (150.79s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/servicediscovery	370.972s
@ewbankkit
r/aws_service_discovery_public_dns_namespace: Use 'FindNamespaceByID'.
5f387d6 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccServiceDiscoveryPublicDNSNamespace_' PKG=servicediscovery ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/servicediscovery/... -v -count 1 -parallel 2  -run=TestAccServiceDiscoveryPublicDNSNamespace_ -timeout 180m
=== RUN   TestAccServiceDiscoveryPublicDNSNamespace_basic
=== PAUSE TestAccServiceDiscoveryPublicDNSNamespace_basic
=== RUN   TestAccServiceDiscoveryPublicDNSNamespace_disappears
=== PAUSE TestAccServiceDiscoveryPublicDNSNamespace_disappears
=== RUN   TestAccServiceDiscoveryPublicDNSNamespace_description
=== PAUSE TestAccServiceDiscoveryPublicDNSNamespace_description
=== RUN   TestAccServiceDiscoveryPublicDNSNamespace_tags
=== PAUSE TestAccServiceDiscoveryPublicDNSNamespace_tags
=== CONT  TestAccServiceDiscoveryPublicDNSNamespace_basic
=== CONT  TestAccServiceDiscoveryPublicDNSNamespace_description
--- PASS: TestAccServiceDiscoveryPublicDNSNamespace_description (106.83s)
=== CONT  TestAccServiceDiscoveryPublicDNSNamespace_tags
--- PASS: TestAccServiceDiscoveryPublicDNSNamespace_basic (109.66s)
=== CONT  TestAccServiceDiscoveryPublicDNSNamespace_disappears
--- PASS: TestAccServiceDiscoveryPublicDNSNamespace_disappears (102.40s)
--- PASS: TestAccServiceDiscoveryPublicDNSNamespace_tags (133.84s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/servicediscovery	247.485s
@ewbankkit
d/aws_service_discovery_dns_namespace: Add 'tags' attribute.
bc48924 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccServiceDiscoveryDNSNamespaceDataSource_' PKG=servicediscovery ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/servicediscovery/... -v -count 1 -parallel 2  -run=TestAccServiceDiscoveryDNSNamespaceDataSource_ -timeout 180m
=== RUN   TestAccServiceDiscoveryDNSNamespaceDataSource_private
=== PAUSE TestAccServiceDiscoveryDNSNamespaceDataSource_private
=== RUN   TestAccServiceDiscoveryDNSNamespaceDataSource_public
=== PAUSE TestAccServiceDiscoveryDNSNamespaceDataSource_public
=== CONT  TestAccServiceDiscoveryDNSNamespaceDataSource_private
=== CONT  TestAccServiceDiscoveryDNSNamespaceDataSource_public
--- PASS: TestAccServiceDiscoveryDNSNamespaceDataSource_public (111.51s)
--- PASS: TestAccServiceDiscoveryDNSNamespaceDataSource_private (113.57s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/servicediscovery	120.962s
@ewbankkit
r/aws_service_discovery_instance: Tidy up.
60fec4d 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccServiceDiscoveryInstance_' PKG=servicediscovery ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/servicediscovery/... -v -count 1 -parallel 2  -run=TestAccServiceDiscoveryInstance_ -timeout 180m
=== RUN   TestAccServiceDiscoveryInstance_private
=== PAUSE TestAccServiceDiscoveryInstance_private
=== RUN   TestAccServiceDiscoveryInstance_public
=== PAUSE TestAccServiceDiscoveryInstance_public
=== RUN   TestAccServiceDiscoveryInstance_http
=== PAUSE TestAccServiceDiscoveryInstance_http
=== CONT  TestAccServiceDiscoveryInstance_private
=== CONT  TestAccServiceDiscoveryInstance_http
--- PASS: TestAccServiceDiscoveryInstance_private (145.23s)
=== CONT  TestAccServiceDiscoveryInstance_public
--- PASS: TestAccServiceDiscoveryInstance_http (200.09s)
--- PASS: TestAccServiceDiscoveryInstance_public (130.48s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/servicediscovery	283.309s
@ewbankkit
r/aws_service_discovery_service: Tidy up.
88b059c 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccServiceDiscoveryService_' PKG=servicediscovery ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/servicediscovery/... -v -count 1 -parallel 2  -run=TestAccServiceDiscoveryService_ -timeout 180m
=== RUN   TestAccServiceDiscoveryService_private
=== PAUSE TestAccServiceDiscoveryService_private
=== RUN   TestAccServiceDiscoveryService_public
=== PAUSE TestAccServiceDiscoveryService_public
=== RUN   TestAccServiceDiscoveryService_http
=== PAUSE TestAccServiceDiscoveryService_http
=== RUN   TestAccServiceDiscoveryService_disappears
=== PAUSE TestAccServiceDiscoveryService_disappears
=== RUN   TestAccServiceDiscoveryService_tags
=== PAUSE TestAccServiceDiscoveryService_tags
=== CONT  TestAccServiceDiscoveryService_private
=== CONT  TestAccServiceDiscoveryService_disappears
--- PASS: TestAccServiceDiscoveryService_disappears (103.01s)
=== CONT  TestAccServiceDiscoveryService_http
--- PASS: TestAccServiceDiscoveryService_private (126.08s)
=== CONT  TestAccServiceDiscoveryService_public
--- PASS: TestAccServiceDiscoveryService_http (103.37s)
=== CONT  TestAccServiceDiscoveryService_tags
--- PASS: TestAccServiceDiscoveryService_public (129.39s)
--- PASS: TestAccServiceDiscoveryService_tags (126.76s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/servicediscovery	337.154s
@ewbankkit
d/aws_service_discovery_service: Tidy up.
d3c4acd 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccServiceDiscoveryServiceDataSource_' PKG=servicediscovery ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/servicediscovery/... -v -count 1 -parallel 2  -run=TestAccServiceDiscoveryServiceDataSource_ -timeout 180m
=== RUN   TestAccServiceDiscoveryServiceDataSource_basic
=== PAUSE TestAccServiceDiscoveryServiceDataSource_basic
=== RUN   TestAccServiceDiscoveryServiceDataSource_private
=== PAUSE TestAccServiceDiscoveryServiceDataSource_private
=== RUN   TestAccServiceDiscoveryServiceDataSource_public
=== PAUSE TestAccServiceDiscoveryServiceDataSource_public
=== CONT  TestAccServiceDiscoveryServiceDataSource_basic
=== CONT  TestAccServiceDiscoveryServiceDataSource_private
--- PASS: TestAccServiceDiscoveryServiceDataSource_basic (109.50s)
=== CONT  TestAccServiceDiscoveryServiceDataSource_public
--- PASS: TestAccServiceDiscoveryServiceDataSource_private (112.37s)
--- PASS: TestAccServiceDiscoveryServiceDataSource_public (106.61s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/servicediscovery	225.254s
@ewbankkit
Switch to Plugin SDK v2 'WithoutTimeout' CRUD handler signatures.
ae0daca
ewbankkit
ewbankkit approved these changes Jun 24, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccServiceDiscovery' PKG=servicediscovery ACCTEST_PARALLELISM=3 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/servicediscovery/... -v -count 1 -parallel 3  -run=TestAccServiceDiscovery -timeout 180m
=== RUN   TestAccServiceDiscoveryDNSNamespaceDataSource_private
=== PAUSE TestAccServiceDiscoveryDNSNamespaceDataSource_private
=== RUN   TestAccServiceDiscoveryDNSNamespaceDataSource_public
=== PAUSE TestAccServiceDiscoveryDNSNamespaceDataSource_public
=== RUN   TestAccServiceDiscoveryHTTPNamespaceDataSource_basic
=== PAUSE TestAccServiceDiscoveryHTTPNamespaceDataSource_basic
=== RUN   TestAccServiceDiscoveryHTTPNamespace_basic
=== PAUSE TestAccServiceDiscoveryHTTPNamespace_basic
=== RUN   TestAccServiceDiscoveryHTTPNamespace_disappears
=== PAUSE TestAccServiceDiscoveryHTTPNamespace_disappears
=== RUN   TestAccServiceDiscoveryHTTPNamespace_description
=== PAUSE TestAccServiceDiscoveryHTTPNamespace_description
=== RUN   TestAccServiceDiscoveryHTTPNamespace_tags
=== PAUSE TestAccServiceDiscoveryHTTPNamespace_tags
=== RUN   TestAccServiceDiscoveryInstance_private
=== PAUSE TestAccServiceDiscoveryInstance_private
=== RUN   TestAccServiceDiscoveryInstance_public
=== PAUSE TestAccServiceDiscoveryInstance_public
=== RUN   TestAccServiceDiscoveryInstance_http
=== PAUSE TestAccServiceDiscoveryInstance_http
=== RUN   TestAccServiceDiscoveryPrivateDNSNamespace_basic
=== PAUSE TestAccServiceDiscoveryPrivateDNSNamespace_basic
=== RUN   TestAccServiceDiscoveryPrivateDNSNamespace_disappears
=== PAUSE TestAccServiceDiscoveryPrivateDNSNamespace_disappears
=== RUN   TestAccServiceDiscoveryPrivateDNSNamespace_description
=== PAUSE TestAccServiceDiscoveryPrivateDNSNamespace_description
=== RUN   TestAccServiceDiscoveryPrivateDNSNamespace_Error_overlap
=== PAUSE TestAccServiceDiscoveryPrivateDNSNamespace_Error_overlap
=== RUN   TestAccServiceDiscoveryPrivateDNSNamespace_tags
=== PAUSE TestAccServiceDiscoveryPrivateDNSNamespace_tags
=== RUN   TestAccServiceDiscoveryPublicDNSNamespace_basic
=== PAUSE TestAccServiceDiscoveryPublicDNSNamespace_basic
=== RUN   TestAccServiceDiscoveryPublicDNSNamespace_disappears
=== PAUSE TestAccServiceDiscoveryPublicDNSNamespace_disappears
=== RUN   TestAccServiceDiscoveryPublicDNSNamespace_description
=== PAUSE TestAccServiceDiscoveryPublicDNSNamespace_description
=== RUN   TestAccServiceDiscoveryPublicDNSNamespace_tags
=== PAUSE TestAccServiceDiscoveryPublicDNSNamespace_tags
=== RUN   TestAccServiceDiscoveryServiceDataSource_basic
=== PAUSE TestAccServiceDiscoveryServiceDataSource_basic
=== RUN   TestAccServiceDiscoveryServiceDataSource_private
=== PAUSE TestAccServiceDiscoveryServiceDataSource_private
=== RUN   TestAccServiceDiscoveryServiceDataSource_public
=== PAUSE TestAccServiceDiscoveryServiceDataSource_public
=== RUN   TestAccServiceDiscoveryService_private
=== PAUSE TestAccServiceDiscoveryService_private
=== RUN   TestAccServiceDiscoveryService_public
=== PAUSE TestAccServiceDiscoveryService_public
=== RUN   TestAccServiceDiscoveryService_http
=== PAUSE TestAccServiceDiscoveryService_http
=== RUN   TestAccServiceDiscoveryService_disappears
=== PAUSE TestAccServiceDiscoveryService_disappears
=== RUN   TestAccServiceDiscoveryService_tags
=== PAUSE TestAccServiceDiscoveryService_tags
=== CONT  TestAccServiceDiscoveryDNSNamespaceDataSource_private
=== CONT  TestAccServiceDiscoveryPrivateDNSNamespace_tags
=== CONT  TestAccServiceDiscoveryInstance_private
--- PASS: TestAccServiceDiscoveryDNSNamespaceDataSource_private (109.48s)
=== CONT  TestAccServiceDiscoveryHTTPNamespace_disappears
--- PASS: TestAccServiceDiscoveryPrivateDNSNamespace_tags (138.59s)
=== CONT  TestAccServiceDiscoveryHTTPNamespace_tags
--- PASS: TestAccServiceDiscoveryInstance_private (145.10s)
=== CONT  TestAccServiceDiscoveryHTTPNamespace_description
--- PASS: TestAccServiceDiscoveryHTTPNamespace_disappears (98.58s)
=== CONT  TestAccServiceDiscoveryHTTPNamespaceDataSource_basic
--- PASS: TestAccServiceDiscoveryHTTPNamespace_description (103.14s)
=== CONT  TestAccServiceDiscoveryHTTPNamespace_basic
--- PASS: TestAccServiceDiscoveryHTTPNamespace_tags (127.40s)
=== CONT  TestAccServiceDiscoveryPrivateDNSNamespace_disappears
--- PASS: TestAccServiceDiscoveryHTTPNamespaceDataSource_basic (102.57s)
=== CONT  TestAccServiceDiscoveryPrivateDNSNamespace_Error_overlap
--- PASS: TestAccServiceDiscoveryHTTPNamespace_basic (104.99s)
=== CONT  TestAccServiceDiscoveryPrivateDNSNamespace_description
--- PASS: TestAccServiceDiscoveryPrivateDNSNamespace_disappears (102.83s)
=== CONT  TestAccServiceDiscoveryDNSNamespaceDataSource_public
--- PASS: TestAccServiceDiscoveryPrivateDNSNamespace_description (103.75s)
=== CONT  TestAccServiceDiscoveryServiceDataSource_public
--- PASS: TestAccServiceDiscoveryDNSNamespaceDataSource_public (103.30s)
=== CONT  TestAccServiceDiscoveryService_tags
--- PASS: TestAccServiceDiscoveryPrivateDNSNamespace_Error_overlap (171.55s)
=== CONT  TestAccServiceDiscoveryService_disappears
--- PASS: TestAccServiceDiscoveryServiceDataSource_public (103.06s)
=== CONT  TestAccServiceDiscoveryService_http
--- PASS: TestAccServiceDiscoveryService_disappears (101.44s)
=== CONT  TestAccServiceDiscoveryService_public
--- PASS: TestAccServiceDiscoveryService_tags (128.17s)
=== CONT  TestAccServiceDiscoveryService_private
--- PASS: TestAccServiceDiscoveryService_http (104.98s)
=== CONT  TestAccServiceDiscoveryPublicDNSNamespace_tags
--- PASS: TestAccServiceDiscoveryService_public (128.03s)
=== CONT  TestAccServiceDiscoveryServiceDataSource_private
--- PASS: TestAccServiceDiscoveryService_private (123.29s)
=== CONT  TestAccServiceDiscoveryServiceDataSource_basic
--- PASS: TestAccServiceDiscoveryPublicDNSNamespace_tags (128.85s)
=== CONT  TestAccServiceDiscoveryPublicDNSNamespace_disappears
--- PASS: TestAccServiceDiscoveryServiceDataSource_private (106.98s)
=== CONT  TestAccServiceDiscoveryPublicDNSNamespace_description
--- PASS: TestAccServiceDiscoveryServiceDataSource_basic (103.93s)
=== CONT  TestAccServiceDiscoveryInstance_http
--- PASS: TestAccServiceDiscoveryPublicDNSNamespace_disappears (98.81s)
=== CONT  TestAccServiceDiscoveryPrivateDNSNamespace_basic
--- PASS: TestAccServiceDiscoveryPublicDNSNamespace_description (100.83s)
=== CONT  TestAccServiceDiscoveryInstance_public
--- PASS: TestAccServiceDiscoveryPrivateDNSNamespace_basic (105.89s)
=== CONT  TestAccServiceDiscoveryPublicDNSNamespace_basic
--- PASS: TestAccServiceDiscoveryInstance_http (189.26s)
--- PASS: TestAccServiceDiscoveryInstance_public (125.23s)
--- PASS: TestAccServiceDiscoveryPublicDNSNamespace_basic (103.20s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/servicediscovery	1105.769s

@github-actions github-actions bot added the sweeper Pertains to changes to or issues with the sweeper. label Jun 25, 2022
@ewbankkit
Copy link
Contributor

Sweepers:
% make sweep SWEEPARGS=-sweep-run=aws_service_discovery_http_namespace,aws_service_discovery_private_dns_namespace,aws_service_discovery_public_dns_namespace SWEEP=us-east-1,us-west-2
# make sweep SWEEPARGS=-sweep-run=aws_example_thing
WARNING: This will destroy infrastructure. Use only in development accounts.
go test ./internal/sweep -v -tags=sweep -sweep=us-east-1,us-west-2 -sweep-run=aws_service_discovery_http_namespace,aws_service_discovery_private_dns_namespace,aws_service_discovery_public_dns_namespace -timeout 60m
2022/06/25 16:38:30 [DEBUG] Running Sweepers for region (us-east-1):
2022/06/25 16:38:30 [DEBUG] Sweeper (aws_service_discovery_public_dns_namespace) has dependency (aws_service_discovery_service), running..
2022/06/25 16:38:30 [DEBUG] Running Sweeper (aws_service_discovery_service) in region (us-east-1)
2022/06/25 16:38:30 [INFO] Retrieved credentials from "EnvConfigCredentials"
2022/06/25 16:38:30 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2022/06/25 16:38:30 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2022/06/25 16:38:31 [DEBUG] Completed Sweeper (aws_service_discovery_service) in region (us-east-1) in 657.251483ms
2022/06/25 16:38:31 [DEBUG] Running Sweeper (aws_service_discovery_public_dns_namespace) in region (us-east-1)
2022/06/25 16:38:31 [DEBUG] Completed Sweeper (aws_service_discovery_public_dns_namespace) in region (us-east-1) in 78.71904ms
2022/06/25 16:38:31 [DEBUG] Sweeper (aws_service_discovery_private_dns_namespace) has dependency (aws_service_discovery_service), running..
2022/06/25 16:38:31 [DEBUG] Sweeper (aws_service_discovery_service) already ran in region (us-east-1)
2022/06/25 16:38:31 [DEBUG] Running Sweeper (aws_service_discovery_private_dns_namespace) in region (us-east-1)
2022/06/25 16:38:31 [DEBUG] Completed Sweeper (aws_service_discovery_private_dns_namespace) in region (us-east-1) in 63.121003ms
2022/06/25 16:38:31 [DEBUG] Sweeper (aws_service_discovery_service) already ran in region (us-east-1)
2022/06/25 16:38:31 [DEBUG] Sweeper (aws_service_discovery_http_namespace) has dependency (aws_service_discovery_service), running..
2022/06/25 16:38:31 [DEBUG] Sweeper (aws_service_discovery_service) already ran in region (us-east-1)
2022/06/25 16:38:31 [DEBUG] Running Sweeper (aws_service_discovery_http_namespace) in region (us-east-1)
2022/06/25 16:38:31 [DEBUG] Completed Sweeper (aws_service_discovery_http_namespace) in region (us-east-1) in 63.763289ms
2022/06/25 16:38:31 Completed Sweepers for region (us-east-1) in 863.146723ms
2022/06/25 16:38:31 Sweeper Tests for region (us-east-1) ran successfully:
	- aws_service_discovery_service
	- aws_service_discovery_public_dns_namespace
	- aws_service_discovery_private_dns_namespace
	- aws_service_discovery_http_namespace
2022/06/25 16:38:31 [DEBUG] Running Sweepers for region (us-west-2):
2022/06/25 16:38:31 [DEBUG] Running Sweeper (aws_service_discovery_service) in region (us-west-2)
2022/06/25 16:38:31 [INFO] Retrieved credentials from "EnvConfigCredentials"
2022/06/25 16:38:31 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2022/06/25 16:38:32 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2022/06/25 16:38:33 [DEBUG] Waiting for state to become: [success]
2022/06/25 16:38:33 [DEBUG] Waiting for state to become: [success]
2022/06/25 16:38:33 [DEBUG] Waiting for state to become: [success]
2022/06/25 16:38:33 [INFO] Deleting Service Discovery Service: srv-j3jygn6ubidelm5a
2022/06/25 16:38:33 [INFO] Deleting Service Discovery Service: srv-xyfbsww7jhxbbyak
2022/06/25 16:38:33 [INFO] Deleting Service Discovery Service: srv-fl6j4uymdtw33wn6
2022/06/25 16:38:33 [DEBUG] Completed Sweeper (aws_service_discovery_service) in region (us-west-2) in 1.749072058s
2022/06/25 16:38:33 [DEBUG] Sweeper (aws_service_discovery_http_namespace) has dependency (aws_service_discovery_service), running..
2022/06/25 16:38:33 [DEBUG] Sweeper (aws_service_discovery_service) already ran in region (us-west-2)
2022/06/25 16:38:33 [DEBUG] Running Sweeper (aws_service_discovery_http_namespace) in region (us-west-2)
2022/06/25 16:38:33 [DEBUG] Waiting for state to become: [success]
2022/06/25 16:38:33 [INFO] Deleting Service Discovery HTTP Namespace: ns-pxcyvrtqfilnmxjc
2022/06/25 16:38:33 [DEBUG] Waiting for state to become: [SUCCESS]
2022/06/25 16:38:33 [TRACE] Waiting 200ms before next try
2022/06/25 16:38:34 [TRACE] Waiting 400ms before next try
2022/06/25 16:38:34 [TRACE] Waiting 800ms before next try
2022/06/25 16:38:35 [TRACE] Waiting 1.6s before next try
2022/06/25 16:38:37 [TRACE] Waiting 3.2s before next try
2022/06/25 16:38:40 [TRACE] Waiting 6.4s before next try
2022/06/25 16:38:47 [TRACE] Waiting 10s before next try
2022/06/25 16:38:57 [TRACE] Waiting 10s before next try
2022/06/25 16:39:07 [TRACE] Waiting 10s before next try
2022/06/25 16:39:17 [DEBUG] Completed Sweeper (aws_service_discovery_http_namespace) in region (us-west-2) in 44.125755805s
2022/06/25 16:39:17 [DEBUG] Sweeper (aws_service_discovery_public_dns_namespace) has dependency (aws_service_discovery_service), running..
2022/06/25 16:39:17 [DEBUG] Sweeper (aws_service_discovery_service) already ran in region (us-west-2)
2022/06/25 16:39:17 [DEBUG] Running Sweeper (aws_service_discovery_public_dns_namespace) in region (us-west-2)
2022/06/25 16:39:17 [DEBUG] Waiting for state to become: [success]
2022/06/25 16:39:17 [INFO] Deleting Service Discovery Private DNS Namespace: ns-sa3y3rrimvvjykrf
2022/06/25 16:39:17 [DEBUG] Waiting for state to become: [SUCCESS]
2022/06/25 16:39:17 [TRACE] Waiting 200ms before next try
2022/06/25 16:39:18 [TRACE] Waiting 400ms before next try
2022/06/25 16:39:18 [TRACE] Waiting 800ms before next try
2022/06/25 16:39:19 [TRACE] Waiting 1.6s before next try
2022/06/25 16:39:21 [TRACE] Waiting 3.2s before next try
2022/06/25 16:39:24 [TRACE] Waiting 6.4s before next try
2022/06/25 16:39:31 [TRACE] Waiting 10s before next try
2022/06/25 16:39:41 [TRACE] Waiting 10s before next try
2022/06/25 16:39:51 [TRACE] Waiting 10s before next try
2022/06/25 16:40:01 [DEBUG] Completed Sweeper (aws_service_discovery_public_dns_namespace) in region (us-west-2) in 43.835507686s
2022/06/25 16:40:01 [DEBUG] Sweeper (aws_service_discovery_private_dns_namespace) has dependency (aws_service_discovery_service), running..
2022/06/25 16:40:01 [DEBUG] Sweeper (aws_service_discovery_service) already ran in region (us-west-2)
2022/06/25 16:40:01 [DEBUG] Running Sweeper (aws_service_discovery_private_dns_namespace) in region (us-west-2)
2022/06/25 16:40:01 [DEBUG] Waiting for state to become: [success]
2022/06/25 16:40:01 [DEBUG] Waiting for state to become: [success]
2022/06/25 16:40:01 [DEBUG] Waiting for state to become: [success]
2022/06/25 16:40:01 [INFO] Deleting Service Discovery Private DNS Namespace: ns-lklswaaycdlkew5k
2022/06/25 16:40:01 [INFO] Deleting Service Discovery Private DNS Namespace: ns-7q2237k2qjsskdke
2022/06/25 16:40:01 [INFO] Deleting Service Discovery Private DNS Namespace: ns-vjlruw2ezsjzkvrm
2022/06/25 16:40:01 [DEBUG] Waiting for state to become: [SUCCESS]
2022/06/25 16:40:01 [DEBUG] Waiting for state to become: [SUCCESS]
2022/06/25 16:40:01 [DEBUG] Waiting for state to become: [SUCCESS]
2022/06/25 16:40:01 [TRACE] Waiting 200ms before next try
2022/06/25 16:40:01 [TRACE] Waiting 200ms before next try
2022/06/25 16:40:01 [TRACE] Waiting 200ms before next try
2022/06/25 16:40:02 [TRACE] Waiting 400ms before next try
2022/06/25 16:40:02 [TRACE] Waiting 400ms before next try
2022/06/25 16:40:02 [TRACE] Waiting 400ms before next try
2022/06/25 16:40:02 [TRACE] Waiting 800ms before next try
2022/06/25 16:40:02 [TRACE] Waiting 800ms before next try
2022/06/25 16:40:02 [TRACE] Waiting 800ms before next try
2022/06/25 16:40:03 [TRACE] Waiting 1.6s before next try
2022/06/25 16:40:03 [TRACE] Waiting 1.6s before next try
2022/06/25 16:40:03 [TRACE] Waiting 1.6s before next try
2022/06/25 16:40:05 [TRACE] Waiting 3.2s before next try
2022/06/25 16:40:05 [TRACE] Waiting 3.2s before next try
2022/06/25 16:40:05 [TRACE] Waiting 3.2s before next try
2022/06/25 16:40:08 [TRACE] Waiting 6.4s before next try
2022/06/25 16:40:08 [TRACE] Waiting 6.4s before next try
2022/06/25 16:40:08 [TRACE] Waiting 6.4s before next try
2022/06/25 16:40:15 [TRACE] Waiting 10s before next try
2022/06/25 16:40:15 [TRACE] Waiting 10s before next try
2022/06/25 16:40:15 [TRACE] Waiting 10s before next try
2022/06/25 16:40:25 [TRACE] Waiting 10s before next try
2022/06/25 16:40:25 [TRACE] Waiting 10s before next try
2022/06/25 16:40:25 [TRACE] Waiting 10s before next try
2022/06/25 16:40:35 [TRACE] Waiting 10s before next try
2022/06/25 16:40:35 [TRACE] Waiting 10s before next try
2022/06/25 16:40:35 [TRACE] Waiting 10s before next try
2022/06/25 16:40:45 [DEBUG] Completed Sweeper (aws_service_discovery_private_dns_namespace) in region (us-west-2) in 44.026134751s
2022/06/25 16:40:45 Completed Sweepers for region (us-west-2) in 2m13.736570546s
2022/06/25 16:40:45 Sweeper Tests for region (us-west-2) ran successfully:
	- aws_service_discovery_service
	- aws_service_discovery_http_namespace
	- aws_service_discovery_public_dns_namespace
	- aws_service_discovery_private_dns_namespace
ok  	github.com/hashicorp/terraform-provider-aws/internal/sweep	138.135s

@ewbankkit
Copy link
Contributor 

% make providerlint
==> Checking source code with providerlint...

@ewbankkit ewbankkit merged commit 753d347 into hashicorp:main Jun 27, 2022
@github-actions github-actions bot added this to the v4.21.0 milestone Jun 27, 2022
@github-actions
Copy link

github-actions bot commented Jul 1, 2022

This functionality has been released in v4.21.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@matt-land matt-land mentioned this pull request Jul 14, 2022
Open
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. new-data-source Introduces a new data source. provider Pertains to the provider itself, rather than any interaction with AWS. service/servicediscovery Issues and PRs that pertain to the servicediscovery service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.21.0
Development

Successfully merging this pull request may close these issues.

Create a Data Source Provider for the "Service Discovery" Resources
4 participants
@brittandeyoung @matt-land @ewbankkit @justinretzolk