r/vpc_endpoint_service - add `supported_ip_address_types` argument #25189

DrFaust92 · 2022-06-06T08:42:56Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTS=TestAccVPCEndpointService_ PKG=ec2
--- PASS: TestAccVPCEndpointService_gatewayLoadBalancerARNs (222.97s)
--- PASS: TestAccVPCEndpointService_disappears (258.14s)
--- PASS: TestAccVPCEndpointService_basic (261.54s)
--- PASS: TestAccVPCEndpointService_ipTypes (262.62s)
--- PASS: TestAccVPCEndpointService_PrivateDNS_name (307.81s)
--- PASS: TestAccVPCEndpointService_tags (324.42s)

Acceptance test output: % make testacc TESTARGS='-run=TestAccVPCEndpointService_basic' PKG=ec2 ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2 -run=TestAccVPCEndpointService_basic -timeout 180m === RUN TestAccVPCEndpointService_basic === PAUSE TestAccVPCEndpointService_basic === CONT TestAccVPCEndpointService_basic --- PASS: TestAccVPCEndpointService_basic (222.88s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 227.028s

Acceptance test output: % make testacc TESTARGS='-run=TestAccVPCEndpointService_basic' PKG=ec2 ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2 -run=TestAccVPCEndpointService_basic -timeout 180m === RUN TestAccVPCEndpointService_basic === PAUSE TestAccVPCEndpointService_basic === CONT TestAccVPCEndpointService_basic --- PASS: TestAccVPCEndpointService_basic (220.32s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 225.331s

Acceptance test output: % make testacc TESTARGS='-run=TestAccVPCEndpointService_basic' PKG=ec2 ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2 -run=TestAccVPCEndpointService_basic -timeout 180m === RUN TestAccVPCEndpointService_basic === PAUSE TestAccVPCEndpointService_basic === CONT TestAccVPCEndpointService_basic --- PASS: TestAccVPCEndpointService_basic (267.36s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 272.126s

Acceptance test output: % make testacc TESTARGS='-run=TestAccVPCEndpointService_supportedIPAddressTypes' PKG=ec2 ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2 -run=TestAccVPCEndpointService_supportedIPAddressTypes -timeout 180m === RUN TestAccVPCEndpointService_supportedIPAddressTypes === PAUSE TestAccVPCEndpointService_supportedIPAddressTypes === CONT TestAccVPCEndpointService_supportedIPAddressTypes --- PASS: TestAccVPCEndpointService_supportedIPAddressTypes (255.11s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 262.224s

This reverts commit 419e077.

…nce test." This reverts commit 561c22f.

…l-use-aws_iam_session_context

…wed_principal-use-aws_iam_session_context' into HEAD

Acceptance test output: % make testacc TESTARGS='-run=TestAccVPCEndpointServiceAllowedPrincipal_basic' PKG=ec2 ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2 -run=TestAccVPCEndpointServiceAllowedPrincipal_basic -timeout 180m === RUN TestAccVPCEndpointServiceAllowedPrincipal_basic === PAUSE TestAccVPCEndpointServiceAllowedPrincipal_basic === CONT TestAccVPCEndpointServiceAllowedPrincipal_basic --- PASS: TestAccVPCEndpointServiceAllowedPrincipal_basic (238.55s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 246.202s

Acceptance test output: % make testacc TESTARGS='-run=TestAccVPCEndpointServiceDataSource_' PKG=ec2 ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2 -run=TestAccVPCEndpointServiceDataSource_ -timeout 180m === RUN TestAccVPCEndpointServiceDataSource_gateway === PAUSE TestAccVPCEndpointServiceDataSource_gateway === RUN TestAccVPCEndpointServiceDataSource_interface === PAUSE TestAccVPCEndpointServiceDataSource_interface === RUN TestAccVPCEndpointServiceDataSource_custom === PAUSE TestAccVPCEndpointServiceDataSource_custom === RUN TestAccVPCEndpointServiceDataSource_Custom_filter === PAUSE TestAccVPCEndpointServiceDataSource_Custom_filter === RUN TestAccVPCEndpointServiceDataSource_CustomFilter_tags === PAUSE TestAccVPCEndpointServiceDataSource_CustomFilter_tags === RUN TestAccVPCEndpointServiceDataSource_ServiceType_gateway === PAUSE TestAccVPCEndpointServiceDataSource_ServiceType_gateway === RUN TestAccVPCEndpointServiceDataSource_ServiceType_interface === PAUSE TestAccVPCEndpointServiceDataSource_ServiceType_interface === CONT TestAccVPCEndpointServiceDataSource_gateway === CONT TestAccVPCEndpointServiceDataSource_CustomFilter_tags === CONT TestAccVPCEndpointServiceDataSource_custom --- PASS: TestAccVPCEndpointServiceDataSource_gateway (13.29s) --- PASS: TestAccVPCEndpointServiceDataSource_CustomFilter_tags (241.21s) === CONT TestAccVPCEndpointServiceDataSource_Custom_filter --- PASS: TestAccVPCEndpointServiceDataSource_custom (243.18s) === CONT TestAccVPCEndpointServiceDataSource_interface --- PASS: TestAccVPCEndpointServiceDataSource_interface (12.97s) === CONT TestAccVPCEndpointServiceDataSource_ServiceType_interface --- PASS: TestAccVPCEndpointServiceDataSource_ServiceType_interface (11.03s) === CONT TestAccVPCEndpointServiceDataSource_ServiceType_gateway --- PASS: TestAccVPCEndpointServiceDataSource_ServiceType_gateway (11.02s) --- PASS: TestAccVPCEndpointServiceDataSource_Custom_filter (249.41s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 494.769s

ewbankkit · 2022-06-21T19:13:51Z

% make providerlint golangci-lint semall
==> Checking source code with providerlint...
==> Checking source code with golangci-lint...
==> Running Semgrep checks locally (must have semgrep installed)...
Scanning 3993 files with 37 go rules.
  100%|██████████████████████████████████████████████████████████████████████████████████████████████████████████████████|3993/3993 tasks

Some files were skipped or only partially analyzed.
  Scan was limited to files tracked by git.
  Scan skipped: 1613 files matching .semgrepignore patterns
  For a full list of skipped files, run semgrep with the --verbose flag.

Ran 37 rules on 3993 files: 0 findings.
If Semgrep missed a finding, please send us feedback to let us know!
  $ semgrep shouldafound --help
Scanning 957 files with 199 go rules.
  100%|████████████████████████████████████████████████████████████████████████████████████████████████████████████████████|957/957 tasks

Some files were skipped or only partially analyzed.
  Scan was limited to files tracked by git.
  Scan skipped: 1613 files matching .semgrepignore patterns
  For a full list of skipped files, run semgrep with the --verbose flag.

Ran 199 rules on 957 files: 0 findings.
If Semgrep missed a finding, please send us feedback to let us know!
  $ semgrep shouldafound --help
Scanning 1078 files with 197 go rules.
  100%|██████████████████████████████████████████████████████████████████████████████████████████████████████████████████|1078/1078 tasks

Some files were skipped or only partially analyzed.
  Scan was limited to files tracked by git.
  Scan skipped: 1613 files matching .semgrepignore patterns
  For a full list of skipped files, run semgrep with the --verbose flag.

Ran 198 rules on 1078 files: 0 findings.
If Semgrep missed a finding, please send us feedback to let us know!
  $ semgrep shouldafound --help
Scanning 790 files with 194 go rules.
  100%|████████████████████████████████████████████████████████████████████████████████████████████████████████████████████|790/790 tasks

Some files were skipped or only partially analyzed.
  Scan was limited to files tracked by git.
  Scan skipped: 1613 files matching .semgrepignore patterns
  For a full list of skipped files, run semgrep with the --verbose flag.

Ran 198 rules on 790 files: 0 findings.
If Semgrep missed a finding, please send us feedback to let us know!
  $ semgrep shouldafound --help
Scanning 1104 files with 198 go rules.
  100%|██████████████████████████████████████████████████████████████████████████████████████████████████████████████████|1104/1104 tasks

Some files were skipped or only partially analyzed.
  Scan was limited to files tracked by git.
  Scan skipped: 1613 files matching .semgrepignore patterns
  For a full list of skipped files, run semgrep with the --verbose flag.

Ran 198 rules on 1104 files: 0 findings.
If Semgrep missed a finding, please send us feedback to let us know!
  $ semgrep shouldafound --help

ewbankkit

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccVPCEndpointService_' PKG=ec2 ACCTEST_PARALLELISM=2      
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccVPCEndpointService_ -timeout 180m
=== RUN   TestAccVPCEndpointService_basic
=== PAUSE TestAccVPCEndpointService_basic
=== RUN   TestAccVPCEndpointService_disappears
=== PAUSE TestAccVPCEndpointService_disappears
=== RUN   TestAccVPCEndpointService_tags
=== PAUSE TestAccVPCEndpointService_tags
=== RUN   TestAccVPCEndpointService_networkLoadBalancerARNs
=== PAUSE TestAccVPCEndpointService_networkLoadBalancerARNs
=== RUN   TestAccVPCEndpointService_supportedIPAddressTypes
=== PAUSE TestAccVPCEndpointService_supportedIPAddressTypes
=== RUN   TestAccVPCEndpointService_allowedPrincipals
=== PAUSE TestAccVPCEndpointService_allowedPrincipals
=== RUN   TestAccVPCEndpointService_gatewayLoadBalancerARNs
=== PAUSE TestAccVPCEndpointService_gatewayLoadBalancerARNs
=== RUN   TestAccVPCEndpointService_privateDNSName
=== PAUSE TestAccVPCEndpointService_privateDNSName
=== CONT  TestAccVPCEndpointService_basic
=== CONT  TestAccVPCEndpointService_supportedIPAddressTypes
--- PASS: TestAccVPCEndpointService_basic (247.22s)
=== CONT  TestAccVPCEndpointService_privateDNSName
--- PASS: TestAccVPCEndpointService_supportedIPAddressTypes (263.89s)
=== CONT  TestAccVPCEndpointService_gatewayLoadBalancerARNs
--- PASS: TestAccVPCEndpointService_gatewayLoadBalancerARNs (199.27s)
=== CONT  TestAccVPCEndpointService_allowedPrincipals
--- PASS: TestAccVPCEndpointService_privateDNSName (265.40s)
=== CONT  TestAccVPCEndpointService_tags
--- PASS: TestAccVPCEndpointService_allowedPrincipals (282.44s)
=== CONT  TestAccVPCEndpointService_networkLoadBalancerARNs
--- PASS: TestAccVPCEndpointService_tags (283.33s)
=== CONT  TestAccVPCEndpointService_disappears
--- PASS: TestAccVPCEndpointService_networkLoadBalancerARNs (463.54s)
--- PASS: TestAccVPCEndpointService_disappears (240.70s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	1047.855s
% make testacc TESTARGS='-run=TestAccVPCEndpointServiceAllowedPrincipal_basic' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccVPCEndpointServiceAllowedPrincipal_basic -timeout 180m
=== RUN   TestAccVPCEndpointServiceAllowedPrincipal_basic
=== PAUSE TestAccVPCEndpointServiceAllowedPrincipal_basic
=== CONT  TestAccVPCEndpointServiceAllowedPrincipal_basic
--- PASS: TestAccVPCEndpointServiceAllowedPrincipal_basic (238.55s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	246.202s
% make testacc TESTARGS='-run=TestAccVPCEndpointServiceDataSource_' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccVPCEndpointServiceDataSource_ -timeout 180m
=== RUN   TestAccVPCEndpointServiceDataSource_gateway
=== PAUSE TestAccVPCEndpointServiceDataSource_gateway
=== RUN   TestAccVPCEndpointServiceDataSource_interface
=== PAUSE TestAccVPCEndpointServiceDataSource_interface
=== RUN   TestAccVPCEndpointServiceDataSource_custom
=== PAUSE TestAccVPCEndpointServiceDataSource_custom
=== RUN   TestAccVPCEndpointServiceDataSource_Custom_filter
=== PAUSE TestAccVPCEndpointServiceDataSource_Custom_filter
=== RUN   TestAccVPCEndpointServiceDataSource_CustomFilter_tags
=== PAUSE TestAccVPCEndpointServiceDataSource_CustomFilter_tags
=== RUN   TestAccVPCEndpointServiceDataSource_ServiceType_gateway
=== PAUSE TestAccVPCEndpointServiceDataSource_ServiceType_gateway
=== RUN   TestAccVPCEndpointServiceDataSource_ServiceType_interface
=== PAUSE TestAccVPCEndpointServiceDataSource_ServiceType_interface
=== CONT  TestAccVPCEndpointServiceDataSource_gateway
=== CONT  TestAccVPCEndpointServiceDataSource_CustomFilter_tags
=== CONT  TestAccVPCEndpointServiceDataSource_custom
--- PASS: TestAccVPCEndpointServiceDataSource_gateway (13.29s)
--- PASS: TestAccVPCEndpointServiceDataSource_CustomFilter_tags (241.21s)
=== CONT  TestAccVPCEndpointServiceDataSource_Custom_filter
--- PASS: TestAccVPCEndpointServiceDataSource_custom (243.18s)
=== CONT  TestAccVPCEndpointServiceDataSource_interface
--- PASS: TestAccVPCEndpointServiceDataSource_interface (12.97s)
=== CONT  TestAccVPCEndpointServiceDataSource_ServiceType_interface
--- PASS: TestAccVPCEndpointServiceDataSource_ServiceType_interface (11.03s)
=== CONT  TestAccVPCEndpointServiceDataSource_ServiceType_gateway
--- PASS: TestAccVPCEndpointServiceDataSource_ServiceType_gateway (11.02s)
--- PASS: TestAccVPCEndpointServiceDataSource_Custom_filter (249.41s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	494.769s

ewbankkit · 2022-06-21T19:14:43Z

@DrFaust92 Thanks for the contribution 🎉 👏.

github-actions · 2022-06-23T23:09:48Z

This functionality has been released in v4.20.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2022-07-24T02:41:27Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

ewbankkit and others added 4 commits June 28, 2021 15:09

r/aws_vpc_endpoint_service_allowed_principal: Tidy up acceptance test.

561c22f

Use 'aws_iam_session_context' to obtain issuer ARN.

419e077

add supported_ip_address_types arg

d6578d6

add supported_ip_address_types arg

effa1c0

changelog

88010e5

github-actions bot added documentation Introduces or discusses updates to documentation. service/vpc Issues and PRs that pertain to the vpc service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 6, 2022

DrFaust92 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 6, 2022

DrFaust92 marked this pull request as ready for review June 6, 2022 08:49

add to update list

7a23e2f

DrFaust92 changed the title ~~r/ec2_vpc_endpoint_service - add supported_ip_address_types argument~~ r/vpc_endpoint_service - add supported_ip_address_types argument Jun 6, 2022

DrFaust92 and others added 9 commits June 6, 2022 15:15

changelog

8f05159

r/aws_vpc_endpoint_service: Start to tidy up resource Create.

37f97ee

Add 'FindVPCEndpointServices' and friends.

f942f4c

Additional error messages to skip.

be33e10

Fix typos in 'TestAccVPCEndpointService_networkLoadBalancerARNs'.

97582a9

ewbankkit added 9 commits June 21, 2022 12:43

Generate paginator for 'DescribeVpcEndpointServices'.

ba703a7

Revert "Use 'aws_iam_session_context' to obtain issuer ARN."

07cba85

This reverts commit 419e077.

Revert "r/aws_vpc_endpoint_service_allowed_principal: Tidy up accepta…

62d841a

…nce test." This reverts commit 561c22f.

Merge branch 'main' into td-aws_vpc_endpoint_service_allowed_principa…

8a0b630

…l-use-aws_iam_session_context

Merge remote-tracking branch 'origin/td-aws_vpc_endpoint_service_allo…

9b26579

…wed_principal-use-aws_iam_session_context' into HEAD

Use 'aws_iam_session_context' to obtain issuer ARN.

039202f

Rename EC2 error code constants to match API's capitalization.

190a061

ewbankkit approved these changes Jun 21, 2022

View reviewed changes

ewbankkit merged commit 1ecdb14 into hashicorp:main Jun 21, 2022

github-actions bot added this to the v4.20.0 milestone Jun 21, 2022

DrFaust92 deleted the ec2-endpoint-service-ip-types branch June 23, 2022 06:10

github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

r/vpc_endpoint_service - add `supported_ip_address_types` argument #25189

r/vpc_endpoint_service - add `supported_ip_address_types` argument #25189

DrFaust92 commented Jun 6, 2022 •

edited

ewbankkit commented Jun 21, 2022

ewbankkit left a comment

ewbankkit commented Jun 21, 2022

github-actions bot commented Jun 23, 2022

github-actions bot commented Jul 24, 2022

r/vpc_endpoint_service - add supported_ip_address_types argument #25189

r/vpc_endpoint_service - add supported_ip_address_types argument #25189

Conversation

DrFaust92 commented Jun 6, 2022 • edited

Community Note

ewbankkit commented Jun 21, 2022

ewbankkit left a comment

Choose a reason for hiding this comment

ewbankkit commented Jun 21, 2022

github-actions bot commented Jun 23, 2022

github-actions bot commented Jul 24, 2022

r/vpc_endpoint_service - add `supported_ip_address_types` argument #25189

r/vpc_endpoint_service - add `supported_ip_address_types` argument #25189

DrFaust92 commented Jun 6, 2022 •

edited