Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aws_keyspaces_table collection data types #25230

Merged
merged 5 commits into from
Jun 22, 2022

Conversation

uchanchlani
Copy link

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #25229

Output from acceptance testing:

$ make testacc TESTS=TestAccXXX PKG=ec2

...

@github-actions github-actions bot added service/keyspaces Issues and PRs that pertain to the keyspaces service. needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. labels Jun 8, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @uchanchlani 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 8, 2022
@uchanchlani
Copy link
Author

uchanchlani commented Jun 13, 2022

@ewbankkit : Can you please approve the pull request if it looks okay?
This bug blocks an internal deployment in our organization

@github-actions github-actions bot added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Jun 22, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccKeyspacesTable_multipleColumns' PKG=keyspaces ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/keyspaces/... -v -count 1 -parallel 2  -run=TestAccKeyspacesTable_multipleColumns -timeout 180m
=== RUN   TestAccKeyspacesTable_multipleColumns
=== PAUSE TestAccKeyspacesTable_multipleColumns
=== CONT  TestAccKeyspacesTable_multipleColumns
--- PASS: TestAccKeyspacesTable_multipleColumns (110.16s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/keyspaces	117.396s

@ewbankkit
Copy link
Contributor

@uchanchlani Thanks for the contribution 🎉 👏.

@ewbankkit
Copy link
Contributor

% make providerlint golangci-lint 
==> Checking source code with providerlint...
==> Checking source code with golangci-lint...

@ewbankkit ewbankkit merged commit 64daad7 into hashicorp:main Jun 22, 2022
@github-actions github-actions bot added this to the v4.20.0 milestone Jun 22, 2022
@uchanchlani uchanchlani deleted the issue-25229 branch June 22, 2022 17:23
@github-actions
Copy link

This functionality has been released in v4.20.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/keyspaces Issues and PRs that pertain to the keyspaces service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_keyspaces_table doesn't support collections like list/set/map
3 participants