Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add resources to manage Detective in an Organization #25237

Merged
merged 22 commits into from
Oct 30, 2023
Merged

Add resources to manage Detective in an Organization #25237

merged 22 commits into from
Oct 30, 2023

Conversation

owenfarrell
Copy link
Contributor

@owenfarrell owenfarrell commented Jun 8, 2022 •
edited by ewbankkit
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #23201.
Closes #23459.

Output from acceptance testing:

$ make testacc TESTS='TestAccDetective_serial/Organization' PKG=detective
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/detective/... -v -count 1 -parallel 20 -run='TestAccDetective_serial/Organization'  -timeout 180m
=== RUN   TestAccDetective_serial
=== RUN   TestAccDetective_serial/OrganizationAdminAccount
=== RUN   TestAccDetective_serial/OrganizationAdminAccount/basic
=== RUN   TestAccDetective_serial/OrganizationAdminAccount/disappears
=== RUN   TestAccDetective_serial/OrganizationAdminAccount/MultiRegion
=== RUN   TestAccDetective_serial/OrganizationConfiguration
=== RUN   TestAccDetective_serial/OrganizationConfiguration/basic
--- PASS: TestAccDetective_serial (226.23s)
    --- PASS: TestAccDetective_serial/OrganizationAdminAccount (153.58s)
        --- PASS: TestAccDetective_serial/OrganizationAdminAccount/basic (69.92s)
        --- PASS: TestAccDetective_serial/OrganizationAdminAccount/disappears (34.18s)
        --- PASS: TestAccDetective_serial/OrganizationAdminAccount/MultiRegion (49.48s)
    --- PASS: TestAccDetective_serial/OrganizationConfiguration (72.64s)
        --- PASS: TestAccDetective_serial/OrganizationConfiguration/basic (72.64s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/detective  233.285s
...

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/detective Issues and PRs that pertain to the detective service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. labels Jun 8, 2022
@owenfarrell owenfarrell changed the title Detective organizations Add resources to manage Detective in an Organization Jun 8, 2022
@owenfarrell owenfarrell marked this pull request as ready for review July 1, 2022 17:47
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 19, 2022
@kyle-c-simmons
Copy link

Hi there, Is there any updates on this PR? Thanks 👍

@owenfarrell
r/aws_detective_admin_account - new resource
79e1133 
Signed-off-by: Owen Farrell <owen.farrell@gmail.com>
@owenfarrell
r/aws_detective_organization_configuration - new resource
85f43ac 
Signed-off-by: Owen Farrell <owen.farrell@gmail.com>
@github-actions github-actions bot added generators Relates to code generators. and removed provider Pertains to the provider itself, rather than any interaction with AWS. labels Apr 27, 2023
@owenfarrell
Copy link
Contributor Author

Rebased over a59ffd8. Made some updates to account for schema API changes for both resources and acceptance tests... but everything still passes okay.

@breathingdust breathingdust added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jul 26, 2023
@Jamie-Leon
Copy link

Jamie-Leon commented Oct 3, 2023 •
edited
Loading

@breathingdust / @justinretzolk is there any update on getting this released?

@gyoza
Copy link

gyoza commented Oct 3, 2023

This would be incredibly useful to us as well..

@ewbankkit ewbankkit self-assigned this Oct 26, 2023
@ewbankkit
Fix terrafmt error in documentation.
05b3dff
@ewbankkit
r/aws_detective_graph: Tidy up Create and Delete.
cf7d890
@ewbankkit
r/aws_detective_graph: Tidy up Read.
bc2c883
@ewbankkit
r/aws_detective_graph: Tidy up acceptance tests.
2b97e1d
@ewbankkit
Acceptance test output:
2fea973 
% make testacc TESTARGS='-run=TestAccDetective_serial/Graph' PKG=detective
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/detective/... -v -count 1 -parallel 20  -run=TestAccDetective_serial/Graph -timeout 360m
=== RUN   TestAccDetective_serial
=== PAUSE TestAccDetective_serial
=== CONT  TestAccDetective_serial
=== RUN   TestAccDetective_serial/Graph
=== RUN   TestAccDetective_serial/Graph/basic
=== RUN   TestAccDetective_serial/Graph/disappears
=== RUN   TestAccDetective_serial/Graph/tags
--- PASS: TestAccDetective_serial (121.20s)
    --- PASS: TestAccDetective_serial/Graph (121.20s)
        --- PASS: TestAccDetective_serial/Graph/basic (31.48s)
        --- PASS: TestAccDetective_serial/Graph/disappears (20.73s)
        --- PASS: TestAccDetective_serial/Graph/tags (68.99s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/detective	127.274s
@ewbankkit
r/aws_detective_member: Tidy up Create and Delete.
7ea6c3a
@ewbankkit
r/aws_detective_member: Tidy up Read.
c766a7e
@ewbankkit
Tidy up acceptance tests.
f25f150
@ewbankkit
r/aws_detective_invitation_accepter: Tidy up Create and Delete.
a5ecbeb
@ewbankkit
r/aws_detective_invitation_accepter: Tidy up Read.
ba85b4a
@ewbankkit
r/aws_detective_invitation_accepter: Tidy up acceptance tests.
107d0e4
@ewbankkit
r/aws_detective_organization_admin_account: Tidy up Create, Read and …
0a5d4fc 
…Delete.
@ewbankkit
r/aws_detective_organization_admin_account: Tidy up acceptance tests.
7b7b265
@ewbankkit
r/aws_detective_organization_configuration: Cosmetics.
6358347
@ewbankkit
Add CHANGELOG entries.
e02eacf
ewbankkit
ewbankkit approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccDetective_serial/Graph' PKG=detective
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/detective/... -v -count 1 -parallel 20  -run=TestAccDetective_serial/Graph -timeout 360m
=== RUN   TestAccDetective_serial
=== PAUSE TestAccDetective_serial
=== CONT  TestAccDetective_serial
=== RUN   TestAccDetective_serial/Graph
=== RUN   TestAccDetective_serial/Graph/basic
=== RUN   TestAccDetective_serial/Graph/disappears
=== RUN   TestAccDetective_serial/Graph/tags
--- PASS: TestAccDetective_serial (121.20s)
    --- PASS: TestAccDetective_serial/Graph (121.20s)
        --- PASS: TestAccDetective_serial/Graph/basic (31.48s)
        --- PASS: TestAccDetective_serial/Graph/disappears (20.73s)
        --- PASS: TestAccDetective_serial/Graph/tags (68.99s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/detective	127.274s

@ewbankkit ewbankkit merged commit 7bc5466 into hashicorp:main Oct 30, 2023
43 of 44 checks passed
@github-actions github-actions bot added this to the v5.24.0 milestone Oct 30, 2023
@owenfarrell owenfarrell deleted the detective_organizations branch October 30, 2023 23:39
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2023

This functionality has been released in v5.24.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/detective Issues and PRs that pertain to the detective service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.24.0
7 participants
@owenfarrell @kyle-c-simmons @Jamie-Leon @gyoza @ewbankkit @breathingdust @justinretzolk