Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_kendra_faq #25515

Merged
merged 22 commits into from
Jun 22, 2022
Merged

r/aws_kendra_faq #25515

merged 22 commits into from
Jun 22, 2022

Conversation

GlennChia
Copy link
Collaborator

@GlennChia GlennChia commented Jun 21, 2022 •
edited

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #13367

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccKendra_serial/Faq' PKG=kendra ACCTEST_TIMEOUT=220m
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kendra/... -v -count 1 -parallel 20  -run=TestAccKendra_serial/Faq -timeout 220m
=== RUN   TestAccKendra_serial
=== RUN   TestAccKendra_serial/Faq
=== RUN   TestAccKendra_serial/Faq/basic
=== RUN   TestAccKendra_serial/Faq/disappears
=== RUN   TestAccKendra_serial/Faq/tags
=== RUN   TestAccKendra_serial/Faq/Description
=== RUN   TestAccKendra_serial/Faq/FileFormat
=== RUN   TestAccKendra_serial/Faq/LanguageCode
--- PASS: TestAccKendra_serial (8921.17s)
    --- PASS: TestAccKendra_serial/Faq (8921.17s)
        --- PASS: TestAccKendra_serial/Faq/basic (1070.90s)
        --- PASS: TestAccKendra_serial/Faq/disappears (1880.72s)
        --- PASS: TestAccKendra_serial/Faq/tags (1782.86s)
        --- PASS: TestAccKendra_serial/Faq/Description (1004.78s)
        --- PASS: TestAccKendra_serial/Faq/FileFormat (1190.71s)
        --- PASS: TestAccKendra_serial/Faq/LanguageCode (1991.21s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/kendra     8921.285s

...

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/kendra Issues and PRs that pertain to the kendra service. needs-triage Waiting for first response or review from a maintainer. labels Jun 21, 2022
@anGie44 anGie44 mentioned this pull request Jun 21, 2022
Closed
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 21, 2022
@GlennChia GlennChia marked this pull request as ready for review June 21, 2022 18:41
@anGie44 anGie44 added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 21, 2022
@anGie44 anGie44 self-assigned this Jun 21, 2022
anGie44
anGie44 approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment on the index_id validation, otherwise LGTM 🚀

Output of acceptance tests:

$ make testacc TESTARGS='-run=TestAccKendra_serial/Faq' PKG=kendra ACCTEST_TIMEOUT=2000m
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kendra/... -v -count 1 -parallel 20  -run=TestAccKendra_serial/Faq -timeout 2000m
=== RUN   TestAccKendra_serial
=== RUN   TestAccKendra_serial/Faq
=== RUN   TestAccKendra_serial/Faq/basic
=== RUN   TestAccKendra_serial/Faq/disappears
=== RUN   TestAccKendra_serial/Faq/tags
=== RUN   TestAccKendra_serial/Faq/Description
=== RUN   TestAccKendra_serial/Faq/FileFormat
=== RUN   TestAccKendra_serial/Faq/LanguageCode
--- PASS: TestAccKendra_serial (9089.06s)
    --- PASS: TestAccKendra_serial/Faq (9089.06s)
        --- PASS: TestAccKendra_serial/Faq/basic (2006.85s)
        --- PASS: TestAccKendra_serial/Faq/disappears (1044.70s)
        --- PASS: TestAccKendra_serial/Faq/tags (2276.68s)
        --- PASS: TestAccKendra_serial/Faq/Description (1107.81s)
        --- PASS: TestAccKendra_serial/Faq/FileFormat (1097.96s)
        --- PASS: TestAccKendra_serial/Faq/LanguageCode (1555.07s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kendra	9092.812s

anGie44
anGie44 reviewed Jun 21, 2022
View reviewed changes
internal/service/kendra/faq.go
return []interface{}{m}
}

// Helpers added. Could be generated or somehow use go 1.18 generics?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah i think as we move more steadily towards integrating AWS Go V2, we'll likely have a pattern for this documented

GlennChia and others added 2 commits June 22, 2022 08:10
anGie44
anGie44 approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @GlennChia , recent commits LGTM 🚀

@anGie44 anGie44 added this to the v4.20.0 milestone Jun 22, 2022
@anGie44 anGie44 merged commit 815e6a7 into hashicorp:main Jun 22, 2022
@GlennChia GlennChia deleted the f-aws_kendra_faq branch June 22, 2022 02:08
@github-actions
Copy link

This functionality has been released in v4.20.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2022
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anGie44 anGie44 anGie44 approved these changes

Assignees

@anGie44 anGie44

Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. partner Contribution from a partner. provider Pertains to the provider itself, rather than any interaction with AWS. service/kendra Issues and PRs that pertain to the kendra service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.20.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GlennChia @anGie44 @justinretzolk