Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Opensearch ISM support #25527

Open
ellisroll-b opened this issue Jun 22, 2022 · 2 comments
Open

AWS Opensearch ISM support #25527

ellisroll-b opened this issue Jun 22, 2022 · 2 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. service/elasticache Issues and PRs that pertain to the elasticache service.

Comments

@ellisroll-b
Copy link

Community Note

  • Please vote on this issue by adding a 馃憤 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

With AWS supporting index state management in OpenSearch, many of us could remove home grown processing to manage older data. The new ISM functionality supports additional AWS hosted functionality supports a number of features that are attractive, many would be desirable to configure at deployment.

New or Affected Resource(s)

aws_elasticsearch_domain

Potentially new resources for ISM configuration, as your design sees fit.

References

https://docs.aws.amazon.com/opensearch-service/latest/developerguide/ism.html

  • #0000
@ellisroll-b ellisroll-b added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 22, 2022
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jun 22, 2022
@jackson-theisen
Copy link
Contributor

While I would be grateful for Terraform-managed ISM policies, I think the bigger issue at hand is interacting with OpenSearch APIs in general. There are a number of other API-managed components of a domain that don't have Terraform support, which results in a lot of 'home grown processing' (as @ellisroll-b said) for folks who prefer an everything-as-code approach. Examples would be index templates, audit/compliance configuration, monitor templates, roles/role mappings, etc. While https://github.com/phillbaker/terraform-provider-elasticsearch does a great job for many of these tasks, it's not built specifically for Amazon OpenSearch Service. IMO, the AWS provider needs to add support for HTTP requests to Amazon OpenSearch Service. With so many nuances imposed by the AWS managed service, we need guard rails and validation in place to guide developers into best practices for interacting with their domain. Here's a few examples of aforementioned nuances that I feel makes it worthwhile to add the functionality discussed (i'm sure there are a bunch more):

  • If your domain access policy includes IAM users or roles (or you use an IAM master user with fine-grained access control), you must sign requests to the OpenSearch APIs with your IAM credentials.
  • Various types of logs (application, audit, index slow, etc.) have CloudWatch dependencies.
  • Only a subset of ISM operations are supported.
  • Enabling plugins

@justinretzolk justinretzolk added service/elasticache Issues and PRs that pertain to the elasticache service. new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 20, 2022
@jackson-theisen
Copy link
Contributor

I have also opened phillbaker/terraform-provider-elasticsearch#299 and opensearch-project/opensearch-devops#82 which I feel would be worth coordinating with some of the maintainers on to determine what pieces belong where.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. service/elasticache Issues and PRs that pertain to the elasticache service.
Projects
None yet
Development

No branches or pull requests

3 participants