Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

d/aws_kendra_query_suggestions_block_list #25592

Merged
merged 6 commits into from Jun 28, 2022
Merged

d/aws_kendra_query_suggestions_block_list #25592

merged 6 commits into from Jun 28, 2022

Conversation

GlennChia
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #13367.

Output from acceptance testing:

$ ACCTEST_TIMEOUT=360m make testacc TESTARGS='-run=TestAccKendra_serial/QuerySuggestionsBlockList/DataSource_basic' PKG=kendra
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kendra/... -v -count 1 -parallel 20  -run=TestAccKendra_serial/QuerySuggestionsBlockList/DataSource_basic -timeout 360m
=== RUN   TestAccKendra_serial
=== RUN   TestAccKendra_serial/QuerySuggestionsBlockList
=== RUN   TestAccKendra_serial/QuerySuggestionsBlockList/DataSource_basic
--- PASS: TestAccKendra_serial (1444.55s)
    --- PASS: TestAccKendra_serial/QuerySuggestionsBlockList (1444.55s)
        --- PASS: TestAccKendra_serial/QuerySuggestionsBlockList/DataSource_basic (1444.55s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/kendra     1444.750s

...

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/kendra Issues and PRs that pertain to the kendra service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Jun 28, 2022
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jun 28, 2022
ewbankkit
ewbankkit approved these changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% ACCTEST_TIMEOUT=360m make testacc TESTARGS='-run=TestAccKendra_serial/QuerySuggestionsBlockList/DataSource_basic' PKG=kendra
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kendra/... -v -count 1 -parallel 20  -run=TestAccKendra_serial/QuerySuggestionsBlockList/DataSource_basic -timeout 360m
=== RUN   TestAccKendra_serial
=== RUN   TestAccKendra_serial/QuerySuggestionsBlockList
=== RUN   TestAccKendra_serial/QuerySuggestionsBlockList/DataSource_basic
--- PASS: TestAccKendra_serial (1683.50s)
    --- PASS: TestAccKendra_serial/QuerySuggestionsBlockList (1683.50s)
        --- PASS: TestAccKendra_serial/QuerySuggestionsBlockList/DataSource_basic (1683.50s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kendra	1687.655s

@ewbankkit
Copy link
Contributor

@GlennChia Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 3a7ba6b into hashicorp:main Jun 28, 2022
@github-actions github-actions bot added this to the v4.21.0 milestone Jun 28, 2022
@GlennChia GlennChia added the new-data-source Introduces a new data source. label Jun 28, 2022
@github-actions
Copy link

github-actions bot commented Jul 1, 2022

This functionality has been released in v4.21.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2022
@GlennChia GlennChia deleted the f-aws_kendra_query_suggestions_block_list branch August 6, 2022 02:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. provider Pertains to the provider itself, rather than any interaction with AWS. service/kendra Issues and PRs that pertain to the kendra service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.21.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GlennChia @ewbankkit