Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource: aws_transcribe_language_model #25698

Merged
merged 13 commits into from
Aug 3, 2022
Merged

New Resource: aws_transcribe_language_model #25698

merged 13 commits into from
Aug 3, 2022

Conversation

johnsonaj
Copy link
Contributor

@johnsonaj johnsonaj commented Jul 6, 2022 •
edited

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #18865

Output from acceptance testing:

$ ACCTEST_TIMEOUT=600m make testacc TESTARGS='-run=TestAccTranscribeLanguageModel_' PKG=transcribe

 ==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transcribe/... -v -count 1 -parallel 20  -run=TestAccTranscribeLanguageModel_ -timeout 600m
=== RUN   TestAccTranscribeLanguageModel_basic
=== PAUSE TestAccTranscribeLanguageModel_basic
=== RUN   TestAccTranscribeLanguageModel_updateTags
=== PAUSE TestAccTranscribeLanguageModel_updateTags
=== RUN   TestAccTranscribeLanguageModel_disappears
=== PAUSE TestAccTranscribeLanguageModel_disappears
=== CONT  TestAccTranscribeLanguageModel_basic
=== CONT  TestAccTranscribeLanguageModel_disappears
=== CONT  TestAccTranscribeLanguageModel_updateTags
--- PASS: TestAccTranscribeLanguageModel_basic (13008.89s)
--- PASS: TestAccTranscribeLanguageModel_updateTags (13079.16s)
--- PASS: TestAccTranscribeLanguageModel_disappears (13504.85s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/transcribe	13507.567s
...

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. generators Relates to code generators. provider Pertains to the provider itself, rather than any interaction with AWS. service/transcribe Issues and PRs that pertain to the transcribe service. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 6, 2022
@johnsonaj johnsonaj changed the title F aws transcribe language model New Resource: aws_transcribe_language_model Jul 7, 2022
@johnsonaj johnsonaj force-pushed the f-aws_transcribe_language_model branch from a1d4784 to 236c60d Compare July 26, 2022 16:55
@github-actions github-actions bot removed the tags Pertains to resource tagging. label Jul 26, 2022
@johnsonaj
add Transcribe language model
98f65f7 
r/aws_transcribe_language_model: add CRUD operations

r/aws_transcribe_language_model: update tests

r/aws_transcribe_language_model: fmt errors

r/aws_transcribe_language_model: update docs
@johnsonaj
cleanup
d9e6a8f
@johnsonaj
update to main
00ccdb1
@johnsonaj johnsonaj force-pushed the f-aws_transcribe_language_model branch from 236c60d to 00ccdb1 Compare July 26, 2022 17:07
@github-actions github-actions bot removed generators Relates to code generators. client-connections Pertains to the AWS Client and service connections. labels Jul 26, 2022
@github-actions github-actions bot added the sweeper Pertains to changes to or issues with the sweeper. label Aug 2, 2022
@johnsonaj johnsonaj added the new-resource Introduces a new resource. label Aug 2, 2022
@johnsonaj johnsonaj marked this pull request as ready for review August 3, 2022 00:47
ewbankkit
ewbankkit approved these changes Aug 3, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% ACCTEST_TIMEOUT=600m make testacc TESTARGS='-run=TestAccTranscribeLanguageModel_' PKG=transcribe
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transcribe/... -v -count 1 -parallel 20  -run=TestAccTranscribeLanguageModel_ -timeout 600m
=== RUN   TestAccTranscribeLanguageModel_basic
=== PAUSE TestAccTranscribeLanguageModel_basic
=== RUN   TestAccTranscribeLanguageModel_updateTags
=== PAUSE TestAccTranscribeLanguageModel_updateTags
=== RUN   TestAccTranscribeLanguageModel_disappears
=== PAUSE TestAccTranscribeLanguageModel_disappears
=== CONT  TestAccTranscribeLanguageModel_basic
=== CONT  TestAccTranscribeLanguageModel_disappears
=== CONT  TestAccTranscribeLanguageModel_updateTags
--- PASS: TestAccTranscribeLanguageModel_updateTags (12571.51s)
--- PASS: TestAccTranscribeLanguageModel_basic (13065.47s)
--- PASS: TestAccTranscribeLanguageModel_disappears (13117.34s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/transcribe	13121.322s

@johnsonaj johnsonaj merged commit b15fa7e into main Aug 3, 2022
@johnsonaj johnsonaj deleted the f-aws_transcribe_language_model branch August 3, 2022 19:08
@github-actions github-actions bot added this to the v4.25.0 milestone Aug 3, 2022
github-actions bot pushed a commit that referenced this pull request Aug 3, 2022
Update CHANGELOG.md for #25698
9c7fea5
@github-actions
Copy link

github-actions bot commented Aug 4, 2022

This functionality has been released in v4.25.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Sep 4, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/transcribe Issues and PRs that pertain to the transcribe service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.25.0
Development

Successfully merging this pull request may close these issues.

Feature Request: Amazon Transcribe
2 participants
@johnsonaj @ewbankkit