Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for tag maps to aws_ec2_tag resource #25739

Open
ecout opened this issue Jul 8, 2022 · 1 comment
Open

Add support for tag maps to aws_ec2_tag resource #25739

ecout opened this issue Jul 8, 2022 · 1 comment
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service.

Comments

@ecout
Copy link

ecout commented Jul 8, 2022

Community Note

  • Please vote on this issue by adding a 馃憤 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Please add support for tag map as input besides key,value pairs.
This resource is great for compensating for the AWS RAM Permision not allowing ec2:Describe Tags when sharing subnets, as described here:
https://discuss.hashicorp.com/t/aws-ram-not-passing-through-tags/12776/5
But given the documentation of this resource, the proposed use case in it: compensating for RAM lack of permissions for tag sharing of subnets across accounts, this resource is lacking support for tag maps as inputs. A valid use cases is to copy over all tags from the original account sharing resources with AWS RAM into the destination account. Using key and name one by one doesn't fit the format of how the subnet Data Sources store their tags(as a map). A 1 to 1 match where the entire tags attribute of the aws_subnet resource in the origin account is used as input for aws_ec2_tags to complete the tag transfer process would be best.

New or Affected Resource(s)

*aws_ec2_tag

Potential Terraform Configuration

# Copy-paste your Terraform configurations here - for large Terraform configs,
# please use a service like Dropbox and share a link to the ZIP file. For
# security, you can also encrypt the files using our GPG public key.

References

@ecout ecout added the enhancement Requests to existing resources that expand the functionality or scope. label Jul 8, 2022
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/ec2 Issues and PRs that pertain to the ec2 service. labels Jul 8, 2022
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Jul 20, 2022
@ayoh1
Copy link

ayoh1 commented Nov 21, 2022

+1 here... accepting map would help a lot when copying tags from root account to all the shared ones...

btw @ecout did you find a module or something that helps with this? getting the list of shared resources and apply tags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service.
Projects
None yet
Development

No branches or pull requests

3 participants