Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_location_geofence_collection: new resource #25762

Merged

Conversation

kamilturek
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #19629.

Output from acceptance testing:

$ make testacc PKG=location TESTS="TestAccLocationGeofenceCollection_"

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/location/... -v -count 1 -parallel 20 -run='TestAccLocationGeofenceCollection_'  -timeout 180m
=== RUN   TestAccLocationGeofenceCollection_basic
=== PAUSE TestAccLocationGeofenceCollection_basic
=== RUN   TestAccLocationGeofenceCollection_disappears
=== PAUSE TestAccLocationGeofenceCollection_disappears
=== RUN   TestAccLocationGeofenceCollection_description
=== PAUSE TestAccLocationGeofenceCollection_description
=== RUN   TestAccLocationGeofenceCollection_kmsKeyID
=== PAUSE TestAccLocationGeofenceCollection_kmsKeyID
=== RUN   TestAccLocationGeofenceCollection_tags
=== PAUSE TestAccLocationGeofenceCollection_tags
=== CONT  TestAccLocationGeofenceCollection_basic
=== CONT  TestAccLocationGeofenceCollection_description
=== CONT  TestAccLocationGeofenceCollection_kmsKeyID
=== CONT  TestAccLocationGeofenceCollection_tags
=== CONT  TestAccLocationGeofenceCollection_disappears
--- PASS: TestAccLocationGeofenceCollection_disappears (22.44s)
--- PASS: TestAccLocationGeofenceCollection_basic (31.93s)
--- PASS: TestAccLocationGeofenceCollection_kmsKeyID (33.71s)
--- PASS: TestAccLocationGeofenceCollection_description (51.57s)
--- PASS: TestAccLocationGeofenceCollection_tags (79.66s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/location   81.536s

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/location Issues and PRs that pertain to the location service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Jul 10, 2022
@kamilturek
Copy link
Collaborator Author

$ make providerlint
==> Checking source code with providerlint...
$ echo $?
0

@kamilturek kamilturek marked this pull request as ready for review July 11, 2022 15:58
@kamilturek kamilturek changed the title r/aws_location_geofence_collection - new resource r/aws_location_geofence_collection: new resource Jul 11, 2022
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jul 15, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccLocationGeofenceCollection_' PKG=location ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/location/... -v -count 1 -parallel 3  -run=TestAccLocationGeofenceCollection_ -timeout 180m
=== RUN   TestAccLocationGeofenceCollection_basic
=== PAUSE TestAccLocationGeofenceCollection_basic
=== RUN   TestAccLocationGeofenceCollection_disappears
=== PAUSE TestAccLocationGeofenceCollection_disappears
=== RUN   TestAccLocationGeofenceCollection_description
=== PAUSE TestAccLocationGeofenceCollection_description
=== RUN   TestAccLocationGeofenceCollection_kmsKeyID
=== PAUSE TestAccLocationGeofenceCollection_kmsKeyID
=== RUN   TestAccLocationGeofenceCollection_tags
=== PAUSE TestAccLocationGeofenceCollection_tags
=== CONT  TestAccLocationGeofenceCollection_basic
=== CONT  TestAccLocationGeofenceCollection_kmsKeyID
=== CONT  TestAccLocationGeofenceCollection_description
--- PASS: TestAccLocationGeofenceCollection_basic (19.75s)
=== CONT  TestAccLocationGeofenceCollection_tags
--- PASS: TestAccLocationGeofenceCollection_kmsKeyID (21.06s)
=== CONT  TestAccLocationGeofenceCollection_disappears
--- PASS: TestAccLocationGeofenceCollection_description (33.22s)
--- PASS: TestAccLocationGeofenceCollection_disappears (13.10s)
--- PASS: TestAccLocationGeofenceCollection_tags (40.71s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/location	64.612s

@ewbankkit
Copy link
Contributor

@kamilturek Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 8852737 into hashicorp:main Jul 15, 2022
@github-actions github-actions bot added this to the v4.23.0 milestone Jul 15, 2022
@kamilturek kamilturek deleted the f-aws-location-geofence-collection branch July 15, 2022 16:58
@github-actions
Copy link

This functionality has been released in v4.23.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/location Issues and PRs that pertain to the location service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants