Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dual stack support to Global Accelerator #26055

Merged
merged 8 commits into from
Aug 2, 2022

Conversation

bschaatsbergen
Copy link
Member

@bschaatsbergen bschaatsbergen commented Jul 30, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #26023

Output from acceptance testing:

bruno@pop-os ~/G/terraform-provider-aws (f/ipv6-global-accelerator)> make testacc TESTS=TestAccGlobalAcceleratorAccelerator_ PKG=globalaccelerator                                               (base) 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/globalaccelerator/... -v -count 1 -parallel 20 -run='TestAccGlobalAcceleratorAccelerator_'  -timeout 180m
=== RUN   TestAccGlobalAcceleratorAccelerator_basic
=== PAUSE TestAccGlobalAcceleratorAccelerator_basic
=== RUN   TestAccGlobalAcceleratorAccelerator_ipAddressType_dualStack
=== PAUSE TestAccGlobalAcceleratorAccelerator_ipAddressType_dualStack
=== RUN   TestAccGlobalAcceleratorAccelerator_disappears
=== PAUSE TestAccGlobalAcceleratorAccelerator_disappears
=== RUN   TestAccGlobalAcceleratorAccelerator_update
=== PAUSE TestAccGlobalAcceleratorAccelerator_update
=== RUN   TestAccGlobalAcceleratorAccelerator_attributes
=== PAUSE TestAccGlobalAcceleratorAccelerator_attributes
=== RUN   TestAccGlobalAcceleratorAccelerator_tags
=== PAUSE TestAccGlobalAcceleratorAccelerator_tags
=== CONT  TestAccGlobalAcceleratorAccelerator_basic
=== CONT  TestAccGlobalAcceleratorAccelerator_update
=== CONT  TestAccGlobalAcceleratorAccelerator_disappears
=== CONT  TestAccGlobalAcceleratorAccelerator_tags
=== CONT  TestAccGlobalAcceleratorAccelerator_ipAddressType_dualStack
=== CONT  TestAccGlobalAcceleratorAccelerator_attributes
--- PASS: TestAccGlobalAcceleratorAccelerator_disappears (70.96s)
--- PASS: TestAccGlobalAcceleratorAccelerator_basic (78.94s)
--- PASS: TestAccGlobalAcceleratorAccelerator_ipAddressType_dualStack (80.37s)
--- PASS: TestAccGlobalAcceleratorAccelerator_tags (115.19s)
--- PASS: TestAccGlobalAcceleratorAccelerator_update (215.47s)
--- PASS: TestAccGlobalAcceleratorAccelerator_attributes (330.73s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/globalaccelerator  330.789s

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/globalaccelerator Issues and PRs that pertain to the globalaccelerator service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. labels Jul 30, 2022
@bschaatsbergen
Copy link
Member Author

This PR is pending the aws-sdk-go update to 1.44.64

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Jul 30, 2022
@bschaatsbergen bschaatsbergen changed the title Add IPV6 support to Global Accelerator Add dual stack support to Global Accelerator Jul 30, 2022
@bschaatsbergen bschaatsbergen marked this pull request as ready for review August 1, 2022 20:14
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Aug 2, 2022
@ewbankkit ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label Aug 2, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccGlobalAcceleratorAccelerator_basic\|TestAccGlobalAcceleratorAccelerator_ipAddressType_dualStack' PKG=globalaccelerator ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/globalaccelerator/... -v -count 1 -parallel 2  -run=TestAccGlobalAcceleratorAccelerator_basic\|TestAccGlobalAcceleratorAccelerator_ipAddressType_dualStack -timeout 180m
=== RUN   TestAccGlobalAcceleratorAccelerator_basic
=== PAUSE TestAccGlobalAcceleratorAccelerator_basic
=== RUN   TestAccGlobalAcceleratorAccelerator_ipAddressType_dualStack
=== PAUSE TestAccGlobalAcceleratorAccelerator_ipAddressType_dualStack
=== CONT  TestAccGlobalAcceleratorAccelerator_basic
=== CONT  TestAccGlobalAcceleratorAccelerator_ipAddressType_dualStack
--- PASS: TestAccGlobalAcceleratorAccelerator_basic (68.56s)
--- PASS: TestAccGlobalAcceleratorAccelerator_ipAddressType_dualStack (74.97s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/globalaccelerator	78.959s

@ewbankkit
Copy link
Contributor

@bschaatsbergen Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 27c9688 into hashicorp:main Aug 2, 2022
@github-actions github-actions bot added this to the v4.25.0 milestone Aug 2, 2022
@bschaatsbergen bschaatsbergen deleted the f/ipv6-global-accelerator branch August 4, 2022 10:39
@github-actions
Copy link

github-actions bot commented Aug 4, 2022

This functionality has been released in v4.25.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Sep 4, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/globalaccelerator Issues and PRs that pertain to the globalaccelerator service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS Global Accelerator IPv6 Support
2 participants