Add tags and tags_all argument to aws_ecrpublic_repository

[yktakaha4]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Thanks for the great library!

I added the tags attribute to aws_ecrpublic_repository.
As this is my first time sending a PR to this repository, please let me know if I am not following the rules.

Implemented with reference to the contents of the ECR.

terraform-provider-aws/internal/service/ecr/repository_test.go

Lines 52 to 83 in d1e62c5

	func TestAccECRRepository_tags(t *testing.T) {
	var v1, v2 ecr.Repository
	rName := sdkacctest.RandomWithPrefix(acctest.ResourcePrefix)
	resourceName := "aws_ecr_repository.test"
	resource.ParallelTest(t, resource.TestCase{
	PreCheck: func() { acctest.PreCheck(t) },
	ErrorCheck: acctest.ErrorCheck(t, ecr.EndpointsID),
	ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories,
	CheckDestroy: testAccCheckRepositoryDestroy,
	Steps: []resource.TestStep{
	{
	Config: testAccRepositoryConfig_tags(rName),
	Check: resource.ComposeTestCheckFunc(
	testAccCheckRepositoryExists(resourceName, &v1),
	resource.TestCheckResourceAttr(resourceName, "name", rName),
	resource.TestCheckResourceAttr(resourceName, "tags.%", "2"),
	resource.TestCheckResourceAttr(resourceName, "tags.Usage", "original"),
	),
	},
	{
	Config: testAccRepositoryConfig_tagsChanged(rName),
	Check: resource.ComposeTestCheckFunc(
	testAccCheckRepositoryExists(resourceName, &v2),
	resource.TestCheckResourceAttr(resourceName, "name", rName),
	resource.TestCheckResourceAttr(resourceName, "tags.%", "1"),
	resource.TestCheckResourceAttr(resourceName, "tags.Usage", "changed"),
	),
	},
	},
	})
	}

Output from acceptance testing:

$ make testacc TESTS=TestAccECRPublicRepository PKG=ecrpublic 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecrpublic/... -v -count 1 -parallel 20 -run='TestAccECRPublicRepository'  -timeout 180m
=== RUN   TestAccECRPublicRepositoryPolicy_basic
=== PAUSE TestAccECRPublicRepositoryPolicy_basic
=== RUN   TestAccECRPublicRepositoryPolicy_disappears
=== PAUSE TestAccECRPublicRepositoryPolicy_disappears
=== RUN   TestAccECRPublicRepositoryPolicy_Disappears_repository
=== PAUSE TestAccECRPublicRepositoryPolicy_Disappears_repository
=== RUN   TestAccECRPublicRepositoryPolicy_iam
=== PAUSE TestAccECRPublicRepositoryPolicy_iam
=== RUN   TestAccECRPublicRepository_basic
=== PAUSE TestAccECRPublicRepository_basic
=== RUN   TestAccECRPublicRepository_tags
=== PAUSE TestAccECRPublicRepository_tags
=== RUN   TestAccECRPublicRepository_CatalogData_aboutText
=== PAUSE TestAccECRPublicRepository_CatalogData_aboutText
=== RUN   TestAccECRPublicRepository_CatalogData_architectures
=== PAUSE TestAccECRPublicRepository_CatalogData_architectures
=== RUN   TestAccECRPublicRepository_CatalogData_description
=== PAUSE TestAccECRPublicRepository_CatalogData_description
=== RUN   TestAccECRPublicRepository_CatalogData_operatingSystems
=== PAUSE TestAccECRPublicRepository_CatalogData_operatingSystems
=== RUN   TestAccECRPublicRepository_CatalogData_usageText
=== PAUSE TestAccECRPublicRepository_CatalogData_usageText
=== RUN   TestAccECRPublicRepository_CatalogData_logoImageBlob
=== PAUSE TestAccECRPublicRepository_CatalogData_logoImageBlob
=== RUN   TestAccECRPublicRepository_Basic_forceDestroy
=== PAUSE TestAccECRPublicRepository_Basic_forceDestroy
=== RUN   TestAccECRPublicRepository_disappears
=== PAUSE TestAccECRPublicRepository_disappears
=== CONT  TestAccECRPublicRepositoryPolicy_basic
=== CONT  TestAccECRPublicRepository_CatalogData_architectures
=== CONT  TestAccECRPublicRepository_basic
=== CONT  TestAccECRPublicRepositoryPolicy_Disappears_repository
=== CONT  TestAccECRPublicRepository_disappears
=== CONT  TestAccECRPublicRepository_CatalogData_operatingSystems
=== CONT  TestAccECRPublicRepository_CatalogData_aboutText
=== CONT  TestAccECRPublicRepository_Basic_forceDestroy
=== CONT  TestAccECRPublicRepository_CatalogData_logoImageBlob
=== CONT  TestAccECRPublicRepository_CatalogData_description
=== CONT  TestAccECRPublicRepositoryPolicy_disappears
=== CONT  TestAccECRPublicRepository_tags
=== CONT  TestAccECRPublicRepositoryPolicy_iam
=== CONT  TestAccECRPublicRepository_CatalogData_usageText
--- PASS: TestAccECRPublicRepository_disappears (49.05s)
--- PASS: TestAccECRPublicRepositoryPolicy_Disappears_repository (60.93s)
--- PASS: TestAccECRPublicRepositoryPolicy_disappears (68.74s)
--- PASS: TestAccECRPublicRepository_basic (96.88s)
--- PASS: TestAccECRPublicRepository_Basic_forceDestroy (108.88s)
--- PASS: TestAccECRPublicRepository_CatalogData_logoImageBlob (117.31s)
--- PASS: TestAccECRPublicRepository_tags (136.49s)
--- PASS: TestAccECRPublicRepository_CatalogData_architectures (156.76s)
--- PASS: TestAccECRPublicRepository_CatalogData_description (158.29s)
--- PASS: TestAccECRPublicRepository_CatalogData_usageText (158.95s)
--- PASS: TestAccECRPublicRepositoryPolicy_basic (159.27s)
--- PASS: TestAccECRPublicRepository_CatalogData_operatingSystems (159.48s)
--- PASS: TestAccECRPublicRepository_CatalogData_aboutText (163.74s)
--- PASS: TestAccECRPublicRepositoryPolicy_iam (168.92s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ecrpublic  168.971s

[github-actions]

Welcome @yktakaha4 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[ewbankkit]

LGTM 🚀.

% AWS_DEFAULT_REGION=us-east-1 make testacc TESTARGS='-run=TestAccECRPublicRepository_' PKG=ecrpublic ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecrpublic/... -v -count 1 -parallel 1  -run=TestAccECRPublicRepository_ -timeout 180m
=== RUN   TestAccECRPublicRepository_basic
=== PAUSE TestAccECRPublicRepository_basic
=== RUN   TestAccECRPublicRepository_tags
=== PAUSE TestAccECRPublicRepository_tags
=== RUN   TestAccECRPublicRepository_CatalogData_aboutText
=== PAUSE TestAccECRPublicRepository_CatalogData_aboutText
=== RUN   TestAccECRPublicRepository_CatalogData_architectures
=== PAUSE TestAccECRPublicRepository_CatalogData_architectures
=== RUN   TestAccECRPublicRepository_CatalogData_description
=== PAUSE TestAccECRPublicRepository_CatalogData_description
=== RUN   TestAccECRPublicRepository_CatalogData_operatingSystems
=== PAUSE TestAccECRPublicRepository_CatalogData_operatingSystems
=== RUN   TestAccECRPublicRepository_CatalogData_usageText
=== PAUSE TestAccECRPublicRepository_CatalogData_usageText
=== RUN   TestAccECRPublicRepository_CatalogData_logoImageBlob
=== PAUSE TestAccECRPublicRepository_CatalogData_logoImageBlob
=== RUN   TestAccECRPublicRepository_Basic_forceDestroy
=== PAUSE TestAccECRPublicRepository_Basic_forceDestroy
=== RUN   TestAccECRPublicRepository_disappears
=== PAUSE TestAccECRPublicRepository_disappears
=== CONT  TestAccECRPublicRepository_basic
--- PASS: TestAccECRPublicRepository_basic (12.66s)
=== CONT  TestAccECRPublicRepository_CatalogData_operatingSystems
--- PASS: TestAccECRPublicRepository_CatalogData_operatingSystems (16.14s)
=== CONT  TestAccECRPublicRepository_disappears
--- PASS: TestAccECRPublicRepository_disappears (6.80s)
=== CONT  TestAccECRPublicRepository_Basic_forceDestroy
--- PASS: TestAccECRPublicRepository_Basic_forceDestroy (9.93s)
=== CONT  TestAccECRPublicRepository_CatalogData_logoImageBlob
--- PASS: TestAccECRPublicRepository_CatalogData_logoImageBlob (9.82s)
=== CONT  TestAccECRPublicRepository_CatalogData_usageText
--- PASS: TestAccECRPublicRepository_CatalogData_usageText (16.16s)
=== CONT  TestAccECRPublicRepository_CatalogData_architectures
--- PASS: TestAccECRPublicRepository_CatalogData_architectures (18.00s)
=== CONT  TestAccECRPublicRepository_CatalogData_description
--- PASS: TestAccECRPublicRepository_CatalogData_description (16.20s)
=== CONT  TestAccECRPublicRepository_CatalogData_aboutText
--- PASS: TestAccECRPublicRepository_CatalogData_aboutText (16.95s)
=== CONT  TestAccECRPublicRepository_tags
--- PASS: TestAccECRPublicRepository_tags (22.74s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecrpublic	149.263s

[ewbankkit]

@yktakaha4 Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v4.25.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.