Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix InvalidRoleException creating aws_appstream_fleet #26060

Merged
merged 2 commits into from
Aug 1, 2022
Merged

Fix InvalidRoleException creating aws_appstream_fleet #26060

merged 2 commits into from
Aug 1, 2022

Conversation

david-wells-1
Copy link
Contributor

@david-wells-1 david-wells-1 commented Jul 31, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #25388

Output from acceptance testing:

make testacc TESTS=TestAccAppStreamFleet_basic PKG=appstream
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appstream/... -v -count 1 -parallel 20 -run='TestAccAppStreamFleet_basic'  -timeout 180m
=== RUN   TestAccAppStreamFleet_basic
=== PAUSE TestAccAppStreamFleet_basic
=== CONT  TestAccAppStreamFleet_basic
--- PASS: TestAccAppStreamFleet_basic (752.44s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appstream	754.893s

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. service/appstream Issues and PRs that pertain to the appstream service. labels Jul 31, 2022
@david-wells-1 david-wells-1 changed the title Fix InvalidRoleException creating aws_appstream_fleet Fix InvalidRoleException creating aws_appstream_fleet Aug 1, 2022
@david-wells-1 david-wells-1 changed the title Fix InvalidRoleException creating aws_appstream_fleet Fix InvalidRoleException creating aws_appstream_fleet Aug 1, 2022
@ewbankkit ewbankkit added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 1, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccAppStreamFleet_basic PKG=appstream
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appstream/... -v -count 1 -parallel 20 -run='TestAccAppStreamFleet_basic'  -timeout 180m
=== RUN   TestAccAppStreamFleet_basic
=== PAUSE TestAccAppStreamFleet_basic
=== CONT  TestAccAppStreamFleet_basic
--- PASS: TestAccAppStreamFleet_basic (824.28s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appstream	828.122s

@ewbankkit
Copy link
Contributor

@david-wells-1 Thanks for the contribution 🎉 👏.

@david-wells-1
Copy link
Contributor Author

thanks @ewbankkit Im not sure why the Dependency Checks / go mod check is now failing? Was successful when the PR submitted.

@ewbankkit
Copy link
Contributor

@david-wells-1 That was because of a PR merged between you opening the PR and me making that slight tweak to the CHANGELOG entry.
I fixed the go.mod issue on main.

@ewbankkit ewbankkit merged commit 750bb20 into hashicorp:main Aug 1, 2022
@github-actions github-actions bot added this to the v4.25.0 milestone Aug 1, 2022
@github-actions
Copy link

github-actions bot commented Aug 4, 2022

This functionality has been released in v4.25.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Sep 4, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/appstream Issues and PRs that pertain to the appstream service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InvalidRoleException when creating aws_appstream_fleet with new role
2 participants