ec2: Allow customizable timeouts for various resources and data sources

[YakDriver]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #26026
Closes #11342
Closes #16500
Closes #15921

Output from acceptance testing:

% make testacc TESTS=TestAccEC2InstanceDataSource_timeout PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2InstanceDataSource_timeout'  -timeout 180m
--- PASS: TestAccEC2InstanceDataSource_timeout (125.24s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	126.925s
% make testacc TESTS=TestAccEC2InstancesDataSource_timeout PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2InstancesDataSource_timeout'  -timeout 180m
--- PASS: TestAccEC2InstancesDataSource_timeout (122.64s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	124.032s

[github-actions]

This functionality has been released in v4.25.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[jwfh]

Seeing issues with v4.25.0 provider with hanging plans and crashes, wondering if it could be related to this change. Reverting to v4.24.0 fixes the issues.

[Jpk518]

Seeing issues with v4.25.0 provider with hanging plans and crashes, wondering if it could be related to this change. Reverting to v4.24.0 fixes the issues.

We narrowed this down to be a specific issue with any data lookup performed on provider v4.25.0 with terraform v0.13.1. Other Terraform versions seem to be fine but this specific TF version panics with these new changes.

[ewbankkit]

@jwfh @Jpk518 Could you please raise a new Issue for this? Thanks.

[vavdoshka]

Hello @YakDriver @ewbankkit

I'm trying to understand what this feature does, please help. Based on the description of the linked issues and what I understood, it now should allow to "wait" for the data resource to come up and fail it won't after 20 minutes (by default).
And so either my understanding is not correct, or it does not work as planned:

terraform {
  required_providers {
    aws = {
      source  = "hashicorp/aws"
      version = "4.25.0"
    }
  }
}

provider "aws" {
  region = "us-east-1"
}


resource "aws_vpc" "this" {
  cidr_block           = "10.0.0.0/16"
    tags                 = {
        Name = "test"
    }
}

data "aws_vpc" "this" {
  filter {
    name   = "tag:Name"
    values = ["test"]
  }
}

➜  test git:(master) ✗ terraform --version
Terraform v1.2.7
on darwin_amd64
+ provider registry.terraform.io/hashicorp/aws v4.25.0
➜  test git:(master) ✗ terraform plan     
data.aws_vpc.this: Reading...
╷
│ Error: no matching EC2 VPC found
│ 
│   with data.aws_vpc.this,
│   on main.tf line 23, in data "aws_vpc" "this":
│   23: data "aws_vpc" "this" {
│ 

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.