Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dual stack support for Amazon Aurora #26489

Merged
merged 30 commits into from Sep 7, 2022
Merged

Add dual stack support for Amazon Aurora #26489

merged 30 commits into from Sep 7, 2022

Conversation

bschaatsbergen
Copy link
Member

@bschaatsbergen bschaatsbergen commented Aug 25, 2022 •
edited

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #26487

Output from acceptance testing:

make testacc TESTS=TestAccRDSCluster_networkType PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSCluster_networkType'  -timeout 180m
=== RUN   TestAccRDSCluster_networkType
=== PAUSE TestAccRDSCluster_networkType
=== CONT  TestAccRDSCluster_networkType
--- PASS: TestAccRDSCluster_networkType (225.83s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/rds        227.513s

make testacc TESTS=TestAccRDSClusterInstance_basic PKG=rds                                                                                                                                                     (base) 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSClusterInstance_basic'  -timeout 180m
=== RUN   TestAccRDSClusterInstance_basic
=== PAUSE TestAccRDSClusterInstance_basic
=== CONT  TestAccRDSClusterInstance_basic
--- PASS: TestAccRDSClusterInstance_basic (897.46s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/rds        897.502s

@github-actions github-actions bot added service/rds Issues and PRs that pertain to the rds service. size/S Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Aug 25, 2022
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 26, 2022
@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed size/S Managed by automation to categorize the size of a PR. labels Sep 3, 2022
@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. and removed size/M Managed by automation to categorize the size of a PR. labels Sep 3, 2022
@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Sep 4, 2022
@bschaatsbergen bschaatsbergen marked this pull request as ready for review September 4, 2022 16:21
bschaatsbergen and others added 7 commits September 4, 2022 18:37
@bschaatsbergen
Remove dupe underscore
b8aec46
@ewbankkit
Tweak CHANGELOG entry.
2371979
@ewbankkit
r/aws_rds_cluster: Alphabetize attributes.
43d8963
@ewbankkit
r/aws_rds_cluster: Tidy up resource Delete.
bc8b519 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccRDSCluster_basic' PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSCluster_basic -timeout 180m
=== RUN   TestAccRDSCluster_basic
=== PAUSE TestAccRDSCluster_basic
=== CONT  TestAccRDSCluster_basic
--- PASS: TestAccRDSCluster_basic (161.34s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	165.297s
@ewbankkit
r/aws_rds_cluster: Tidy up resource Read.
c6f6ba5 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccRDSCluster_basic' PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSCluster_basic -timeout 180m
=== RUN   TestAccRDSCluster_basic
=== PAUSE TestAccRDSCluster_basic
=== CONT  TestAccRDSCluster_basic
--- PASS: TestAccRDSCluster_basic (173.13s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	177.144s
@ewbankkit
r/aws_rds_cluster: Add 'TestAccRDSCluster_disappears' (hashicorp#13826).
b9189c6 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccRDSCluster_disappears' PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSCluster_disappears -timeout 180m
=== RUN   TestAccRDSCluster_disappears
=== PAUSE TestAccRDSCluster_disappears
=== CONT  TestAccRDSCluster_disappears
--- PASS: TestAccRDSCluster_disappears (106.05s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	110.200s
@ewbankkit
r/aws_rds_cluster: 'WaitForClusterDeletion' -> 'waitDBClusterDeleted'.
6caf6a5 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccRDSCluster_basic' PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSCluster_basic -timeout 180m
=== RUN   TestAccRDSCluster_basic
=== PAUSE TestAccRDSCluster_basic
=== CONT  TestAccRDSCluster_basic
--- PASS: TestAccRDSCluster_basic (169.79s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	176.258s
@ewbankkit
r/aws_rds_cluster: Tidy up resource Create.
386649a 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccRDSCluster_basic\|TestAccRDSCluster_s3Restore\|TestAccRDSCluster_pointInTimeRestore\|TestAccRDSCluster_updateIAMRoles\|TestAccRDSCluster_snapshotIdentifier' PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSCluster_basic\|TestAccRDSCluster_s3Restore\|TestAccRDSCluster_pointInTimeRestore\|TestAccRDSCluster_updateIAMRoles\|TestAccRDSCluster_snapshotIdentifier -timeout 180m
=== RUN   TestAccRDSCluster_basic
=== PAUSE TestAccRDSCluster_basic
=== RUN   TestAccRDSCluster_s3Restore
=== PAUSE TestAccRDSCluster_s3Restore
=== RUN   TestAccRDSCluster_pointInTimeRestore
=== PAUSE TestAccRDSCluster_pointInTimeRestore
=== RUN   TestAccRDSCluster_updateIAMRoles
=== PAUSE TestAccRDSCluster_updateIAMRoles
=== RUN   TestAccRDSCluster_snapshotIdentifier
=== PAUSE TestAccRDSCluster_snapshotIdentifier
=== CONT  TestAccRDSCluster_basic
=== CONT  TestAccRDSCluster_updateIAMRoles
--- PASS: TestAccRDSCluster_basic (161.33s)
=== CONT  TestAccRDSCluster_pointInTimeRestore
--- PASS: TestAccRDSCluster_updateIAMRoles (168.23s)
=== CONT  TestAccRDSCluster_snapshotIdentifier
--- PASS: TestAccRDSCluster_snapshotIdentifier (358.47s)
=== CONT  TestAccRDSCluster_s3Restore
--- PASS: TestAccRDSCluster_pointInTimeRestore (371.90s)
=== CONT  TestAccRDSCluster_s3Restore
    cluster_test.go:546: Step 1/1 error: Error running apply: exit status 1

        Error: waiting for RDS Cluster (tf-test-20220906170825745800000001) create: unexpected state 'migration-failed', wanted target 'available'. last error: %!s(<nil>)

          with aws_rds_cluster.test,
          on terraform_plugin_test.tf line 74, in resource "aws_rds_cluster" "test":
          74: resource "aws_rds_cluster" "test" {

--- FAIL: TestAccRDSCluster_s3Restore (1558.92s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/rds	2089.773s
FAIL
make: *** [testacc] Error 1
@ewbankkit
r/aws_rds_cluster: Tidy up resource Update.
eb220bd
@ewbankkit
r/aws_rds_cluster: Tidy up 'TestAccRDSCluster_takeFinalSnapshot'.
2c9a94f 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccRDSCluster_takeFinalSnapshot' PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSCluster_takeFinalSnapshot -timeout 180m
=== RUN   TestAccRDSCluster_takeFinalSnapshot
=== PAUSE TestAccRDSCluster_takeFinalSnapshot
=== CONT  TestAccRDSCluster_takeFinalSnapshot
--- PASS: TestAccRDSCluster_takeFinalSnapshot (179.72s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	184.293s
@ewbankkit
r/aws_rds_cluster: Tidy up 'TestAccRDSCluster_identifierGenerated' an…
fd09c5a 
…d 'TestAccRDSCluster_identifierPrefix'.

Acceptance test output:

% make testacc TESTARGS='-run=TestAccRDSCluster_identifierGenerated\|TestAccRDSCluster_identifierPrefix' PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSCluster_identifierGenerated\|TestAccRDSCluster_identifierPrefix -timeout 180m
=== RUN   TestAccRDSCluster_identifierGenerated
=== PAUSE TestAccRDSCluster_identifierGenerated
=== RUN   TestAccRDSCluster_identifierPrefix
=== PAUSE TestAccRDSCluster_identifierPrefix
=== CONT  TestAccRDSCluster_identifierGenerated
=== CONT  TestAccRDSCluster_identifierPrefix
--- PASS: TestAccRDSCluster_identifierPrefix (151.61s)
--- PASS: TestAccRDSCluster_identifierGenerated (151.63s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	155.759s
@ewbankkit
r/aws_rds_cluster: Tidy up 'TestAccRDSCluster_availabilityZones', 'Te…
ad4bd8f 
…stAccRDSCluster_dbSubnetGroupName' and 'TestAccRDSCluster_pointInTimeRestore'.

Acceptance test output:

% make testacc TESTARGS='-run=TestAccRDSCluster_availabilityZones\|TestAccRDSCluster_dbSubnetGroupName\|TestAccRDSCluster_pointInTimeRestore' PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSCluster_availabilityZones\|TestAccRDSCluster_dbSubnetGroupName\|TestAccRDSCluster_pointInTimeRestore -timeout 180m
=== RUN   TestAccRDSCluster_availabilityZones
=== PAUSE TestAccRDSCluster_availabilityZones
=== RUN   TestAccRDSCluster_dbSubnetGroupName
=== PAUSE TestAccRDSCluster_dbSubnetGroupName
=== RUN   TestAccRDSCluster_pointInTimeRestore
=== PAUSE TestAccRDSCluster_pointInTimeRestore
=== CONT  TestAccRDSCluster_availabilityZones
=== CONT  TestAccRDSCluster_pointInTimeRestore
--- PASS: TestAccRDSCluster_availabilityZones (142.59s)
=== CONT  TestAccRDSCluster_dbSubnetGroupName
--- PASS: TestAccRDSCluster_dbSubnetGroupName (163.82s)
--- PASS: TestAccRDSCluster_pointInTimeRestore (355.39s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	359.505s
@ewbankkit
r/aws_rds_cluster: Tidy up 'TestAccRDSCluster_PointInTimeRestore_enab…
8ade83b 
…ledCloudWatchLogsExports', 'TestAccRDSCluster_networkType' and 'TestAccRDSCluster_EngineMode_multiMaster'.

Acceptance test output:

% make testacc TESTARGS='-run=TestAccRDSCluster_PointInTimeRestore_enabledCloudWatchLogsExports\|TestAccRDSCluster_networkType\|TestAccRDSCluster_EngineMode_multiMaster' PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSCluster_PointInTimeRestore_enabledCloudWatchLogsExports\|TestAccRDSCluster_networkType\|TestAccRDSCluster_EngineMode_multiMaster -timeout 180m
=== RUN   TestAccRDSCluster_PointInTimeRestore_enabledCloudWatchLogsExports
=== PAUSE TestAccRDSCluster_PointInTimeRestore_enabledCloudWatchLogsExports
=== RUN   TestAccRDSCluster_networkType
=== PAUSE TestAccRDSCluster_networkType
=== RUN   TestAccRDSCluster_EngineMode_multiMaster
=== PAUSE TestAccRDSCluster_EngineMode_multiMaster
=== CONT  TestAccRDSCluster_PointInTimeRestore_enabledCloudWatchLogsExports
=== CONT  TestAccRDSCluster_EngineMode_multiMaster
--- PASS: TestAccRDSCluster_EngineMode_multiMaster (179.05s)
=== CONT  TestAccRDSCluster_networkType
--- PASS: TestAccRDSCluster_PointInTimeRestore_enabledCloudWatchLogsExports (331.96s)
--- PASS: TestAccRDSCluster_networkType (275.56s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	458.717s
@ewbankkit
r/aws_rds_cluster: Tidy up 'TestAccRDSCluster_ReplicationSourceIdenti…
e39d54a 
…fier_kmsKeyID'.

Acceptance test output:

% make testacc TESTARGS='-run=TestAccRDSCluster_ReplicationSourceIdentifier_kmsKeyID' PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSCluster_ReplicationSourceIdentifier_kmsKeyID -timeout 180m
=== RUN   TestAccRDSCluster_ReplicationSourceIdentifier_kmsKeyID
=== PAUSE TestAccRDSCluster_ReplicationSourceIdentifier_kmsKeyID
=== CONT  TestAccRDSCluster_ReplicationSourceIdentifier_kmsKeyID
--- PASS: TestAccRDSCluster_ReplicationSourceIdentifier_kmsKeyID (1574.73s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	1578.477s
@ewbankkit
r/aws_rds_cluster_instance: Test 'network_type' in 'TestAccRDSCluster…
2c715b8 
…Instance_basic'.

Acceptance test output:

% make testacc TESTARGS='-run=TestAccRDSClusterInstance_basic' PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSClusterInstance_basic -timeout 180m
=== RUN   TestAccRDSClusterInstance_basic
=== PAUSE TestAccRDSClusterInstance_basic
=== CONT  TestAccRDSClusterInstance_basic
--- PASS: TestAccRDSClusterInstance_basic (794.60s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	798.711s
@ewbankkit
Remove 'TestAccRDSCluster_s3Restore'.
b23e084
@ewbankkit
r/aws_rds_global_cluster: Prevent spurious 'engine_version' drift.
47dae12
@ewbankkit
d/aws_rds_cluster: Add 'network_type' attribute.
e35f649 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccRDSClusterDataSource_' PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSClusterDataSource_ -timeout 180m
=== RUN   TestAccRDSClusterDataSource_basic
=== PAUSE TestAccRDSClusterDataSource_basic
=== CONT  TestAccRDSClusterDataSource_basic
--- PASS: TestAccRDSClusterDataSource_basic (135.58s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	140.333s
@ewbankkit
Fix golangi-lint 'unparam'.
94efb6a
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Sep 7, 2022
ewbankkit
ewbankkit approved these changes Sep 7, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRDSClusterDataSource_' PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSClusterDataSource_ -timeout 180m
=== RUN   TestAccRDSClusterDataSource_basic
=== PAUSE TestAccRDSClusterDataSource_basic
=== CONT  TestAccRDSClusterDataSource_basic
--- PASS: TestAccRDSClusterDataSource_basic (135.58s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	140.333s
% make testacc TESTARGS='-run=TestAccRDSClusterInstance_basic' PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSClusterInstance_basic -timeout 180m
=== RUN   TestAccRDSClusterInstance_basic
=== PAUSE TestAccRDSClusterInstance_basic
=== CONT  TestAccRDSClusterInstance_basic
--- PASS: TestAccRDSClusterInstance_basic (794.60s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	798.711s
% ACCTEST_TIMEOUT=360m make testacc TESTARGS='-run=TestAccRDSCluster_' PKG=rds ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 3  -run=TestAccRDSCluster_ -timeout 360m
=== RUN   TestAccRDSCluster_basic
=== PAUSE TestAccRDSCluster_basic
=== RUN   TestAccRDSCluster_disappears
=== PAUSE TestAccRDSCluster_disappears
=== RUN   TestAccRDSCluster_tags
=== PAUSE TestAccRDSCluster_tags
=== RUN   TestAccRDSCluster_identifierGenerated
=== PAUSE TestAccRDSCluster_identifierGenerated
=== RUN   TestAccRDSCluster_identifierPrefix
=== PAUSE TestAccRDSCluster_identifierPrefix
=== RUN   TestAccRDSCluster_allowMajorVersionUpgrade
=== PAUSE TestAccRDSCluster_allowMajorVersionUpgrade
=== RUN   TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParametersApplyImm
=== PAUSE TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParametersApplyImm
=== RUN   TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParameters
=== PAUSE TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParameters
=== RUN   TestAccRDSCluster_onlyMajorVersion
=== PAUSE TestAccRDSCluster_onlyMajorVersion
=== RUN   TestAccRDSCluster_availabilityZones
=== PAUSE TestAccRDSCluster_availabilityZones
=== RUN   TestAccRDSCluster_storageType
=== PAUSE TestAccRDSCluster_storageType
=== RUN   TestAccRDSCluster_allocatedStorage
=== PAUSE TestAccRDSCluster_allocatedStorage
=== RUN   TestAccRDSCluster_iops
=== PAUSE TestAccRDSCluster_iops
=== RUN   TestAccRDSCluster_dbClusterInstanceClass
=== PAUSE TestAccRDSCluster_dbClusterInstanceClass
=== RUN   TestAccRDSCluster_backtrackWindow
=== PAUSE TestAccRDSCluster_backtrackWindow
=== RUN   TestAccRDSCluster_dbSubnetGroupName
=== PAUSE TestAccRDSCluster_dbSubnetGroupName
=== RUN   TestAccRDSCluster_pointInTimeRestore
=== PAUSE TestAccRDSCluster_pointInTimeRestore
=== RUN   TestAccRDSCluster_PointInTimeRestore_enabledCloudWatchLogsExports
=== PAUSE TestAccRDSCluster_PointInTimeRestore_enabledCloudWatchLogsExports
=== RUN   TestAccRDSCluster_takeFinalSnapshot
=== PAUSE TestAccRDSCluster_takeFinalSnapshot
=== RUN   TestAccRDSCluster_missingUserNameCausesError
=== PAUSE TestAccRDSCluster_missingUserNameCausesError
=== RUN   TestAccRDSCluster_EnabledCloudWatchLogsExports_mySQL
=== PAUSE TestAccRDSCluster_EnabledCloudWatchLogsExports_mySQL
=== RUN   TestAccRDSCluster_EnabledCloudWatchLogsExports_postgresql
=== PAUSE TestAccRDSCluster_EnabledCloudWatchLogsExports_postgresql
=== RUN   TestAccRDSCluster_updateIAMRoles
=== PAUSE TestAccRDSCluster_updateIAMRoles
=== RUN   TestAccRDSCluster_kmsKey
=== PAUSE TestAccRDSCluster_kmsKey
=== RUN   TestAccRDSCluster_networkType
=== PAUSE TestAccRDSCluster_networkType
=== RUN   TestAccRDSCluster_encrypted
=== PAUSE TestAccRDSCluster_encrypted
=== RUN   TestAccRDSCluster_copyTagsToSnapshot
=== PAUSE TestAccRDSCluster_copyTagsToSnapshot
=== RUN   TestAccRDSCluster_ReplicationSourceIdentifier_kmsKeyID
=== PAUSE TestAccRDSCluster_ReplicationSourceIdentifier_kmsKeyID
=== RUN   TestAccRDSCluster_backupsUpdate
=== PAUSE TestAccRDSCluster_backupsUpdate
=== RUN   TestAccRDSCluster_iamAuth
=== PAUSE TestAccRDSCluster_iamAuth
=== RUN   TestAccRDSCluster_deletionProtection
=== PAUSE TestAccRDSCluster_deletionProtection
=== RUN   TestAccRDSCluster_engineMode
=== PAUSE TestAccRDSCluster_engineMode
=== RUN   TestAccRDSCluster_EngineMode_global
=== PAUSE TestAccRDSCluster_EngineMode_global
=== RUN   TestAccRDSCluster_EngineMode_multiMaster
=== PAUSE TestAccRDSCluster_EngineMode_multiMaster
=== RUN   TestAccRDSCluster_EngineMode_parallelQuery
=== PAUSE TestAccRDSCluster_EngineMode_parallelQuery
=== RUN   TestAccRDSCluster_engineVersion
=== PAUSE TestAccRDSCluster_engineVersion
=== RUN   TestAccRDSCluster_engineVersionWithPrimaryInstance
=== PAUSE TestAccRDSCluster_engineVersionWithPrimaryInstance
=== RUN   TestAccRDSCluster_GlobalClusterIdentifierEngineMode_global
=== PAUSE TestAccRDSCluster_GlobalClusterIdentifierEngineMode_global
=== RUN   TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_add
=== PAUSE TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_add
=== RUN   TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_remove
=== PAUSE TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_remove
=== RUN   TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_update
=== PAUSE TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_update
=== RUN   TestAccRDSCluster_GlobalClusterIdentifierEngineMode_provisioned
=== PAUSE TestAccRDSCluster_GlobalClusterIdentifierEngineMode_provisioned
=== RUN   TestAccRDSCluster_GlobalClusterIdentifier_primarySecondaryClusters
=== PAUSE TestAccRDSCluster_GlobalClusterIdentifier_primarySecondaryClusters
=== RUN   TestAccRDSCluster_GlobalClusterIdentifier_replicationSourceIdentifier
=== PAUSE TestAccRDSCluster_GlobalClusterIdentifier_replicationSourceIdentifier
=== RUN   TestAccRDSCluster_GlobalClusterIdentifier_secondaryClustersWriteForwarding
=== PAUSE TestAccRDSCluster_GlobalClusterIdentifier_secondaryClustersWriteForwarding
=== RUN   TestAccRDSCluster_port
=== PAUSE TestAccRDSCluster_port
=== RUN   TestAccRDSCluster_scaling
=== PAUSE TestAccRDSCluster_scaling
=== RUN   TestAccRDSCluster_serverlessV2ScalingConfiguration
=== PAUSE TestAccRDSCluster_serverlessV2ScalingConfiguration
=== RUN   TestAccRDSCluster_Scaling_defaultMinCapacity
=== PAUSE TestAccRDSCluster_Scaling_defaultMinCapacity
=== RUN   TestAccRDSCluster_snapshotIdentifier
=== PAUSE TestAccRDSCluster_snapshotIdentifier
=== RUN   TestAccRDSCluster_SnapshotIdentifier_deletionProtection
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_deletionProtection
=== RUN   TestAccRDSCluster_SnapshotIdentifierEngineMode_parallelQuery
=== PAUSE TestAccRDSCluster_SnapshotIdentifierEngineMode_parallelQuery
=== RUN   TestAccRDSCluster_SnapshotIdentifierEngineMode_provisioned
=== PAUSE TestAccRDSCluster_SnapshotIdentifierEngineMode_provisioned
=== RUN   TestAccRDSCluster_SnapshotIdentifierEngineMode_serverless
    cluster_test.go:1690: serverless does not support snapshot restore on an empty volume
--- SKIP: TestAccRDSCluster_SnapshotIdentifierEngineMode_serverless (0.00s)
=== RUN   TestAccRDSCluster_SnapshotIdentifierEngineVersion_different
=== PAUSE TestAccRDSCluster_SnapshotIdentifierEngineVersion_different
=== RUN   TestAccRDSCluster_SnapshotIdentifierEngineVersion_equal
=== PAUSE TestAccRDSCluster_SnapshotIdentifierEngineVersion_equal
=== RUN   TestAccRDSCluster_SnapshotIdentifier_kmsKeyID
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_kmsKeyID
=== RUN   TestAccRDSCluster_SnapshotIdentifier_masterPassword
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_masterPassword
=== RUN   TestAccRDSCluster_SnapshotIdentifier_masterUsername
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_masterUsername
=== RUN   TestAccRDSCluster_SnapshotIdentifier_preferredBackupWindow
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_preferredBackupWindow
=== RUN   TestAccRDSCluster_SnapshotIdentifier_preferredMaintenanceWindow
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_preferredMaintenanceWindow
=== RUN   TestAccRDSCluster_SnapshotIdentifier_tags
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_tags
=== RUN   TestAccRDSCluster_SnapshotIdentifier_vpcSecurityGroupIDs
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_vpcSecurityGroupIDs
=== RUN   TestAccRDSCluster_SnapshotIdentifierVPCSecurityGroupIDs_tags
=== PAUSE TestAccRDSCluster_SnapshotIdentifierVPCSecurityGroupIDs_tags
=== RUN   TestAccRDSCluster_SnapshotIdentifier_encryptedRestore
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_encryptedRestore
=== RUN   TestAccRDSCluster_enableHTTPEndpoint
=== PAUSE TestAccRDSCluster_enableHTTPEndpoint
=== CONT  TestAccRDSCluster_basic
=== CONT  TestAccRDSCluster_EngineMode_multiMaster
=== CONT  TestAccRDSCluster_snapshotIdentifier
--- PASS: TestAccRDSCluster_EngineMode_multiMaster (115.36s)
=== CONT  TestAccRDSCluster_PointInTimeRestore_enabledCloudWatchLogsExports
--- PASS: TestAccRDSCluster_basic (130.29s)
=== CONT  TestAccRDSCluster_EngineMode_global
--- PASS: TestAccRDSCluster_EngineMode_global (116.80s)
=== CONT  TestAccRDSCluster_engineMode
--- PASS: TestAccRDSCluster_snapshotIdentifier (348.75s)
=== CONT  TestAccRDSCluster_deletionProtection
--- PASS: TestAccRDSCluster_PointInTimeRestore_enabledCloudWatchLogsExports (341.83s)
=== CONT  TestAccRDSCluster_iamAuth
--- PASS: TestAccRDSCluster_deletionProtection (190.48s)
=== CONT  TestAccRDSCluster_backupsUpdate
--- PASS: TestAccRDSCluster_iamAuth (158.37s)
=== CONT  TestAccRDSCluster_updateIAMRoles
--- PASS: TestAccRDSCluster_engineMode (394.55s)
=== CONT  TestAccRDSCluster_EnabledCloudWatchLogsExports_postgresql
--- PASS: TestAccRDSCluster_backupsUpdate (159.72s)
=== CONT  TestAccRDSCluster_EnabledCloudWatchLogsExports_mySQL
--- PASS: TestAccRDSCluster_updateIAMRoles (178.73s)
=== CONT  TestAccRDSCluster_missingUserNameCausesError
--- PASS: TestAccRDSCluster_EnabledCloudWatchLogsExports_postgresql (161.54s)
=== CONT  TestAccRDSCluster_takeFinalSnapshot
--- PASS: TestAccRDSCluster_missingUserNameCausesError (9.36s)
=== CONT  TestAccRDSCluster_kmsKey
--- PASS: TestAccRDSCluster_kmsKey (121.13s)
=== CONT  TestAccRDSCluster_ReplicationSourceIdentifier_kmsKeyID
--- PASS: TestAccRDSCluster_EnabledCloudWatchLogsExports_mySQL (242.01s)
=== CONT  TestAccRDSCluster_copyTagsToSnapshot
--- PASS: TestAccRDSCluster_takeFinalSnapshot (191.29s)
=== CONT  TestAccRDSCluster_encrypted
--- PASS: TestAccRDSCluster_encrypted (138.87s)
=== CONT  TestAccRDSCluster_networkType
--- PASS: TestAccRDSCluster_copyTagsToSnapshot (240.79s)
=== CONT  TestAccRDSCluster_GlobalClusterIdentifierEngineMode_provisioned
--- PASS: TestAccRDSCluster_GlobalClusterIdentifierEngineMode_provisioned (135.85s)
=== CONT  TestAccRDSCluster_Scaling_defaultMinCapacity
--- PASS: TestAccRDSCluster_networkType (197.89s)
=== CONT  TestAccRDSCluster_serverlessV2ScalingConfiguration
--- PASS: TestAccRDSCluster_serverlessV2ScalingConfiguration (185.72s)
=== CONT  TestAccRDSCluster_availabilityZones
--- PASS: TestAccRDSCluster_Scaling_defaultMinCapacity (281.34s)
=== CONT  TestAccRDSCluster_scaling
--- PASS: TestAccRDSCluster_availabilityZones (118.19s)
=== CONT  TestAccRDSCluster_pointInTimeRestore
--- PASS: TestAccRDSCluster_scaling (314.06s)
=== CONT  TestAccRDSCluster_port
--- PASS: TestAccRDSCluster_pointInTimeRestore (320.31s)
=== CONT  TestAccRDSCluster_dbSubnetGroupName
--- PASS: TestAccRDSCluster_port (163.76s)
=== CONT  TestAccRDSCluster_GlobalClusterIdentifier_secondaryClustersWriteForwarding
--- PASS: TestAccRDSCluster_dbSubnetGroupName (135.89s)
=== CONT  TestAccRDSCluster_backtrackWindow
--- PASS: TestAccRDSCluster_backtrackWindow (201.53s)
=== CONT  TestAccRDSCluster_dbClusterInstanceClass
--- PASS: TestAccRDSCluster_ReplicationSourceIdentifier_kmsKeyID (1540.76s)
=== CONT  TestAccRDSCluster_iops
--- PASS: TestAccRDSCluster_dbClusterInstanceClass (1210.70s)
=== CONT  TestAccRDSCluster_allocatedStorage
--- PASS: TestAccRDSCluster_iops (1212.85s)
=== CONT  TestAccRDSCluster_GlobalClusterIdentifier_replicationSourceIdentifier
--- PASS: TestAccRDSCluster_GlobalClusterIdentifier_secondaryClustersWriteForwarding (2045.04s)
=== CONT  TestAccRDSCluster_storageType
--- PASS: TestAccRDSCluster_allocatedStorage (1231.87s)
=== CONT  TestAccRDSCluster_GlobalClusterIdentifierEngineMode_global
--- PASS: TestAccRDSCluster_GlobalClusterIdentifierEngineMode_global (182.10s)
=== CONT  TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_update
--- PASS: TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_update (137.16s)
=== CONT  TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_remove
--- PASS: TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_remove (165.74s)
=== CONT  TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_add
--- PASS: TestAccRDSCluster_storageType (1179.38s)
=== CONT  TestAccRDSCluster_engineVersion
--- PASS: TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_add (114.64s)
=== CONT  TestAccRDSCluster_EngineMode_parallelQuery
--- PASS: TestAccRDSCluster_GlobalClusterIdentifier_replicationSourceIdentifier (1678.33s)
=== CONT  TestAccRDSCluster_SnapshotIdentifier_masterUsername
--- PASS: TestAccRDSCluster_EngineMode_parallelQuery (147.88s)
=== CONT  TestAccRDSCluster_enableHTTPEndpoint
--- PASS: TestAccRDSCluster_SnapshotIdentifier_masterUsername (347.47s)
=== CONT  TestAccRDSCluster_SnapshotIdentifier_encryptedRestore
--- PASS: TestAccRDSCluster_engineVersion (457.38s)
=== CONT  TestAccRDSCluster_SnapshotIdentifierVPCSecurityGroupIDs_tags
--- PASS: TestAccRDSCluster_enableHTTPEndpoint (314.62s)
=== CONT  TestAccRDSCluster_engineVersionWithPrimaryInstance
--- PASS: TestAccRDSCluster_SnapshotIdentifier_encryptedRestore (413.10s)
=== CONT  TestAccRDSCluster_allowMajorVersionUpgrade
--- PASS: TestAccRDSCluster_SnapshotIdentifierVPCSecurityGroupIDs_tags (476.49s)
=== CONT  TestAccRDSCluster_onlyMajorVersion
--- PASS: TestAccRDSCluster_engineVersionWithPrimaryInstance (1013.42s)
=== CONT  TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParameters
--- PASS: TestAccRDSCluster_onlyMajorVersion (755.71s)
=== CONT  TestAccRDSCluster_SnapshotIdentifier_vpcSecurityGroupIDs
--- PASS: TestAccRDSCluster_SnapshotIdentifier_vpcSecurityGroupIDs (367.10s)
=== CONT  TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParametersApplyImm
--- PASS: TestAccRDSCluster_allowMajorVersionUpgrade (1651.15s)
=== CONT  TestAccRDSCluster_SnapshotIdentifier_tags
--- PASS: TestAccRDSCluster_SnapshotIdentifier_tags (440.06s)
=== CONT  TestAccRDSCluster_SnapshotIdentifier_preferredMaintenanceWindow
--- PASS: TestAccRDSCluster_SnapshotIdentifier_preferredMaintenanceWindow (380.45s)
=== CONT  TestAccRDSCluster_GlobalClusterIdentifier_primarySecondaryClusters
--- PASS: TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParameters (1991.52s)
=== CONT  TestAccRDSCluster_SnapshotIdentifier_preferredBackupWindow
--- PASS: TestAccRDSCluster_SnapshotIdentifier_preferredBackupWindow (378.46s)
=== CONT  TestAccRDSCluster_SnapshotIdentifierEngineVersion_different
--- PASS: TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParametersApplyImm (1886.40s)
=== CONT  TestAccRDSCluster_SnapshotIdentifierEngineMode_parallelQuery
--- PASS: TestAccRDSCluster_SnapshotIdentifierEngineVersion_different (329.73s)
=== CONT  TestAccRDSCluster_SnapshotIdentifier_masterPassword
--- PASS: TestAccRDSCluster_SnapshotIdentifierEngineMode_parallelQuery (409.18s)
=== CONT  TestAccRDSCluster_SnapshotIdentifier_kmsKeyID
--- PASS: TestAccRDSCluster_SnapshotIdentifier_masterPassword (357.72s)
=== CONT  TestAccRDSCluster_SnapshotIdentifierEngineVersion_equal
--- PASS: TestAccRDSCluster_SnapshotIdentifier_kmsKeyID (358.95s)
=== CONT  TestAccRDSCluster_SnapshotIdentifier_deletionProtection
--- PASS: TestAccRDSCluster_SnapshotIdentifierEngineVersion_equal (388.33s)
=== CONT  TestAccRDSCluster_identifierPrefix
--- PASS: TestAccRDSCluster_SnapshotIdentifier_deletionProtection (397.30s)
=== CONT  TestAccRDSCluster_identifierGenerated
--- PASS: TestAccRDSCluster_identifierPrefix (169.66s)
=== CONT  TestAccRDSCluster_disappears
--- PASS: TestAccRDSCluster_GlobalClusterIdentifier_primarySecondaryClusters (1909.34s)
=== CONT  TestAccRDSCluster_SnapshotIdentifierEngineMode_provisioned
--- PASS: TestAccRDSCluster_identifierGenerated (158.56s)
=== CONT  TestAccRDSCluster_tags
--- PASS: TestAccRDSCluster_disappears (155.73s)
--- PASS: TestAccRDSCluster_tags (145.14s)
--- PASS: TestAccRDSCluster_SnapshotIdentifierEngineMode_provisioned (369.20s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	10871.412s

@ewbankkit
Copy link
Contributor

@bschaatsbergen Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 45ac9ea into hashicorp:main Sep 7, 2022
@github-actions github-actions bot added this to the v4.30.0 milestone Sep 7, 2022
@github-actions
Copy link

github-actions bot commented Sep 9, 2022

This functionality has been released in v4.30.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@gonrial gonrial mentioned this pull request Sep 12, 2022
Closed
@github-actions
Copy link

github-actions bot commented Oct 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.30.0
Development

Successfully merging this pull request may close these issues.

Amazon Aurora supports IPv6
3 participants
@bschaatsbergen @ewbankkit @justinretzolk