-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws_cognito_user_pool is missing arn attribute #2657
Comments
Arn doesn't seem like a native attribute from go-sdk and aws api. |
Hi all! We generally prefer it when the underlying API produces an ARN for us which we can just return, but there have been a few cases already where the ARN format has existed only in documentation but yet a full ARN is required for some other API, so there is precedent for Terraform resource code to produce synthetic I'm not personally familiar with Cognito enough to know what ARN format is expected, but if there's a well-documented ARN format in the docs somewhere then some logic to construct a string consistent with that format would be welcomed. The Terraform team at HashiCorp won't be able to work on this in the near future due to our focus being elsewhere, but we'd be happy to review a pull request if you or someone else has the time and motivation to implement it. Alternatively, if others would also like to see this implemented I'd encourage adding a 👍 upvote reaction to the original issue comment (not to this comment), which we use as one of the inputs to prioritize work for the Terraform team. |
@apparentlymart FYI this AWS documentation has most of the available ARN formats, here specifically is Cognito user pools: http://docs.aws.amazon.com/general/latest/gr/aws-arns-and-namespaces.html#arn-syntax-aws-cognito-idp
I can submit a quick PR to synthesize this in the resource for now. |
PR submitted: #2723 |
@serialseb Out of curiosity why do you think that the user pool apps/clients need the ARN of the user pool? Looking at the docs it needs the user pool id and the client name only as required fields. I'm currently working on adding a Terraform resource for user pool app clients right now so this request surprises me a little. |
From memory, apply when creating the domain was failing if passed the id, although this is using a null_resource with the aws cli. |
This has been released in terraform-provider-aws version 1.7.0. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Terraform Version
Affected Resource(s)
Expected Behavior
Creating a user pool using a cloudformation stack returns the id and the arn for the resource, which is needed for creating user pool clients. That arn is not exposed on the resource.
Workaround
I can rebuild the arn manually using the following snippet.
The text was updated successfully, but these errors were encountered: