Bugfix: AppFlow: Ignore empty tasks

[camro]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #25095

Output from acceptance testing:

$ make testacc TESTS=TestAccXXX PKG=ec2

...

[didiqaz122]

good

[camro]

Bump

[camro]

Bump

[johnsonaj]

LGTM 🚀

$ make testacc TESTARGS='-run=TestAccAppFlowFlow_' PKG=appflow

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appflow/... -v -count 1 -parallel 20  -run=TestAccAppFlowFlow_ -timeout 180m
--- PASS: TestAccAppFlowFlow_disappears (28.70s)
--- PASS: TestAccAppFlowFlow_TaskProperties (29.96s)
--- PASS: TestAccAppFlowFlow_basic (32.38s)
--- PASS: TestAccAppFlowFlow_update (47.04s)
--- PASS: TestAccAppFlowFlow_S3_outputFormatConfig_ParquetFileType (47.31s)
--- PASS: TestAccAppFlowFlow_tags (66.03s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appflow	69.406s

[johnsonaj]

Thank you for the contribution! 🎉

[github-actions]

This functionality has been released in v5.9.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[vgw-chriskruger]

I tried this fix out in 5.9.0 yesterday. Has it been tested? It didn't seem to work for me.

Update: Looking at the fix (I am not really familiar with go) I don't really understand why it would work? It looks like it is doing pointer comparison when we want structural comparison to compare to its zero value composite literal. This change is unlikely to ever break anything, but I don't see how it works as we want? Happy to be educated if I am wrong.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.