Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F aws eks addon add timeouts #26629

Merged
merged 3 commits into from Sep 6, 2022
Merged

F aws eks addon add timeouts #26629

merged 3 commits into from Sep 6, 2022

Conversation

timothyjrogers
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #26474

Output from acceptance testing:

I did not exercise acceptance tests on this change because the related aws_eks_cluster does not exercise Timeout settings in its acceptance tests.

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/eks Issues and PRs that pertain to the eks service. labels Sep 2, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @timothyjrogers 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Sep 6, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccEKSAddon_basic\|TestAccEKSAddon_preserve' PKG=eks ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/eks/... -v -count 1 -parallel 2  -run=TestAccEKSAddon_basic\|TestAccEKSAddon_preserve -timeout 180m
=== RUN   TestAccEKSAddon_basic
=== PAUSE TestAccEKSAddon_basic
=== RUN   TestAccEKSAddon_preserve
=== PAUSE TestAccEKSAddon_preserve
=== CONT  TestAccEKSAddon_basic
=== CONT  TestAccEKSAddon_preserve
--- PASS: TestAccEKSAddon_basic (791.19s)
--- PASS: TestAccEKSAddon_preserve (874.38s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/eks	1737.233s

@ewbankkit
Copy link
Contributor

@timothyjrogers Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 993770a into hashicorp:main Sep 6, 2022
@github-actions github-actions bot added this to the v4.30.0 milestone Sep 6, 2022
@github-actions
Copy link

github-actions bot commented Sep 9, 2022

This functionality has been released in v4.30.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Oct 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/eks Issues and PRs that pertain to the eks service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants