resource/aws_instance: Handle regions where instance metadata tags are unsupported #26631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
service/ec2
ewbankkit
approved these changes
Sep 6, 2022
There was a problem hiding this comment.
LGTM 🚀.
% AWS_REGION=me-central-1 make testacc PKG=ec2 TESTS=TestAccEC2Instance_metadataOptions
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2Instance_metadataOptions' -timeout 180m
=== RUN TestAccEC2Instance_metadataOptions
=== PAUSE TestAccEC2Instance_metadataOptions
=== CONT TestAccEC2Instance_metadataOptions
ec2_instance_test.go:4389: Step 1/4 error: Check failed: 1 error occurred:
* Check 6/6 error: aws_instance.test: Attribute 'metadata_options.0.instance_metadata_tags' expected "disabled", got ""
--- FAIL: TestAccEC2Instance_metadataOptions (330.28s)
FAIL
FAIL github.com/hashicorp/terraform-provider-aws/internal/service/ec2 335.603s
FAIL
make: *** [testacc] Error 1
% make testacc PKG=ec2 TESTS=TestAccEC2Instance_metadataOptions
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2Instance_metadataOptions' -timeout 180m
=== RUN TestAccEC2Instance_metadataOptions
=== PAUSE TestAccEC2Instance_metadataOptions
=== CONT TestAccEC2Instance_metadataOptions
--- PASS: TestAccEC2Instance_metadataOptions (182.12s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 186.002s
|
This functionality has been released in v4.30.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some AWS regions, such as
me-central-1do not currently support Instance Metadata Tags. The default value supplied by the provider was causing the provider to fail in some cases.Closes #26561
Output from acceptance testing:
Previously:
Now (changing expected
instance_metadata_tagsto"")Relates #25227.
Relates #25778.