Bugfix: Use DescribeManagedPrefixListsPagesWithContext to get prefix list #26683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces DescribeManagedPrefixListsWithContext
github-actions
bot
added
size/XS
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome @aleksanderaleksic 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
ewbankkit
removed
the
needs-triage
… handler signatures (hashicorp#15090). Acceptance test output: % make testacc TESTARGS='-run=TestAccVPCManagedPrefixListEntry_' PKG=ec2 ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2 -run=TestAccVPCManagedPrefixListEntry_ -timeout 180m === RUN TestAccVPCManagedPrefixListEntry_ipv4 === PAUSE TestAccVPCManagedPrefixListEntry_ipv4 === RUN TestAccVPCManagedPrefixListEntry_ipv4Multiple === PAUSE TestAccVPCManagedPrefixListEntry_ipv4Multiple === RUN TestAccVPCManagedPrefixListEntry_ipv6 === PAUSE TestAccVPCManagedPrefixListEntry_ipv6 === RUN TestAccVPCManagedPrefixListEntry_expectInvalidTypeError === PAUSE TestAccVPCManagedPrefixListEntry_expectInvalidTypeError === RUN TestAccVPCManagedPrefixListEntry_expectInvalidCIDR === PAUSE TestAccVPCManagedPrefixListEntry_expectInvalidCIDR === RUN TestAccVPCManagedPrefixListEntry_description === PAUSE TestAccVPCManagedPrefixListEntry_description === RUN TestAccVPCManagedPrefixListEntry_disappears === PAUSE TestAccVPCManagedPrefixListEntry_disappears === CONT TestAccVPCManagedPrefixListEntry_ipv4 === CONT TestAccVPCManagedPrefixListEntry_expectInvalidCIDR --- PASS: TestAccVPCManagedPrefixListEntry_expectInvalidCIDR (2.75s) === CONT TestAccVPCManagedPrefixListEntry_disappears --- PASS: TestAccVPCManagedPrefixListEntry_disappears (24.30s) === CONT TestAccVPCManagedPrefixListEntry_description --- PASS: TestAccVPCManagedPrefixListEntry_ipv4 (28.17s) === CONT TestAccVPCManagedPrefixListEntry_ipv6 --- PASS: TestAccVPCManagedPrefixListEntry_description (28.06s) === CONT TestAccVPCManagedPrefixListEntry_expectInvalidTypeError --- PASS: TestAccVPCManagedPrefixListEntry_ipv6 (27.37s) === CONT TestAccVPCManagedPrefixListEntry_ipv4Multiple --- PASS: TestAccVPCManagedPrefixListEntry_expectInvalidTypeError (1.45s) --- PASS: TestAccVPCManagedPrefixListEntry_ipv4Multiple (31.93s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 92.312s
…yGroupRuleIdNotFound'.
…urceID' and 'ManagedPrefixListEntryParseID' -> 'ManagedPrefixListEntryParseResourceID'.
…er signatures (hashicorp#15090). Acceptance test output: % make testacc TESTARGS='-run=TestAccVPCManagedPrefixList_' PKG=ec2 ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2 -run=TestAccVPCManagedPrefixList_ -timeout 180m === RUN TestAccVPCManagedPrefixList_basic === PAUSE TestAccVPCManagedPrefixList_basic === RUN TestAccVPCManagedPrefixList_disappears === PAUSE TestAccVPCManagedPrefixList_disappears === RUN TestAccVPCManagedPrefixList_AddressFamily_ipv6 === PAUSE TestAccVPCManagedPrefixList_AddressFamily_ipv6 === RUN TestAccVPCManagedPrefixList_Entry_cidr === PAUSE TestAccVPCManagedPrefixList_Entry_cidr === RUN TestAccVPCManagedPrefixList_Entry_description === PAUSE TestAccVPCManagedPrefixList_Entry_description === RUN TestAccVPCManagedPrefixList_name === PAUSE TestAccVPCManagedPrefixList_name === RUN TestAccVPCManagedPrefixList_tags === PAUSE TestAccVPCManagedPrefixList_tags === CONT TestAccVPCManagedPrefixList_basic === CONT TestAccVPCManagedPrefixList_Entry_description --- PASS: TestAccVPCManagedPrefixList_Entry_description (38.14s) === CONT TestAccVPCManagedPrefixList_AddressFamily_ipv6 --- PASS: TestAccVPCManagedPrefixList_basic (44.13s) === CONT TestAccVPCManagedPrefixList_Entry_cidr --- PASS: TestAccVPCManagedPrefixList_AddressFamily_ipv6 (25.14s) === CONT TestAccVPCManagedPrefixList_tags --- PASS: TestAccVPCManagedPrefixList_Entry_cidr (39.83s) === CONT TestAccVPCManagedPrefixList_disappears === CONT TestAccVPCManagedPrefixList_name --- PASS: TestAccVPCManagedPrefixList_disappears (20.94s) --- PASS: TestAccVPCManagedPrefixList_tags (48.23s) --- PASS: TestAccVPCManagedPrefixList_name (37.63s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 146.639s
Acceptance test output: % make testacc TESTARGS='-run=TestAccVPCManagedPrefixListDataSource_' PKG=ec2 ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2 -run=TestAccVPCManagedPrefixListDataSource_ -timeout 180m === RUN TestAccVPCManagedPrefixListDataSource_basic === PAUSE TestAccVPCManagedPrefixListDataSource_basic === RUN TestAccVPCManagedPrefixListDataSource_filter === PAUSE TestAccVPCManagedPrefixListDataSource_filter === RUN TestAccVPCManagedPrefixListDataSource_matchesTooMany === PAUSE TestAccVPCManagedPrefixListDataSource_matchesTooMany === CONT TestAccVPCManagedPrefixListDataSource_basic === CONT TestAccVPCManagedPrefixListDataSource_matchesTooMany --- PASS: TestAccVPCManagedPrefixListDataSource_matchesTooMany (3.48s) === CONT TestAccVPCManagedPrefixListDataSource_filter --- PASS: TestAccVPCManagedPrefixListDataSource_basic (16.70s) --- PASS: TestAccVPCManagedPrefixListDataSource_filter (14.58s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 22.291s
github-actions
bot
added
tests
ewbankkit
approved these changes
Sep 7, 2022
There was a problem hiding this comment.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccVPCManagedPrefixListDataSource_' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2 -run=TestAccVPCManagedPrefixListDataSource_ -timeout 180m
=== RUN TestAccVPCManagedPrefixListDataSource_basic
=== PAUSE TestAccVPCManagedPrefixListDataSource_basic
=== RUN TestAccVPCManagedPrefixListDataSource_filter
=== PAUSE TestAccVPCManagedPrefixListDataSource_filter
=== RUN TestAccVPCManagedPrefixListDataSource_matchesTooMany
=== PAUSE TestAccVPCManagedPrefixListDataSource_matchesTooMany
=== CONT TestAccVPCManagedPrefixListDataSource_basic
=== CONT TestAccVPCManagedPrefixListDataSource_matchesTooMany
--- PASS: TestAccVPCManagedPrefixListDataSource_matchesTooMany (3.48s)
=== CONT TestAccVPCManagedPrefixListDataSource_filter
--- PASS: TestAccVPCManagedPrefixListDataSource_basic (16.70s)
--- PASS: TestAccVPCManagedPrefixListDataSource_filter (14.58s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 22.291s
|
@aleksanderaleksic Thanks for the contribution 🎉 👏. |
|
This functionality has been released in v4.30.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Closes #26004
Output from acceptance testing: