Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry to resourceReplicationSubnetGroupCreate #26768

Merged
merged 2 commits into from Sep 12, 2022

Conversation

zhelding
Copy link
Contributor

@zhelding zhelding commented Sep 12, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #11025.

Acceptance test passing:

❯ make testacc TESTS=TestAccDMSReplicationSubnetGroup PKG=dms           
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 20 -run='TestAccDMSReplicationSubnetGroup'  -timeout 180m
=== RUN   TestAccDMSReplicationSubnetGroup_basic
=== PAUSE TestAccDMSReplicationSubnetGroup_basic
=== CONT  TestAccDMSReplicationSubnetGroup_basic
--- PASS: TestAccDMSReplicationSubnetGroup_basic (33.70s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dms        33.744s

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/dms Issues and PRs that pertain to the dms service. labels Sep 12, 2022
@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Sep 12, 2022
@zhelding zhelding merged commit 96a533f into main Sep 12, 2022
@zhelding zhelding deleted the b-dms-subnet-group-retry branch September 12, 2022 21:24
@github-actions github-actions bot added this to the v4.31.0 milestone Sep 12, 2022
github-actions bot pushed a commit that referenced this pull request Sep 12, 2022
@github-actions
Copy link

This functionality has been released in v4.31.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/dms Issues and PRs that pertain to the dms service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dms-vpc-role is not configured properly when creating aws_dms_replication_instance
1 participant