Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression issue: Allow SSM parameter overwrite upon creation #26785

Merged
merged 8 commits into from Sep 27, 2022
Merged

Regression issue: Allow SSM parameter overwrite upon creation #26785

merged 8 commits into from Sep 27, 2022

Conversation

bschaatsbergen
Copy link
Member

@bschaatsbergen bschaatsbergen commented Sep 13, 2022 •
edited

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #25335

Regression bug

This issue was flagged after releasing v4.18.0 through #25335
I've reverted the commit.

Output from acceptance testing:

make testacc TESTS=TestAccSSMParameter_ PKG=ssm
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ssm/... -v -count 1 -parallel 20 -run='TestAccSSMParameter_'  -timeout 180m
=== RUN   TestAccSSMParameter_basic
=== PAUSE TestAccSSMParameter_basic
=== RUN   TestAccSSMParameter_tier
=== PAUSE TestAccSSMParameter_tier
=== RUN   TestAccSSMParameter_Tier_intelligentTieringToStandard
=== PAUSE TestAccSSMParameter_Tier_intelligentTieringToStandard
=== RUN   TestAccSSMParameter_Tier_intelligentTieringToAdvanced
=== PAUSE TestAccSSMParameter_Tier_intelligentTieringToAdvanced
=== RUN   TestAccSSMParameter_Tier_intelligentTieringOnCreation
=== PAUSE TestAccSSMParameter_Tier_intelligentTieringOnCreation
=== RUN   TestAccSSMParameter_Tier_intelligentTieringOnUpdate
=== PAUSE TestAccSSMParameter_Tier_intelligentTieringOnUpdate
=== RUN   TestAccSSMParameter_disappears
=== PAUSE TestAccSSMParameter_disappears
=== RUN   TestAccSSMParameter_Overwrite_basic
=== PAUSE TestAccSSMParameter_Overwrite_basic
=== RUN   TestAccSSMParameter_Overwrite_cascade
=== PAUSE TestAccSSMParameter_Overwrite_cascade
=== RUN   TestAccSSMParameter_Overwrite_tags
=== PAUSE TestAccSSMParameter_Overwrite_tags
=== RUN   TestAccSSMParameter_Overwrite_noOverwriteTags
=== PAUSE TestAccSSMParameter_Overwrite_noOverwriteTags
=== RUN   TestAccSSMParameter_Overwrite_updateToTags
=== PAUSE TestAccSSMParameter_Overwrite_updateToTags
=== RUN   TestAccSSMParameter_tags
=== PAUSE TestAccSSMParameter_tags
=== RUN   TestAccSSMParameter_updateType
=== PAUSE TestAccSSMParameter_updateType
=== RUN   TestAccSSMParameter_Overwrite_updateDescription
=== PAUSE TestAccSSMParameter_Overwrite_updateDescription
=== RUN   TestAccSSMParameter_changeNameForcesNew
=== PAUSE TestAccSSMParameter_changeNameForcesNew
=== RUN   TestAccSSMParameter_fullPath
=== PAUSE TestAccSSMParameter_fullPath
=== RUN   TestAccSSMParameter_Secure_basic
=== PAUSE TestAccSSMParameter_Secure_basic
=== RUN   TestAccSSMParameter_Secure_insecure
=== PAUSE TestAccSSMParameter_Secure_insecure
=== RUN   TestAccSSMParameter_Secure_insecureChangeSecure
=== PAUSE TestAccSSMParameter_Secure_insecureChangeSecure
=== RUN   TestAccSSMParameter_DataType_ec2Image
=== PAUSE TestAccSSMParameter_DataType_ec2Image
=== RUN   TestAccSSMParameter_Secure_key
=== PAUSE TestAccSSMParameter_Secure_key
=== RUN   TestAccSSMParameter_Secure_keyUpdate
=== PAUSE TestAccSSMParameter_Secure_keyUpdate
=== CONT  TestAccSSMParameter_basic
=== CONT  TestAccSSMParameter_Secure_key
=== CONT  TestAccSSMParameter_Overwrite_updateToTags
=== CONT  TestAccSSMParameter_DataType_ec2Image
=== CONT  TestAccSSMParameter_Secure_insecureChangeSecure
=== CONT  TestAccSSMParameter_Secure_insecure
=== CONT  TestAccSSMParameter_Secure_basic
=== CONT  TestAccSSMParameter_fullPath
=== CONT  TestAccSSMParameter_changeNameForcesNew
=== CONT  TestAccSSMParameter_Overwrite_updateDescription
=== CONT  TestAccSSMParameter_updateType
=== CONT  TestAccSSMParameter_tags
=== CONT  TestAccSSMParameter_Tier_intelligentTieringToAdvanced
=== CONT  TestAccSSMParameter_Tier_intelligentTieringOnUpdate
=== CONT  TestAccSSMParameter_disappears
=== CONT  TestAccSSMParameter_Overwrite_noOverwriteTags
=== CONT  TestAccSSMParameter_Tier_intelligentTieringOnCreation
=== CONT  TestAccSSMParameter_Overwrite_tags
=== CONT  TestAccSSMParameter_Overwrite_cascade
=== CONT  TestAccSSMParameter_Secure_keyUpdate
--- PASS: TestAccSSMParameter_disappears (25.36s)
=== CONT  TestAccSSMParameter_Overwrite_basic
--- PASS: TestAccSSMParameter_Tier_intelligentTieringOnCreation (31.98s)
=== CONT  TestAccSSMParameter_tier
--- PASS: TestAccSSMParameter_fullPath (34.79s)
=== CONT  TestAccSSMParameter_Tier_intelligentTieringToStandard
--- PASS: TestAccSSMParameter_Overwrite_noOverwriteTags (34.97s)
--- PASS: TestAccSSMParameter_basic (35.38s)
--- PASS: TestAccSSMParameter_Secure_basic (35.51s)
--- PASS: TestAccSSMParameter_Overwrite_tags (35.63s)
--- PASS: TestAccSSMParameter_DataType_ec2Image (39.17s)
--- PASS: TestAccSSMParameter_Secure_key (39.74s)
--- PASS: TestAccSSMParameter_Tier_intelligentTieringOnUpdate (49.40s)
--- PASS: TestAccSSMParameter_Overwrite_updateToTags (51.72s)
--- PASS: TestAccSSMParameter_Overwrite_updateDescription (52.74s)
--- PASS: TestAccSSMParameter_changeNameForcesNew (55.19s)
--- PASS: TestAccSSMParameter_updateType (55.39s)
--- PASS: TestAccSSMParameter_Secure_keyUpdate (59.04s)
--- PASS: TestAccSSMParameter_Secure_insecureChangeSecure (65.56s)
--- PASS: TestAccSSMParameter_Overwrite_cascade (66.96s)
--- PASS: TestAccSSMParameter_tags (70.65s)
--- PASS: TestAccSSMParameter_Secure_insecure (70.85s)
--- PASS: TestAccSSMParameter_Overwrite_basic (45.86s)
--- PASS: TestAccSSMParameter_Tier_intelligentTieringToAdvanced (75.03s)
--- PASS: TestAccSSMParameter_Tier_intelligentTieringToStandard (60.98s)
--- PASS: TestAccSSMParameter_tier (63.99s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ssm        96.063s

@github-actions github-actions bot added service/ssm Issues and PRs that pertain to the ssm service. needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. labels Sep 13, 2022
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 13, 2022
@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed size/XS Managed by automation to categorize the size of a PR. labels Sep 13, 2022
@bschaatsbergen bschaatsbergen changed the title Regression issue: Allow SSM parameter overwrite in combination with CreateParameter Regression issue: Allow SSM parameter overwrite upon creation Sep 13, 2022
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Sep 13, 2022
ewbankkit
ewbankkit approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSSMParameter_' PKG=ssm ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ssm/... -v -count 1 -parallel 2  -run=TestAccSSMParameter_ -timeout 180m
=== RUN   TestAccSSMParameter_basic
=== PAUSE TestAccSSMParameter_basic
=== RUN   TestAccSSMParameter_tier
=== PAUSE TestAccSSMParameter_tier
=== RUN   TestAccSSMParameter_Tier_intelligentTieringToStandard
=== PAUSE TestAccSSMParameter_Tier_intelligentTieringToStandard
=== RUN   TestAccSSMParameter_Tier_intelligentTieringToAdvanced
=== PAUSE TestAccSSMParameter_Tier_intelligentTieringToAdvanced
=== RUN   TestAccSSMParameter_Tier_intelligentTieringOnCreation
=== PAUSE TestAccSSMParameter_Tier_intelligentTieringOnCreation
=== RUN   TestAccSSMParameter_Tier_intelligentTieringOnUpdate
=== PAUSE TestAccSSMParameter_Tier_intelligentTieringOnUpdate
=== RUN   TestAccSSMParameter_disappears
=== PAUSE TestAccSSMParameter_disappears
=== RUN   TestAccSSMParameter_Overwrite_basic
=== PAUSE TestAccSSMParameter_Overwrite_basic
=== RUN   TestAccSSMParameter_Overwrite_cascade
=== PAUSE TestAccSSMParameter_Overwrite_cascade
=== RUN   TestAccSSMParameter_Overwrite_tags
=== PAUSE TestAccSSMParameter_Overwrite_tags
=== RUN   TestAccSSMParameter_Overwrite_noOverwriteTags
=== PAUSE TestAccSSMParameter_Overwrite_noOverwriteTags
=== RUN   TestAccSSMParameter_Overwrite_updateToTags
=== PAUSE TestAccSSMParameter_Overwrite_updateToTags
=== RUN   TestAccSSMParameter_tags
=== PAUSE TestAccSSMParameter_tags
=== RUN   TestAccSSMParameter_updateType
=== PAUSE TestAccSSMParameter_updateType
=== RUN   TestAccSSMParameter_Overwrite_updateDescription
=== PAUSE TestAccSSMParameter_Overwrite_updateDescription
=== RUN   TestAccSSMParameter_changeNameForcesNew
=== PAUSE TestAccSSMParameter_changeNameForcesNew
=== RUN   TestAccSSMParameter_fullPath
=== PAUSE TestAccSSMParameter_fullPath
=== RUN   TestAccSSMParameter_Secure_basic
=== PAUSE TestAccSSMParameter_Secure_basic
=== RUN   TestAccSSMParameter_Secure_insecure
=== PAUSE TestAccSSMParameter_Secure_insecure
=== RUN   TestAccSSMParameter_Secure_insecureChangeSecure
=== PAUSE TestAccSSMParameter_Secure_insecureChangeSecure
=== RUN   TestAccSSMParameter_DataType_ec2Image
=== PAUSE TestAccSSMParameter_DataType_ec2Image
=== RUN   TestAccSSMParameter_Secure_key
=== PAUSE TestAccSSMParameter_Secure_key
=== RUN   TestAccSSMParameter_Secure_keyUpdate
=== PAUSE TestAccSSMParameter_Secure_keyUpdate
=== CONT  TestAccSSMParameter_basic
=== CONT  TestAccSSMParameter_tags
--- PASS: TestAccSSMParameter_basic (20.53s)
=== CONT  TestAccSSMParameter_disappears
--- PASS: TestAccSSMParameter_disappears (14.56s)
=== CONT  TestAccSSMParameter_Overwrite_updateToTags
--- PASS: TestAccSSMParameter_tags (47.99s)
=== CONT  TestAccSSMParameter_Overwrite_noOverwriteTags
--- PASS: TestAccSSMParameter_Overwrite_updateToTags (30.81s)
=== CONT  TestAccSSMParameter_Overwrite_tags
--- PASS: TestAccSSMParameter_Overwrite_noOverwriteTags (18.02s)
=== CONT  TestAccSSMParameter_Overwrite_cascade
--- PASS: TestAccSSMParameter_Overwrite_tags (24.44s)
=== CONT  TestAccSSMParameter_Overwrite_basic
--- PASS: TestAccSSMParameter_Overwrite_cascade (50.68s)
=== CONT  TestAccSSMParameter_Tier_intelligentTieringToAdvanced
--- PASS: TestAccSSMParameter_Overwrite_basic (63.35s)
=== CONT  TestAccSSMParameter_Tier_intelligentTieringOnUpdate
--- PASS: TestAccSSMParameter_Tier_intelligentTieringToAdvanced (72.38s)
=== CONT  TestAccSSMParameter_Tier_intelligentTieringOnCreation
--- PASS: TestAccSSMParameter_Tier_intelligentTieringOnUpdate (45.79s)
=== CONT  TestAccSSMParameter_Secure_insecure
--- PASS: TestAccSSMParameter_Tier_intelligentTieringOnCreation (30.27s)
=== CONT  TestAccSSMParameter_Secure_keyUpdate
--- PASS: TestAccSSMParameter_Secure_insecure (70.41s)
=== CONT  TestAccSSMParameter_Secure_key
--- PASS: TestAccSSMParameter_Secure_keyUpdate (51.85s)
=== CONT  TestAccSSMParameter_DataType_ec2Image
--- PASS: TestAccSSMParameter_Secure_key (28.96s)
=== CONT  TestAccSSMParameter_Secure_insecureChangeSecure
--- PASS: TestAccSSMParameter_DataType_ec2Image (50.48s)
=== CONT  TestAccSSMParameter_changeNameForcesNew
--- PASS: TestAccSSMParameter_Secure_insecureChangeSecure (65.28s)
=== CONT  TestAccSSMParameter_Secure_basic
--- PASS: TestAccSSMParameter_changeNameForcesNew (49.96s)
=== CONT  TestAccSSMParameter_fullPath
--- PASS: TestAccSSMParameter_Secure_basic (32.82s)
=== CONT  TestAccSSMParameter_Tier_intelligentTieringToStandard
--- PASS: TestAccSSMParameter_fullPath (32.27s)
=== CONT  TestAccSSMParameter_updateType
--- PASS: TestAccSSMParameter_updateType (47.91s)
=== CONT  TestAccSSMParameter_tier
--- PASS: TestAccSSMParameter_Tier_intelligentTieringToStandard (66.43s)
=== CONT  TestAccSSMParameter_Overwrite_updateDescription
--- PASS: TestAccSSMParameter_Overwrite_updateDescription (41.27s)
--- PASS: TestAccSSMParameter_tier (58.31s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ssm	515.061s

@ewbankkit
Copy link
Contributor

@bschaatsbergen Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit e8e229c into hashicorp:main Sep 27, 2022
@github-actions github-actions bot added this to the v4.33.0 milestone Sep 27, 2022
@bschaatsbergen bschaatsbergen deleted the b/fix-overwrite-on-ssm-parameter branch September 27, 2022 21:37
@github-actions
Copy link

This functionality has been released in v4.33.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

@andresvia andresvia andresvia approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. service/ssm Issues and PRs that pertain to the ssm service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.33.0
Development

Successfully merging this pull request may close these issues.

aws_ssm_parameter not allowing overwrite = true
4 participants
@bschaatsbergen @ewbankkit @andresvia @justinretzolk