Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource: aws_kms_custom_key_store #26997

Merged
merged 5 commits into from Sep 28, 2022
Merged

New Resource: aws_kms_custom_key_store #26997

merged 5 commits into from Sep 28, 2022

Conversation

johnsonaj
Copy link
Contributor

@johnsonaj johnsonaj commented Sep 27, 2022 •
edited

Description

New resource for aws_kms_custom_key_store

Relations

Relates #16491

References

Output from Acceptance Testing

$ make testacc TESTARGS='-run=TestAccKMS_serial/CustomKeyStore' PKG=kms ACCTEST_TIMEOUT=180m

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kms/... -v -count 1 -parallel 20  -run=TestAccKMS_serial/CustomKeyStore -timeout 180m
=== RUN   TestAccKMS_serial
=== RUN   TestAccKMS_serial/CustomKeyStore
=== RUN   TestAccKMS_serial/CustomKeyStore/disappears
=== RUN   TestAccKMS_serial/CustomKeyStore/basic
=== RUN   TestAccKMS_serial/CustomKeyStore/update
--- PASS: TestAccKMS_serial (39.01s)
    --- PASS: TestAccKMS_serial/CustomKeyStore (39.01s)
        --- PASS: TestAccKMS_serial/CustomKeyStore/disappears (11.29s)
        --- PASS: TestAccKMS_serial/CustomKeyStore/basic (14.52s)
        --- PASS: TestAccKMS_serial/CustomKeyStore/update (13.20s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kms	41.671s
...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/kms Issues and PRs that pertain to the kms service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. and removed documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/kms Issues and PRs that pertain to the kms service. labels Sep 27, 2022
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/kms Issues and PRs that pertain to the kms service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 27, 2022
@johnsonaj johnsonaj marked this pull request as ready for review September 27, 2022 23:55
@YakDriver YakDriver self-assigned this Sep 28, 2022
YakDriver
YakDriver approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent 🎉

@johnsonaj johnsonaj merged commit 9aad311 into main Sep 28, 2022
@johnsonaj johnsonaj deleted the f-aws_kms_custom_key_store branch September 28, 2022 16:33
@github-actions github-actions bot added this to the v4.33.0 milestone Sep 28, 2022
github-actions bot pushed a commit that referenced this pull request Sep 28, 2022
Update CHANGELOG.md for #26997
a80b61b
@github-actions
Copy link

This functionality has been released in v4.33.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@YakDriver YakDriver YakDriver approved these changes

Assignees

@YakDriver YakDriver

Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/kms Issues and PRs that pertain to the kms service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.33.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@johnsonaj @YakDriver