Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: aws_lightsail_domain_entry #27309

Merged
merged 15 commits into from
Oct 19, 2022

Conversation

brittandeyoung
Copy link
Collaborator

Description

This PR will add the new aws_lightsail_domain_entry resource. This will allow users to manage domain entries for Lightsail with terraform.

Relations

Relates #9370
Closes #2731

References

This is a PR to refactor and revive and cover the functionality of this PR #9370. Original commits where kept in order to give credit to the original author.

Output from Acceptance Testing

➜ terraform-provider-aws (aws_lightsail_domain_entry) ✔ make testacc TESTARGS='-run=TestAccLightsailDomainEntry_' PKG=lightsail ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 2  -run=TestAccLightsailDomainEntry_ -timeout 180m
=== RUN   TestAccLightsailDomainEntry_basic
=== PAUSE TestAccLightsailDomainEntry_basic
=== RUN   TestAccLightsailDomainEntry_disappears
=== PAUSE TestAccLightsailDomainEntry_disappears
=== CONT  TestAccLightsailDomainEntry_basic
=== CONT  TestAccLightsailDomainEntry_disappears
--- PASS: TestAccLightsailDomainEntry_disappears (34.94s)
--- PASS: TestAccLightsailDomainEntry_basic (36.92s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lightsail  38.872s

...

blckct and others added 12 commits September 1, 2019 21:18
Removed Old resource files from before refactor
* Add the FindDomainEntryById function to find
* Added new resource domain_entry
* addd tests for the resource domain_entry
* Refactor to support new design
* update docs with additional attributes
* Add Import section
* Add support for importing resource
* resolve semgrep issues
* Remove AWS from function name
* Remote Lightsail from function name
* update code block type
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/lightsail Issues and PRs that pertain to the lightsail service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. labels Oct 18, 2022
@breathingdust breathingdust added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 18, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccLightsailDomainEntry_' PKG=lightsail
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 20  -run=TestAccLightsailDomainEntry_ -timeout 180m
=== RUN   TestAccLightsailDomainEntry_basic
=== PAUSE TestAccLightsailDomainEntry_basic
=== RUN   TestAccLightsailDomainEntry_disappears
=== PAUSE TestAccLightsailDomainEntry_disappears
=== CONT  TestAccLightsailDomainEntry_basic
=== CONT  TestAccLightsailDomainEntry_disappears
--- PASS: TestAccLightsailDomainEntry_basic (33.70s)
--- PASS: TestAccLightsailDomainEntry_disappears (33.86s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lightsail	37.981s

@ewbankkit
Copy link
Contributor

ewbankkit commented Oct 19, 2022

@brittandeyoung @blckct Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 5b85a57 into hashicorp:main Oct 19, 2022
@github-actions github-actions bot added this to the v4.36.0 milestone Oct 19, 2022
@github-actions
Copy link

This functionality has been released in v4.36.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/lightsail Issues and PRs that pertain to the lightsail service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add AWS Lightsail DNS Entry Support
4 participants