Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_evidently_feature #27395

Merged
merged 30 commits into from
Nov 11, 2022
Merged

Conversation

GlennChia
Copy link
Collaborator

Description

Relations

Relates #22624

References

Output from Acceptance Testing

$ make testacc TESTARGS='-run=TestAccEvidentlyFeature' PKG=evidently
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/evidently/... -v -count 1 -parallel 20  -run=TestAccEvidentlyFeature -timeout 180m
=== RUN   TestAccEvidentlyFeature_basic
=== PAUSE TestAccEvidentlyFeature_basic
=== RUN   TestAccEvidentlyFeature_updateDefaultVariation
=== PAUSE TestAccEvidentlyFeature_updateDefaultVariation
=== RUN   TestAccEvidentlyFeature_updateDescription
=== PAUSE TestAccEvidentlyFeature_updateDescription
=== RUN   TestAccEvidentlyFeature_updateEntityOverrides
=== PAUSE TestAccEvidentlyFeature_updateEntityOverrides
=== RUN   TestAccEvidentlyFeature_updateEvaluationStrategy
=== PAUSE TestAccEvidentlyFeature_updateEvaluationStrategy
=== RUN   TestAccEvidentlyFeature_updateVariationsBoolValue
=== PAUSE TestAccEvidentlyFeature_updateVariationsBoolValue
=== RUN   TestAccEvidentlyFeature_updateVariationsDoubleValue
=== PAUSE TestAccEvidentlyFeature_updateVariationsDoubleValue
=== RUN   TestAccEvidentlyFeature_updateVariationsLongValue
=== PAUSE TestAccEvidentlyFeature_updateVariationsLongValue
=== RUN   TestAccEvidentlyFeature_updateVariationsStringValue
=== PAUSE TestAccEvidentlyFeature_updateVariationsStringValue
=== RUN   TestAccEvidentlyFeature_tags
=== PAUSE TestAccEvidentlyFeature_tags
=== RUN   TestAccEvidentlyFeature_disappears
=== PAUSE TestAccEvidentlyFeature_disappears
=== CONT  TestAccEvidentlyFeature_basic
=== CONT  TestAccEvidentlyFeature_updateVariationsDoubleValue
=== CONT  TestAccEvidentlyFeature_tags
=== CONT  TestAccEvidentlyFeature_updateVariationsStringValue
=== CONT  TestAccEvidentlyFeature_updateVariationsLongValue
=== CONT  TestAccEvidentlyFeature_updateEntityOverrides
=== CONT  TestAccEvidentlyFeature_updateVariationsBoolValue
=== CONT  TestAccEvidentlyFeature_disappears
=== CONT  TestAccEvidentlyFeature_updateEvaluationStrategy
=== CONT  TestAccEvidentlyFeature_updateDefaultVariation
=== CONT  TestAccEvidentlyFeature_updateDescription
--- PASS: TestAccEvidentlyFeature_disappears (29.35s)
--- PASS: TestAccEvidentlyFeature_basic (33.05s)
--- PASS: TestAccEvidentlyFeature_updateDefaultVariation (50.88s)
--- PASS: TestAccEvidentlyFeature_updateVariationsDoubleValue (51.31s)
--- PASS: TestAccEvidentlyFeature_updateVariationsLongValue (52.00s)
--- PASS: TestAccEvidentlyFeature_updateEntityOverrides (52.12s)
--- PASS: TestAccEvidentlyFeature_updateVariationsBoolValue (53.45s)
--- PASS: TestAccEvidentlyFeature_updateEvaluationStrategy (56.00s)
--- PASS: TestAccEvidentlyFeature_updateDescription (56.07s)
--- PASS: TestAccEvidentlyFeature_tags (68.43s)
--- PASS: TestAccEvidentlyFeature_updateVariationsStringValue (69.63s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/evidently  69.728s

...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. labels Oct 22, 2022
@github-actions github-actions bot added service/evidently Issues and PRs that pertain to the evidently service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 22, 2022
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Oct 24, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccEvidentlyFeature_' PKG=evidently ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/evidently/... -v -count 1 -parallel 2  -run=TestAccEvidentlyFeature_ -timeout 180m
=== RUN   TestAccEvidentlyFeature_basic
=== PAUSE TestAccEvidentlyFeature_basic
=== RUN   TestAccEvidentlyFeature_updateDefaultVariation
=== PAUSE TestAccEvidentlyFeature_updateDefaultVariation
=== RUN   TestAccEvidentlyFeature_updateDescription
=== PAUSE TestAccEvidentlyFeature_updateDescription
=== RUN   TestAccEvidentlyFeature_updateEntityOverrides
=== PAUSE TestAccEvidentlyFeature_updateEntityOverrides
=== RUN   TestAccEvidentlyFeature_updateEvaluationStrategy
=== PAUSE TestAccEvidentlyFeature_updateEvaluationStrategy
=== RUN   TestAccEvidentlyFeature_updateVariationsBoolValue
=== PAUSE TestAccEvidentlyFeature_updateVariationsBoolValue
=== RUN   TestAccEvidentlyFeature_updateVariationsDoubleValue
=== PAUSE TestAccEvidentlyFeature_updateVariationsDoubleValue
=== RUN   TestAccEvidentlyFeature_updateVariationsLongValue
=== PAUSE TestAccEvidentlyFeature_updateVariationsLongValue
=== RUN   TestAccEvidentlyFeature_updateVariationsStringValue
=== PAUSE TestAccEvidentlyFeature_updateVariationsStringValue
=== RUN   TestAccEvidentlyFeature_tags
=== PAUSE TestAccEvidentlyFeature_tags
=== RUN   TestAccEvidentlyFeature_disappears
=== PAUSE TestAccEvidentlyFeature_disappears
=== CONT  TestAccEvidentlyFeature_basic
=== CONT  TestAccEvidentlyFeature_updateVariationsDoubleValue
--- PASS: TestAccEvidentlyFeature_basic (23.65s)
=== CONT  TestAccEvidentlyFeature_updateEntityOverrides
--- PASS: TestAccEvidentlyFeature_updateVariationsDoubleValue (37.25s)
=== CONT  TestAccEvidentlyFeature_updateVariationsBoolValue
--- PASS: TestAccEvidentlyFeature_updateEntityOverrides (35.02s)
=== CONT  TestAccEvidentlyFeature_updateEvaluationStrategy
--- PASS: TestAccEvidentlyFeature_updateVariationsBoolValue (37.18s)
=== CONT  TestAccEvidentlyFeature_updateDescription
--- PASS: TestAccEvidentlyFeature_updateEvaluationStrategy (44.22s)
=== CONT  TestAccEvidentlyFeature_updateDefaultVariation
--- PASS: TestAccEvidentlyFeature_updateDescription (47.16s)
=== CONT  TestAccEvidentlyFeature_tags
--- PASS: TestAccEvidentlyFeature_updateDefaultVariation (47.95s)
=== CONT  TestAccEvidentlyFeature_disappears
--- PASS: TestAccEvidentlyFeature_disappears (23.64s)
=== CONT  TestAccEvidentlyFeature_updateVariationsStringValue
--- PASS: TestAccEvidentlyFeature_tags (65.78s)
=== CONT  TestAccEvidentlyFeature_updateVariationsLongValue
--- PASS: TestAccEvidentlyFeature_updateVariationsLongValue (48.33s)
--- PASS: TestAccEvidentlyFeature_updateVariationsStringValue (69.43s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/evidently	248.526s

@ewbankkit
Copy link
Contributor

@GlennChia Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 5b05a55 into hashicorp:main Nov 11, 2022
@github-actions github-actions bot added this to the v4.40.0 milestone Nov 11, 2022
@github-actions
Copy link

This functionality has been released in v4.40.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2022
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. partner Contribution from a partner. provider Pertains to the provider itself, rather than any interaction with AWS. service/evidently Issues and PRs that pertain to the evidently service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants