Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new data source for aws appmesh virtual node #27545

Conversation

shogohida
Copy link
Contributor

@shogohida shogohida commented Oct 30, 2022

Description

Add new data source for aws appmesh virtual node

Relations

Closes #26909.
Relates #17590.

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccXXX PKG=ec2

...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/appmesh Issues and PRs that pertain to the appmesh service. needs-triage Waiting for first response or review from a maintainer. labels Oct 30, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @shogohida 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 1, 2022
@shogohida shogohida marked this pull request as ready for review December 9, 2022 15:01
@shogohida
Copy link
Contributor Author

I wanted to see if my approach is right before writing tests so I decided to open the pull request.

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAppMesh_serial/^VirtualNode$$' PKG=appmesh
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appmesh/... -v -count 1 -parallel 20  -run=TestAccAppMesh_serial/^VirtualNode$ -timeout 180m
=== RUN   TestAccAppMesh_serial
=== PAUSE TestAccAppMesh_serial
=== CONT  TestAccAppMesh_serial
=== RUN   TestAccAppMesh_serial/VirtualNode
=== RUN   TestAccAppMesh_serial/VirtualNode/backendClientPolicyAcm
=== RUN   TestAccAppMesh_serial/VirtualNode/backendClientPolicyFile
=== RUN   TestAccAppMesh_serial/VirtualNode/backendDefaultsCertificate
=== RUN   TestAccAppMesh_serial/VirtualNode/cloudMapServiceDiscovery
=== RUN   TestAccAppMesh_serial/VirtualNode/listenerConnectionPool
=== RUN   TestAccAppMesh_serial/VirtualNode/listenerValidation
=== RUN   TestAccAppMesh_serial/VirtualNode/basic
=== RUN   TestAccAppMesh_serial/VirtualNode/backendDefaults
=== RUN   TestAccAppMesh_serial/VirtualNode/listenerTls
=== RUN   TestAccAppMesh_serial/VirtualNode/multiListenerValidation
=== RUN   TestAccAppMesh_serial/VirtualNode/tags
=== RUN   TestAccAppMesh_serial/VirtualNode/disappears
=== RUN   TestAccAppMesh_serial/VirtualNode/listenerOutlierDetection
=== RUN   TestAccAppMesh_serial/VirtualNode/listenerHealthChecks
=== RUN   TestAccAppMesh_serial/VirtualNode/logging
=== RUN   TestAccAppMesh_serial/VirtualNode/dataSourceBasic
=== RUN   TestAccAppMesh_serial/VirtualNode/listenerTimeout
--- PASS: TestAccAppMesh_serial (593.13s)
    --- PASS: TestAccAppMesh_serial/VirtualNode (593.13s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/backendClientPolicyAcm (60.24s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/backendClientPolicyFile (25.86s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/backendDefaultsCertificate (15.44s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/cloudMapServiceDiscovery (113.75s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/listenerConnectionPool (27.06s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/listenerValidation (26.73s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/basic (15.49s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/backendDefaults (26.07s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/listenerTls (75.27s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/multiListenerValidation (26.29s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/tags (36.78s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/disappears (12.96s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/listenerOutlierDetection (26.21s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/listenerHealthChecks (26.16s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/logging (37.50s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/dataSourceBasic (14.49s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/listenerTimeout (26.84s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appmesh	598.478s

@github-actions github-actions bot added generators Relates to code generators. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed provider Pertains to the provider itself, rather than any interaction with AWS. labels Mar 24, 2023
@ewbankkit
Copy link
Contributor

@shogohida Thanks for the contribution 🎉 👏.

@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Mar 24, 2023
@ewbankkit ewbankkit merged commit 7d3f357 into hashicorp:main Mar 24, 2023
10 checks passed
@github-actions github-actions bot added this to the v4.61.0 milestone Mar 24, 2023
@github-actions
Copy link

This functionality has been released in v4.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 1, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-data-source Introduces a new data source. service/appmesh Issues and PRs that pertain to the appmesh service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Data Source]: aws_appmesh_virtual_node
3 participants