Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update validation rule in appstream stack resource #27744

Merged
merged 3 commits into from
Nov 15, 2022

Conversation

pierskarsenbarg
Copy link
Contributor

@pierskarsenbarg pierskarsenbarg commented Nov 10, 2022

Description

Increase max length of redirectUrl in appstream stack resource. Docs specify that max length is 1000: https://docs.aws.amazon.com/appstream2/latest/APIReference/API_CreateStack.html#AppStream2-CreateStack-request-RedirectURL

Relations

Fixes #27743

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccXXX PKG=ec2

...

Redirect URL did have a maximum length of 100, but should be 1000
@github-actions github-actions bot added service/appstream Issues and PRs that pertain to the appstream service. needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. labels Nov 10, 2022
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 10, 2022
@jar-b jar-b self-assigned this Nov 14, 2022
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

$ make testacc PKG=appstream TESTS=TestAccAppStreamStack_ ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appstream/... -v -count 1 -parallel 2 -run='TestAccAppStreamStack_'  -timeout 180m
=== RUN   TestAccAppStreamStack_basic
=== PAUSE TestAccAppStreamStack_basic
=== RUN   TestAccAppStreamStack_disappears
=== PAUSE TestAccAppStreamStack_disappears
=== RUN   TestAccAppStreamStack_complete
=== PAUSE TestAccAppStreamStack_complete
=== RUN   TestAccAppStreamStack_applicationSettings_basic
=== PAUSE TestAccAppStreamStack_applicationSettings_basic
=== RUN   TestAccAppStreamStack_applicationSettings_removeFromEnabled
=== PAUSE TestAccAppStreamStack_applicationSettings_removeFromEnabled
=== RUN   TestAccAppStreamStack_applicationSettings_removeFromDisabled
=== PAUSE TestAccAppStreamStack_applicationSettings_removeFromDisabled
=== RUN   TestAccAppStreamStack_withTags
=== PAUSE TestAccAppStreamStack_withTags
=== CONT  TestAccAppStreamStack_basic
=== CONT  TestAccAppStreamStack_applicationSettings_removeFromEnabled
--- PASS: TestAccAppStreamStack_basic (17.36s)
=== CONT  TestAccAppStreamStack_complete
--- PASS: TestAccAppStreamStack_applicationSettings_removeFromEnabled (28.63s)
=== CONT  TestAccAppStreamStack_applicationSettings_basic
--- PASS: TestAccAppStreamStack_complete (29.38s)
=== CONT  TestAccAppStreamStack_disappears
--- PASS: TestAccAppStreamStack_disappears (12.45s)
=== CONT  TestAccAppStreamStack_withTags
--- PASS: TestAccAppStreamStack_applicationSettings_basic (43.13s)
=== CONT  TestAccAppStreamStack_applicationSettings_removeFromDisabled
--- PASS: TestAccAppStreamStack_withTags (29.26s)
--- PASS: TestAccAppStreamStack_applicationSettings_removeFromDisabled (21.03s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appstream  95.417s

@jar-b jar-b merged commit d5ddeed into hashicorp:main Nov 15, 2022
@github-actions github-actions bot added this to the v4.40.0 milestone Nov 15, 2022
@jar-b
Copy link
Member

jar-b commented Nov 15, 2022

Nice find, @pierskarsenbarg! Thanks for your contribution 👏

@github-actions
Copy link

This functionality has been released in v4.40.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2022
@pierskarsenbarg pierskarsenbarg deleted the increase-redirect-url-length branch March 27, 2024 16:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/appstream Issues and PRs that pertain to the appstream service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: appstream stack redirect url should have a maximum value of 1000
3 participants