Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add import support for aws_network_interface_sg_attachment resource #27785

Conversation

finalduty
Copy link
Contributor

Description

This PR adds support for importing existing aws_network_interface_sg_attachment resources.

Relations

Closes #27076

References

None

Output from Acceptance Testing

$ make testacc TESTS=TestAccVPCNetworkInterfaceSgAttachment PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCNetworkInterfaceSgAttachment'  -timeout 180m
=== RUN   TestAccVPCNetworkInterfaceSgAttachment_basic
=== PAUSE TestAccVPCNetworkInterfaceSgAttachment_basic
=== RUN   TestAccVPCNetworkInterfaceSgAttachment_disappears
=== PAUSE TestAccVPCNetworkInterfaceSgAttachment_disappears
=== RUN   TestAccVPCNetworkInterfaceSgAttachment_instance
=== PAUSE TestAccVPCNetworkInterfaceSgAttachment_instance
=== RUN   TestAccVPCNetworkInterfaceSgAttachment_multiple
=== PAUSE TestAccVPCNetworkInterfaceSgAttachment_multiple
=== CONT  TestAccVPCNetworkInterfaceSgAttachment_basic
=== CONT  TestAccVPCNetworkInterfaceSgAttachment_instance
=== CONT  TestAccVPCNetworkInterfaceSgAttachment_multiple
=== CONT  TestAccVPCNetworkInterfaceSgAttachment_disappears
--- PASS: TestAccVPCNetworkInterfaceSgAttachment_disappears (67.99s)
--- PASS: TestAccVPCNetworkInterfaceSgAttachment_basic (72.75s)
--- PASS: TestAccVPCNetworkInterfaceSgAttachment_multiple (74.74s)
--- PASS: TestAccVPCNetworkInterfaceSgAttachment_instance (163.62s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        167.087s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/vpc Issues and PRs that pertain to the vpc service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 14, 2022
@finalduty finalduty force-pushed the f-vpc_network_interface_sg_attachment-import branch from c3b32e9 to 92dd9fb Compare November 14, 2022 04:58
@finalduty finalduty changed the title Add import support for vpc_network_interface_sg_attachment resource Add import support for aws_network_interface_sg_attachment resource Nov 14, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @finalduty 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Nov 15, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccVPCNetworkInterfaceSgAttachment_basic' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccVPCNetworkInterfaceSgAttachment_basic -timeout 180m
=== RUN   TestAccVPCNetworkInterfaceSgAttachment_basic
=== PAUSE TestAccVPCNetworkInterfaceSgAttachment_basic
=== CONT  TestAccVPCNetworkInterfaceSgAttachment_basic
--- PASS: TestAccVPCNetworkInterfaceSgAttachment_basic (27.12s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	31.372s

@ewbankkit
Copy link
Contributor

@finalduty Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit edb3d19 into hashicorp:main Nov 15, 2022
@github-actions github-actions bot added this to the v4.40.0 milestone Nov 15, 2022
@github-actions
Copy link

This functionality has been released in v4.40.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/vpc Issues and PRs that pertain to the vpc service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: provide importer for aws_network_interface_sg_attachment
2 participants