Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new data source: aws_ivs_stream_key #27789

Merged
merged 4 commits into from
Nov 15, 2022

Conversation

KevinEady
Copy link
Contributor

Description

Add new data source for AWS IVS Stream Key: aws_ivs_stream_key. This PR is the last in a set to support the full AWS IVS entities:

  1. Playback Key Pair
  2. Recording Configuration
  3. Channel
  4. Stream Key

Relations

Relates #17272

Output from Acceptance Testing

$ make testacc TESTS=TestAccIVSStreamKeyDataSource_ PKG=ivs
==> Checking that code complies with gofmt requirements...
TF_ACC=1 /Users/eakevinh/go/bin/go1.18.4 test ./internal/service/ivs/... -v -count 1 -parallel 20 -run='TestAccIVSStreamKeyDataSource_'  -timeout 180m
=== RUN   TestAccIVSStreamKeyDataSource_basic
=== PAUSE TestAccIVSStreamKeyDataSource_basic
=== CONT  TestAccIVSStreamKeyDataSource_basic
--- PASS: TestAccIVSStreamKeyDataSource_basic (32.33s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ivs        35.249s

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/ivs Issues and PRs that pertain to the ivs service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 14, 2022
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added the examples Introduces or discusses updates to examples. label Nov 14, 2022
- terraform "required_version" attribute is required
- fix formatting
@KevinEady KevinEady marked this pull request as ready for review November 14, 2022 13:24
@ewbankkit ewbankkit added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 15, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccIVSStreamKeyDataSource_ PKG=ivs
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ivs/... -v -count 1 -parallel 20 -run='TestAccIVSStreamKeyDataSource_'  -timeout 180m
=== RUN   TestAccIVSStreamKeyDataSource_basic
=== PAUSE TestAccIVSStreamKeyDataSource_basic
=== CONT  TestAccIVSStreamKeyDataSource_basic
--- PASS: TestAccIVSStreamKeyDataSource_basic (19.28s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ivs	23.811s

@ewbankkit
Copy link
Contributor

@KevinEady Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 130d29a into hashicorp:main Nov 15, 2022
@github-actions github-actions bot added this to the v4.40.0 milestone Nov 15, 2022
@KevinEady KevinEady deleted the f-ivs-stream_key branch November 15, 2022 15:19
@github-actions
Copy link

This functionality has been released in v4.40.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. examples Introduces or discusses updates to examples. new-data-source Introduces a new data source. provider Pertains to the provider itself, rather than any interaction with AWS. service/ivs Issues and PRs that pertain to the ivs service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants