Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: aws_scheduler_schedule_group #27800

Merged
merged 3 commits into from
Nov 16, 2022

Conversation

roberth-k
Copy link
Contributor

Description

Relations

Relates #27760

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccSchedulerScheduleGroup_ PKG=scheduler
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/scheduler/... -v -count 1 -parallel 20 -run='TestAccSchedulerScheduleGroup_'  -timeout 180m
=== RUN   TestAccSchedulerScheduleGroup_basic
=== PAUSE TestAccSchedulerScheduleGroup_basic
=== RUN   TestAccSchedulerScheduleGroup_disappears
=== PAUSE TestAccSchedulerScheduleGroup_disappears
=== RUN   TestAccSchedulerScheduleGroup_nameGenerated
=== PAUSE TestAccSchedulerScheduleGroup_nameGenerated
=== RUN   TestAccSchedulerScheduleGroup_namePrefix
=== PAUSE TestAccSchedulerScheduleGroup_namePrefix
=== RUN   TestAccSchedulerScheduleGroup_tags
=== PAUSE TestAccSchedulerScheduleGroup_tags
=== CONT  TestAccSchedulerScheduleGroup_basic
=== CONT  TestAccSchedulerScheduleGroup_namePrefix
=== CONT  TestAccSchedulerScheduleGroup_nameGenerated
=== CONT  TestAccSchedulerScheduleGroup_disappears
=== CONT  TestAccSchedulerScheduleGroup_tags
--- PASS: TestAccSchedulerScheduleGroup_disappears (22.34s)
--- PASS: TestAccSchedulerScheduleGroup_nameGenerated (24.48s)
--- PASS: TestAccSchedulerScheduleGroup_namePrefix (24.54s)
--- PASS: TestAccSchedulerScheduleGroup_basic (24.77s)
--- PASS: TestAccSchedulerScheduleGroup_tags (39.40s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/scheduler  41.255s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. generators Relates to code generators. provider Pertains to the provider itself, rather than any interaction with AWS. service/scheduler Issues and PRs that pertain to the scheduler service. size/XL Managed by automation to categorize the size of a PR. tags Pertains to resource tagging. needs-triage Waiting for first response or review from a maintainer. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 14, 2022
roberth-k added a commit to roberth-k/terraform-provider-aws that referenced this pull request Nov 14, 2022
@github-actions github-actions bot added the sweeper Pertains to changes to or issues with the sweeper. label Nov 15, 2022
roberth-k added a commit to roberth-k/terraform-provider-aws that referenced this pull request Nov 15, 2022
@roberth-k roberth-k force-pushed the f-aws_scheduler_schedule_group branch from dd17de0 to 67ca581 Compare November 15, 2022 13:34
@roberth-k roberth-k force-pushed the f-aws_scheduler_schedule_group branch from 67ca581 to 4134927 Compare November 15, 2022 15:52
@ewbankkit ewbankkit added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 16, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSchedulerScheduleGroup_' PKG=scheduler ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/scheduler/... -v -count 1 -parallel 2  -run=TestAccSchedulerScheduleGroup_ -timeout 180m
=== RUN   TestAccSchedulerScheduleGroup_basic
=== PAUSE TestAccSchedulerScheduleGroup_basic
=== RUN   TestAccSchedulerScheduleGroup_disappears
=== PAUSE TestAccSchedulerScheduleGroup_disappears
=== RUN   TestAccSchedulerScheduleGroup_nameGenerated
=== PAUSE TestAccSchedulerScheduleGroup_nameGenerated
=== RUN   TestAccSchedulerScheduleGroup_namePrefix
=== PAUSE TestAccSchedulerScheduleGroup_namePrefix
=== RUN   TestAccSchedulerScheduleGroup_tags
=== PAUSE TestAccSchedulerScheduleGroup_tags
=== CONT  TestAccSchedulerScheduleGroup_basic
=== CONT  TestAccSchedulerScheduleGroup_namePrefix
--- PASS: TestAccSchedulerScheduleGroup_basic (36.46s)
=== CONT  TestAccSchedulerScheduleGroup_nameGenerated
--- PASS: TestAccSchedulerScheduleGroup_namePrefix (36.56s)
=== CONT  TestAccSchedulerScheduleGroup_disappears
--- PASS: TestAccSchedulerScheduleGroup_disappears (29.94s)
=== CONT  TestAccSchedulerScheduleGroup_tags
--- PASS: TestAccSchedulerScheduleGroup_nameGenerated (35.32s)
--- PASS: TestAccSchedulerScheduleGroup_tags (66.46s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/scheduler	137.622s

@ewbankkit
Copy link
Contributor

@roberth-k Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit cf2c344 into hashicorp:main Nov 16, 2022
@github-actions github-actions bot added this to the v4.40.0 milestone Nov 16, 2022
@github-actions
Copy link

This functionality has been released in v4.40.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/scheduler Issues and PRs that pertain to the scheduler service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants