Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_security_group_rule: Add security_group_rule_id attribute #27828

Merged
merged 11 commits into from
Nov 16, 2022
Merged

r/aws_security_group_rule: Add security_group_rule_id attribute #27828

merged 11 commits into from
Nov 16, 2022

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Nov 15, 2022 •
edited

Description

Adds the security_group_rule_id attribute to the aws_security_group_rule resource.
If the resource has a single source or destination then the EC2 IpPermission structure represented by this resource maps 1-to-1 with an EC2 SecurityGroupRule structure and the security_group_rule_id attribute receives the AWS Security Group Rule resource ID. In other cases there is not a 1-to-1 mapping and the attribute will be empty ("").

Relations

Relates #20104.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccVPCSecurityGroupRule_' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccVPCSecurityGroupRule_ -timeout 180m
=== RUN   TestAccVPCSecurityGroupRule_Ingress_vpc
=== PAUSE TestAccVPCSecurityGroupRule_Ingress_vpc
=== RUN   TestAccVPCSecurityGroupRule_IngressSourceWithAccount_id
=== PAUSE TestAccVPCSecurityGroupRule_IngressSourceWithAccount_id
=== RUN   TestAccVPCSecurityGroupRule_Ingress_protocol
=== PAUSE TestAccVPCSecurityGroupRule_Ingress_protocol
=== RUN   TestAccVPCSecurityGroupRule_Ingress_icmpv6
=== PAUSE TestAccVPCSecurityGroupRule_Ingress_icmpv6
=== RUN   TestAccVPCSecurityGroupRule_Ingress_ipv6
=== PAUSE TestAccVPCSecurityGroupRule_Ingress_ipv6
=== RUN   TestAccVPCSecurityGroupRule_egress
=== PAUSE TestAccVPCSecurityGroupRule_egress
=== RUN   TestAccVPCSecurityGroupRule_selfReference
=== PAUSE TestAccVPCSecurityGroupRule_selfReference
=== RUN   TestAccVPCSecurityGroupRule_expectInvalidTypeError
=== PAUSE TestAccVPCSecurityGroupRule_expectInvalidTypeError
=== RUN   TestAccVPCSecurityGroupRule_expectInvalidCIDR
=== PAUSE TestAccVPCSecurityGroupRule_expectInvalidCIDR
=== RUN   TestAccVPCSecurityGroupRule_PartialMatching_basic
=== PAUSE TestAccVPCSecurityGroupRule_PartialMatching_basic
=== RUN   TestAccVPCSecurityGroupRule_PartialMatching_source
=== PAUSE TestAccVPCSecurityGroupRule_PartialMatching_source
=== RUN   TestAccVPCSecurityGroupRule_issue5310
=== PAUSE TestAccVPCSecurityGroupRule_issue5310
=== RUN   TestAccVPCSecurityGroupRule_race
=== PAUSE TestAccVPCSecurityGroupRule_race
=== RUN   TestAccVPCSecurityGroupRule_selfSource
=== PAUSE TestAccVPCSecurityGroupRule_selfSource
=== RUN   TestAccVPCSecurityGroupRule_prefixListEgress
=== PAUSE TestAccVPCSecurityGroupRule_prefixListEgress
=== RUN   TestAccVPCSecurityGroupRule_prefixListEmptyString
=== PAUSE TestAccVPCSecurityGroupRule_prefixListEmptyString
=== RUN   TestAccVPCSecurityGroupRule_ingressDescription
=== PAUSE TestAccVPCSecurityGroupRule_ingressDescription
=== RUN   TestAccVPCSecurityGroupRule_egressDescription
=== PAUSE TestAccVPCSecurityGroupRule_egressDescription
=== RUN   TestAccVPCSecurityGroupRule_IngressDescription_updates
=== PAUSE TestAccVPCSecurityGroupRule_IngressDescription_updates
=== RUN   TestAccVPCSecurityGroupRule_EgressDescription_updates
=== PAUSE TestAccVPCSecurityGroupRule_EgressDescription_updates
=== RUN   TestAccVPCSecurityGroupRule_Description_allPorts
=== PAUSE TestAccVPCSecurityGroupRule_Description_allPorts
=== RUN   TestAccVPCSecurityGroupRule_DescriptionAllPorts_nonZeroPorts
=== PAUSE TestAccVPCSecurityGroupRule_DescriptionAllPorts_nonZeroPorts
=== RUN   TestAccVPCSecurityGroupRule_MultipleRuleSearching_allProtocolCrash
=== PAUSE TestAccVPCSecurityGroupRule_MultipleRuleSearching_allProtocolCrash
=== RUN   TestAccVPCSecurityGroupRule_multiDescription
=== PAUSE TestAccVPCSecurityGroupRule_multiDescription
=== RUN   TestAccVPCSecurityGroupRule_Ingress_multipleIPv6
=== PAUSE TestAccVPCSecurityGroupRule_Ingress_multipleIPv6
=== RUN   TestAccVPCSecurityGroupRule_Ingress_multiplePrefixLists
=== PAUSE TestAccVPCSecurityGroupRule_Ingress_multiplePrefixLists
=== RUN   TestAccVPCSecurityGroupRule_Ingress_peeredVPC
=== PAUSE TestAccVPCSecurityGroupRule_Ingress_peeredVPC
=== RUN   TestAccVPCSecurityGroupRule_Ingress_ipv4AndIPv6
=== PAUSE TestAccVPCSecurityGroupRule_Ingress_ipv4AndIPv6
=== RUN   TestAccVPCSecurityGroupRule_Ingress_prefixListAndSelf
=== PAUSE TestAccVPCSecurityGroupRule_Ingress_prefixListAndSelf
=== RUN   TestAccVPCSecurityGroupRule_Ingress_prefixListAndSource
=== PAUSE TestAccVPCSecurityGroupRule_Ingress_prefixListAndSource
=== RUN   TestAccVPCSecurityGroupRule_protocolChange
=== PAUSE TestAccVPCSecurityGroupRule_protocolChange
=== CONT  TestAccVPCSecurityGroupRule_Ingress_vpc
=== CONT  TestAccVPCSecurityGroupRule_ingressDescription
--- PASS: TestAccVPCSecurityGroupRule_ingressDescription (22.71s)
=== CONT  TestAccVPCSecurityGroupRule_Ingress_multipleIPv6
--- PASS: TestAccVPCSecurityGroupRule_Ingress_vpc (22.71s)
=== CONT  TestAccVPCSecurityGroupRule_protocolChange
--- PASS: TestAccVPCSecurityGroupRule_Ingress_multipleIPv6 (26.67s)
=== CONT  TestAccVPCSecurityGroupRule_Ingress_prefixListAndSource
--- PASS: TestAccVPCSecurityGroupRule_Ingress_prefixListAndSource (32.71s)
=== CONT  TestAccVPCSecurityGroupRule_Ingress_prefixListAndSelf
--- PASS: TestAccVPCSecurityGroupRule_protocolChange (61.08s)
=== CONT  TestAccVPCSecurityGroupRule_Ingress_ipv4AndIPv6
--- PASS: TestAccVPCSecurityGroupRule_Ingress_ipv4AndIPv6 (27.32s)
=== CONT  TestAccVPCSecurityGroupRule_Ingress_peeredVPC
    acctest.go:645: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccVPCSecurityGroupRule_Ingress_peeredVPC (0.00s)
=== CONT  TestAccVPCSecurityGroupRule_Ingress_multiplePrefixLists
--- PASS: TestAccVPCSecurityGroupRule_Ingress_prefixListAndSelf (33.21s)
=== CONT  TestAccVPCSecurityGroupRule_expectInvalidCIDR
--- PASS: TestAccVPCSecurityGroupRule_expectInvalidCIDR (1.93s)
=== CONT  TestAccVPCSecurityGroupRule_prefixListEmptyString
--- PASS: TestAccVPCSecurityGroupRule_prefixListEmptyString (1.21s)
=== CONT  TestAccVPCSecurityGroupRule_prefixListEgress
--- PASS: TestAccVPCSecurityGroupRule_Ingress_multiplePrefixLists (32.78s)
=== CONT  TestAccVPCSecurityGroupRule_selfSource
--- PASS: TestAccVPCSecurityGroupRule_prefixListEgress (36.99s)
=== CONT  TestAccVPCSecurityGroupRule_race
--- PASS: TestAccVPCSecurityGroupRule_race (154.73s)
=== CONT  TestAccVPCSecurityGroupRule_issue5310
--- PASS: TestAccVPCSecurityGroupRule_selfSource (26.77s)
=== CONT  TestAccVPCSecurityGroupRule_PartialMatching_source
--- PASS: TestAccVPCSecurityGroupRule_issue5310 (22.47s)
=== CONT  TestAccVPCSecurityGroupRule_PartialMatching_basic
--- PASS: TestAccVPCSecurityGroupRule_PartialMatching_source (30.24s)
=== CONT  TestAccVPCSecurityGroupRule_Description_allPorts
--- PASS: TestAccVPCSecurityGroupRule_PartialMatching_basic (33.87s)
=== CONT  TestAccVPCSecurityGroupRule_multiDescription
--- PASS: TestAccVPCSecurityGroupRule_Description_allPorts (35.43s)
=== CONT  TestAccVPCSecurityGroupRule_MultipleRuleSearching_allProtocolCrash
--- PASS: TestAccVPCSecurityGroupRule_MultipleRuleSearching_allProtocolCrash (25.71s)
=== CONT  TestAccVPCSecurityGroupRule_DescriptionAllPorts_nonZeroPorts
--- PASS: TestAccVPCSecurityGroupRule_multiDescription (74.93s)
=== CONT  TestAccVPCSecurityGroupRule_selfReference
--- PASS: TestAccVPCSecurityGroupRule_DescriptionAllPorts_nonZeroPorts (35.07s)
=== CONT  TestAccVPCSecurityGroupRule_expectInvalidTypeError
--- PASS: TestAccVPCSecurityGroupRule_expectInvalidTypeError (1.19s)
=== CONT  TestAccVPCSecurityGroupRule_Ingress_protocol
--- PASS: TestAccVPCSecurityGroupRule_selfReference (26.55s)
=== CONT  TestAccVPCSecurityGroupRule_Ingress_icmpv6
--- PASS: TestAccVPCSecurityGroupRule_Ingress_protocol (26.31s)
=== CONT  TestAccVPCSecurityGroupRule_IngressSourceWithAccount_id
--- PASS: TestAccVPCSecurityGroupRule_IngressSourceWithAccount_id (23.58s)
=== CONT  TestAccVPCSecurityGroupRule_egress
--- PASS: TestAccVPCSecurityGroupRule_Ingress_icmpv6 (26.44s)
=== CONT  TestAccVPCSecurityGroupRule_IngressDescription_updates
--- PASS: TestAccVPCSecurityGroupRule_egress (21.40s)
=== CONT  TestAccVPCSecurityGroupRule_EgressDescription_updates
--- PASS: TestAccVPCSecurityGroupRule_IngressDescription_updates (33.75s)
=== CONT  TestAccVPCSecurityGroupRule_egressDescription
--- PASS: TestAccVPCSecurityGroupRule_EgressDescription_updates (34.50s)
=== CONT  TestAccVPCSecurityGroupRule_Ingress_ipv6
--- PASS: TestAccVPCSecurityGroupRule_egressDescription (21.59s)
--- PASS: TestAccVPCSecurityGroupRule_Ingress_ipv6 (25.15s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	433.715s
% make testacc TESTARGS='-run=TestAccVPCSecurityGroupRule_Ingress_peeredVPC' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccVPCSecurityGroupRule_Ingress_peeredVPC -timeout 180m
=== RUN   TestAccVPCSecurityGroupRule_Ingress_peeredVPC
=== PAUSE TestAccVPCSecurityGroupRule_Ingress_peeredVPC
=== CONT  TestAccVPCSecurityGroupRule_Ingress_peeredVPC
--- PASS: TestAccVPCSecurityGroupRule_Ingress_peeredVPC (33.45s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	39.244s

@ewbankkit
Add 'FindSecurityGroupRulesBySecurityGroupID'.
3613c36
@ewbankkit
r/aws_security_group_rule: Set 'security_group_rule_id' on Create.
33bbdfe
@ewbankkit
r/aws_security_group: Switch to 'WithoutTimeout' CRUD handlers (#15090).
a298243
@ewbankkit
d/aws_security_group: Switch to 'WithoutTimeout' CRUD handlers (#15090).
32c9657
@ewbankkit
d/aws_security_groups: Switch to 'WithoutTimeout' CRUD handlers (#15090…
f6ef354 
…).
@ewbankkit
r/aws_security_group_rule: Switch to 'WithoutTimeout' CRUD handlers (#…
0d90774 
…15090).
@ewbankkit
Add 'context.Context' argumnet to 'FindSecurityGroups' and friends.
fef80b7
@ewbankkit
Add 'findSecurityGroupRuleMatch'.
968af07
@ewbankkit
r/aws_security_group_rule: Test 'security_group_rule_id' attribute.
2eb0a13 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccVPCSecurityGroupRule_' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccVPCSecurityGroupRule_ -timeout 180m
=== RUN   TestAccVPCSecurityGroupRule_Ingress_vpc
=== PAUSE TestAccVPCSecurityGroupRule_Ingress_vpc
=== RUN   TestAccVPCSecurityGroupRule_IngressSourceWithAccount_id
=== PAUSE TestAccVPCSecurityGroupRule_IngressSourceWithAccount_id
=== RUN   TestAccVPCSecurityGroupRule_Ingress_protocol
=== PAUSE TestAccVPCSecurityGroupRule_Ingress_protocol
=== RUN   TestAccVPCSecurityGroupRule_Ingress_icmpv6
=== PAUSE TestAccVPCSecurityGroupRule_Ingress_icmpv6
=== RUN   TestAccVPCSecurityGroupRule_Ingress_ipv6
=== PAUSE TestAccVPCSecurityGroupRule_Ingress_ipv6
=== RUN   TestAccVPCSecurityGroupRule_egress
=== PAUSE TestAccVPCSecurityGroupRule_egress
=== RUN   TestAccVPCSecurityGroupRule_selfReference
=== PAUSE TestAccVPCSecurityGroupRule_selfReference
=== RUN   TestAccVPCSecurityGroupRule_expectInvalidTypeError
=== PAUSE TestAccVPCSecurityGroupRule_expectInvalidTypeError
=== RUN   TestAccVPCSecurityGroupRule_expectInvalidCIDR
=== PAUSE TestAccVPCSecurityGroupRule_expectInvalidCIDR
=== RUN   TestAccVPCSecurityGroupRule_PartialMatching_basic
=== PAUSE TestAccVPCSecurityGroupRule_PartialMatching_basic
=== RUN   TestAccVPCSecurityGroupRule_PartialMatching_source
=== PAUSE TestAccVPCSecurityGroupRule_PartialMatching_source
=== RUN   TestAccVPCSecurityGroupRule_issue5310
=== PAUSE TestAccVPCSecurityGroupRule_issue5310
=== RUN   TestAccVPCSecurityGroupRule_race
=== PAUSE TestAccVPCSecurityGroupRule_race
=== RUN   TestAccVPCSecurityGroupRule_selfSource
=== PAUSE TestAccVPCSecurityGroupRule_selfSource
=== RUN   TestAccVPCSecurityGroupRule_prefixListEgress
=== PAUSE TestAccVPCSecurityGroupRule_prefixListEgress
=== RUN   TestAccVPCSecurityGroupRule_prefixListEmptyString
=== PAUSE TestAccVPCSecurityGroupRule_prefixListEmptyString
=== RUN   TestAccVPCSecurityGroupRule_ingressDescription
=== PAUSE TestAccVPCSecurityGroupRule_ingressDescription
=== RUN   TestAccVPCSecurityGroupRule_egressDescription
=== PAUSE TestAccVPCSecurityGroupRule_egressDescription
=== RUN   TestAccVPCSecurityGroupRule_IngressDescription_updates
=== PAUSE TestAccVPCSecurityGroupRule_IngressDescription_updates
=== RUN   TestAccVPCSecurityGroupRule_EgressDescription_updates
=== PAUSE TestAccVPCSecurityGroupRule_EgressDescription_updates
=== RUN   TestAccVPCSecurityGroupRule_Description_allPorts
=== PAUSE TestAccVPCSecurityGroupRule_Description_allPorts
=== RUN   TestAccVPCSecurityGroupRule_DescriptionAllPorts_nonZeroPorts
=== PAUSE TestAccVPCSecurityGroupRule_DescriptionAllPorts_nonZeroPorts
=== RUN   TestAccVPCSecurityGroupRule_MultipleRuleSearching_allProtocolCrash
=== PAUSE TestAccVPCSecurityGroupRule_MultipleRuleSearching_allProtocolCrash
=== RUN   TestAccVPCSecurityGroupRule_multiDescription
=== PAUSE TestAccVPCSecurityGroupRule_multiDescription
=== RUN   TestAccVPCSecurityGroupRule_Ingress_multipleIPv6
=== PAUSE TestAccVPCSecurityGroupRule_Ingress_multipleIPv6
=== RUN   TestAccVPCSecurityGroupRule_Ingress_multiplePrefixLists
=== PAUSE TestAccVPCSecurityGroupRule_Ingress_multiplePrefixLists
=== RUN   TestAccVPCSecurityGroupRule_Ingress_peeredVPC
=== PAUSE TestAccVPCSecurityGroupRule_Ingress_peeredVPC
=== RUN   TestAccVPCSecurityGroupRule_Ingress_ipv4AndIPv6
=== PAUSE TestAccVPCSecurityGroupRule_Ingress_ipv4AndIPv6
=== RUN   TestAccVPCSecurityGroupRule_Ingress_prefixListAndSelf
=== PAUSE TestAccVPCSecurityGroupRule_Ingress_prefixListAndSelf
=== RUN   TestAccVPCSecurityGroupRule_Ingress_prefixListAndSource
=== PAUSE TestAccVPCSecurityGroupRule_Ingress_prefixListAndSource
=== RUN   TestAccVPCSecurityGroupRule_protocolChange
=== PAUSE TestAccVPCSecurityGroupRule_protocolChange
=== CONT  TestAccVPCSecurityGroupRule_Ingress_vpc
=== CONT  TestAccVPCSecurityGroupRule_ingressDescription
--- PASS: TestAccVPCSecurityGroupRule_ingressDescription (22.71s)
=== CONT  TestAccVPCSecurityGroupRule_Ingress_multipleIPv6
--- PASS: TestAccVPCSecurityGroupRule_Ingress_vpc (22.71s)
=== CONT  TestAccVPCSecurityGroupRule_protocolChange
--- PASS: TestAccVPCSecurityGroupRule_Ingress_multipleIPv6 (26.67s)
=== CONT  TestAccVPCSecurityGroupRule_Ingress_prefixListAndSource
--- PASS: TestAccVPCSecurityGroupRule_Ingress_prefixListAndSource (32.71s)
=== CONT  TestAccVPCSecurityGroupRule_Ingress_prefixListAndSelf
--- PASS: TestAccVPCSecurityGroupRule_protocolChange (61.08s)
=== CONT  TestAccVPCSecurityGroupRule_Ingress_ipv4AndIPv6
--- PASS: TestAccVPCSecurityGroupRule_Ingress_ipv4AndIPv6 (27.32s)
=== CONT  TestAccVPCSecurityGroupRule_Ingress_peeredVPC
    acctest.go:645: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccVPCSecurityGroupRule_Ingress_peeredVPC (0.00s)
=== CONT  TestAccVPCSecurityGroupRule_Ingress_multiplePrefixLists
--- PASS: TestAccVPCSecurityGroupRule_Ingress_prefixListAndSelf (33.21s)
=== CONT  TestAccVPCSecurityGroupRule_expectInvalidCIDR
--- PASS: TestAccVPCSecurityGroupRule_expectInvalidCIDR (1.93s)
=== CONT  TestAccVPCSecurityGroupRule_prefixListEmptyString
--- PASS: TestAccVPCSecurityGroupRule_prefixListEmptyString (1.21s)
=== CONT  TestAccVPCSecurityGroupRule_prefixListEgress
--- PASS: TestAccVPCSecurityGroupRule_Ingress_multiplePrefixLists (32.78s)
=== CONT  TestAccVPCSecurityGroupRule_selfSource
--- PASS: TestAccVPCSecurityGroupRule_prefixListEgress (36.99s)
=== CONT  TestAccVPCSecurityGroupRule_race
    vpc_security_group_rule_test.go:563: Step 1/1 error: Error running apply: exit status 1

        Error: error reading EC2 VPC (vpc-0fb98da55d5243ad1) Attribute (enableDnsHostnames): couldn't find resource

          with aws_vpc.test,
          on terraform_plugin_test.tf line 2, in resource "aws_vpc" "test":
           2: resource "aws_vpc" "test" {

--- FAIL: TestAccVPCSecurityGroupRule_race (9.81s)
=== CONT  TestAccVPCSecurityGroupRule_issue5310
--- PASS: TestAccVPCSecurityGroupRule_selfSource (26.77s)
=== CONT  TestAccVPCSecurityGroupRule_PartialMatching_source
--- PASS: TestAccVPCSecurityGroupRule_issue5310 (22.47s)
=== CONT  TestAccVPCSecurityGroupRule_PartialMatching_basic
--- PASS: TestAccVPCSecurityGroupRule_PartialMatching_source (30.24s)
=== CONT  TestAccVPCSecurityGroupRule_Description_allPorts
--- PASS: TestAccVPCSecurityGroupRule_PartialMatching_basic (33.87s)
=== CONT  TestAccVPCSecurityGroupRule_multiDescription
--- PASS: TestAccVPCSecurityGroupRule_Description_allPorts (35.43s)
=== CONT  TestAccVPCSecurityGroupRule_MultipleRuleSearching_allProtocolCrash
--- PASS: TestAccVPCSecurityGroupRule_MultipleRuleSearching_allProtocolCrash (25.71s)
=== CONT  TestAccVPCSecurityGroupRule_DescriptionAllPorts_nonZeroPorts
--- PASS: TestAccVPCSecurityGroupRule_multiDescription (74.93s)
=== CONT  TestAccVPCSecurityGroupRule_selfReference
--- PASS: TestAccVPCSecurityGroupRule_DescriptionAllPorts_nonZeroPorts (35.07s)
=== CONT  TestAccVPCSecurityGroupRule_expectInvalidTypeError
--- PASS: TestAccVPCSecurityGroupRule_expectInvalidTypeError (1.19s)
=== CONT  TestAccVPCSecurityGroupRule_Ingress_protocol
--- PASS: TestAccVPCSecurityGroupRule_selfReference (26.55s)
=== CONT  TestAccVPCSecurityGroupRule_Ingress_icmpv6
--- PASS: TestAccVPCSecurityGroupRule_Ingress_protocol (26.31s)
=== CONT  TestAccVPCSecurityGroupRule_IngressSourceWithAccount_id
--- PASS: TestAccVPCSecurityGroupRule_IngressSourceWithAccount_id (23.58s)
=== CONT  TestAccVPCSecurityGroupRule_egress
--- PASS: TestAccVPCSecurityGroupRule_Ingress_icmpv6 (26.44s)
=== CONT  TestAccVPCSecurityGroupRule_IngressDescription_updates
--- PASS: TestAccVPCSecurityGroupRule_egress (21.40s)
=== CONT  TestAccVPCSecurityGroupRule_EgressDescription_updates
--- PASS: TestAccVPCSecurityGroupRule_IngressDescription_updates (33.75s)
=== CONT  TestAccVPCSecurityGroupRule_egressDescription
--- PASS: TestAccVPCSecurityGroupRule_EgressDescription_updates (34.50s)
=== CONT  TestAccVPCSecurityGroupRule_Ingress_ipv6
--- PASS: TestAccVPCSecurityGroupRule_egressDescription (21.59s)
--- PASS: TestAccVPCSecurityGroupRule_Ingress_ipv6 (25.15s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	433.715s
FAIL
make: *** [testacc] Error 1
@ewbankkit
r/aws_security_group_rule: Document 'security_group_rule_id' attribute.
0a1f813
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/elb Issues and PRs that pertain to the elb service. service/emr Issues and PRs that pertain to the emr service. service/globalaccelerator Issues and PRs that pertain to the globalaccelerator service. service/vpc Issues and PRs that pertain to the vpc service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Nov 15, 2022
@ewbankkit ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 15, 2022
@ewbankkit ewbankkit mentioned this pull request Nov 15, 2022
Closed
@ewbankkit ewbankkit merged commit e21abc5 into main Nov 16, 2022
@ewbankkit ewbankkit deleted the f-add-security-group-rule-id branch November 16, 2022 15:59
@github-actions github-actions bot added this to the v4.40.0 milestone Nov 16, 2022
github-actions bot pushed a commit that referenced this pull request Nov 16, 2022
Update CHANGELOG.md for #27828
af7eb78
@github-actions
Copy link

This functionality has been released in v4.40.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@aidanmelen aidanmelen mentioned this pull request Nov 30, 2022
Open
@posquit0 posquit0 mentioned this pull request Dec 10, 2022
Closed
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/elb Issues and PRs that pertain to the elb service. service/emr Issues and PRs that pertain to the emr service. service/globalaccelerator Issues and PRs that pertain to the globalaccelerator service. service/vpc Issues and PRs that pertain to the vpc service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.40.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ewbankkit