Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Support ECS Service Health Check Grace Period #2786

Closed
bflad opened this issue Dec 28, 2017 · 6 comments · Fixed by #2788
Closed

Feature Request: Support ECS Service Health Check Grace Period #2786

bflad opened this issue Dec 28, 2017 · 6 comments · Fixed by #2788
Labels
enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues.
Milestone

Comments

@bflad
Copy link
Member

bflad commented Dec 28, 2017

Amazon Elastic Container Service (Amazon ECS) service scheduler now allows you to define a grace period to prevent premature shutdown of newly instantiated tasks: https://aws.amazon.com/about-aws/whats-new/2017/12/amazon-ecs-adds-elb-health-check-grace-period/

Prerequisite: aws-sdk-go v.1.12.53 (already merged)

Terraform Version

terraform 0.10+
terraform-provider-aws 1.6.0

Affected Resource(s)

  • aws_ecs_service

Terraform Configuration Files

resource "aws_ecs_service" "example" {
  # new configuration
  health_check_grace_period_seconds = 300
  # existing configuration
}

Expected Behavior

HealthCheckGracePeriodSeconds integer added to CreateServiceInput/UpdateServiceInput when health_check_grace_period_seconds optionally set in Terraform configuration. It has a max value of 1800.

Actual Behavior

New feature.

References

@jen20 jen20 added enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. labels Dec 29, 2017
@rafilkmp3
Copy link

if its merged why i can use ??
i facing with
: invalid or unknown key: health_check_grace_period_seconds

@bflad
Copy link
Member Author

bflad commented Jan 9, 2018

Hi @rafilkmp3 - sorry for any confusion. This will be in version 1.7.0 of the provider, which has not been fully released yet, although it likely will be soon. You can check the code repository CHANGELOG here to see when its released: https://github.com/terraform-providers/terraform-provider-aws/blob/master/CHANGELOG.md

If you need the functionality immediately, you can grab the master branch of the source code to build and use the updated provider yourself right now.

@rafilkmp3
Copy link

rafilkmp3 commented Jan 10, 2018

I did this, but after build i don't now get a binary like terraform downloads into .terraform/plugins/linux_amd64 ,
how i can use the builded plugin ?
this is not clear enouth for me.
https://www.terraform.io/docs/plugins/basics.html#installing-a-plugin

@bflad
Copy link
Member Author

bflad commented Jan 10, 2018

After running make build the provider binary should be dropped as ${GOPATH}/bin/terraform-provider-aws, which can then be moved/copied as needed.

@bflad bflad added this to the v1.7.0 milestone Jan 12, 2018
@bflad
Copy link
Member Author

bflad commented Jan 12, 2018

This has been released in terraform-provider-aws version 1.7.0. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants