Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new resource: aws_ivschat_logging_configuration #27924

Merged
merged 8 commits into from
Nov 22, 2022

Conversation

KevinEady
Copy link
Contributor

Description

Add new resource for AWS IVS Chat Logging Configuration: aws_ivschat_logging_configuration. This PR is the first in a set to support the full AWS IVS Chat entities:

  1. Logging Configuration
  2. Room

Relations

Relates #17272

References

  1. https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/ivschat LoggingConfiguration functions and types

Output from Acceptance Testing

$ make testacc TESTS=TestAccIVSChatLoggingConfiguration_ PKG=ivschat
==> Checking that code complies with gofmt requirements...
TF_ACC=1 /Users/eakevinh/go/bin/go1.19.3 test ./internal/service/ivschat/... -v -count 1 -parallel 20 -run='TestAccIVSChatLoggingConfiguration_'  -timeout 180m
=== RUN   TestAccIVSChatLoggingConfiguration_basic_cloudwatch
=== PAUSE TestAccIVSChatLoggingConfiguration_basic_cloudwatch
=== RUN   TestAccIVSChatLoggingConfiguration_basic_firehose
=== PAUSE TestAccIVSChatLoggingConfiguration_basic_firehose
=== RUN   TestAccIVSChatLoggingConfiguration_basic_s3
=== PAUSE TestAccIVSChatLoggingConfiguration_basic_s3
=== RUN   TestAccIVSChatLoggingConfiguration_update_s3
=== PAUSE TestAccIVSChatLoggingConfiguration_update_s3
=== RUN   TestAccIVSChatLoggingConfiguration_tags
=== PAUSE TestAccIVSChatLoggingConfiguration_tags
=== RUN   TestAccIVSChatLoggingConfiguration_failure_invalidDestination
=== PAUSE TestAccIVSChatLoggingConfiguration_failure_invalidDestination
=== RUN   TestAccIVSChatLoggingConfiguration_disappears
=== PAUSE TestAccIVSChatLoggingConfiguration_disappears
=== CONT  TestAccIVSChatLoggingConfiguration_basic_cloudwatch
=== CONT  TestAccIVSChatLoggingConfiguration_tags
=== CONT  TestAccIVSChatLoggingConfiguration_basic_s3
=== CONT  TestAccIVSChatLoggingConfiguration_basic_firehose
=== CONT  TestAccIVSChatLoggingConfiguration_update_s3
=== CONT  TestAccIVSChatLoggingConfiguration_failure_invalidDestination
=== CONT  TestAccIVSChatLoggingConfiguration_disappears
--- PASS: TestAccIVSChatLoggingConfiguration_failure_invalidDestination (5.64s)
--- PASS: TestAccIVSChatLoggingConfiguration_basic_cloudwatch (38.05s)
--- PASS: TestAccIVSChatLoggingConfiguration_disappears (40.90s)
--- PASS: TestAccIVSChatLoggingConfiguration_basic_s3 (46.62s)
--- PASS: TestAccIVSChatLoggingConfiguration_update_s3 (75.48s)
--- PASS: TestAccIVSChatLoggingConfiguration_tags (99.07s)
--- PASS: TestAccIVSChatLoggingConfiguration_basic_firehose (516.39s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ivschat    519.394s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. generators Relates to code generators. provider Pertains to the provider itself, rather than any interaction with AWS. service/ivschat Issues and PRs that pertain to the ivschat service. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Nov 21, 2022
Kevin Eady added 3 commits November 21, 2022 14:43
- Use correct caps in func name
- Unordered list indentation
@KevinEady KevinEady marked this pull request as ready for review November 21, 2022 14:37
@KevinEady
Copy link
Contributor Author

This PR is ready for review. The failed job seems to be a timeout when checking out the repository. I imagine it should succeed if it is re-ran, but I don't have access to re-run failed jobs.

Copy link
Contributor Author

@KevinEady KevinEady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some comments on flatten/expandDestinationConfiguration to give some clarity on the patterns used.

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Nov 22, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccIVSChatLoggingConfiguration_' PKG=ivschat ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ivschat/... -v -count 1 -parallel 2  -run=TestAccIVSChatLoggingConfiguration_ -timeout 180m
=== RUN   TestAccIVSChatLoggingConfiguration_basic_cloudwatch
=== PAUSE TestAccIVSChatLoggingConfiguration_basic_cloudwatch
=== RUN   TestAccIVSChatLoggingConfiguration_basic_firehose
=== PAUSE TestAccIVSChatLoggingConfiguration_basic_firehose
=== RUN   TestAccIVSChatLoggingConfiguration_basic_s3
=== PAUSE TestAccIVSChatLoggingConfiguration_basic_s3
=== RUN   TestAccIVSChatLoggingConfiguration_update_s3
=== PAUSE TestAccIVSChatLoggingConfiguration_update_s3
=== RUN   TestAccIVSChatLoggingConfiguration_tags
=== PAUSE TestAccIVSChatLoggingConfiguration_tags
=== RUN   TestAccIVSChatLoggingConfiguration_failure_invalidDestination
=== PAUSE TestAccIVSChatLoggingConfiguration_failure_invalidDestination
=== RUN   TestAccIVSChatLoggingConfiguration_disappears
=== PAUSE TestAccIVSChatLoggingConfiguration_disappears
=== CONT  TestAccIVSChatLoggingConfiguration_basic_cloudwatch
=== CONT  TestAccIVSChatLoggingConfiguration_tags
--- PASS: TestAccIVSChatLoggingConfiguration_basic_cloudwatch (24.52s)
=== CONT  TestAccIVSChatLoggingConfiguration_disappears
--- PASS: TestAccIVSChatLoggingConfiguration_disappears (23.23s)
=== CONT  TestAccIVSChatLoggingConfiguration_failure_invalidDestination
--- PASS: TestAccIVSChatLoggingConfiguration_failure_invalidDestination (3.72s)
=== CONT  TestAccIVSChatLoggingConfiguration_basic_s3
--- PASS: TestAccIVSChatLoggingConfiguration_tags (63.61s)
=== CONT  TestAccIVSChatLoggingConfiguration_update_s3
--- PASS: TestAccIVSChatLoggingConfiguration_basic_s3 (26.67s)
=== CONT  TestAccIVSChatLoggingConfiguration_basic_firehose
--- PASS: TestAccIVSChatLoggingConfiguration_update_s3 (45.29s)
--- PASS: TestAccIVSChatLoggingConfiguration_basic_firehose (200.53s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ivschat	283.183s

@ewbankkit
Copy link
Contributor

@KevinEady Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit a9d69e8 into hashicorp:main Nov 22, 2022
@github-actions github-actions bot added this to the v4.41.0 milestone Nov 22, 2022
@KevinEady KevinEady deleted the f-ivschat-logging_configuration branch November 22, 2022 15:01
@github-actions
Copy link

This functionality has been released in v4.41.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. provider Pertains to the provider itself, rather than any interaction with AWS. service/ivschat Issues and PRs that pertain to the ivschat service. size/XL Managed by automation to categorize the size of a PR. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants