Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/emrserverlesss_application - add architecture argument #28027

Merged
merged 5 commits into from
Nov 28, 2022

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Nov 26, 2022

Description

Relations

Closes #27999

References

Output from Acceptance Testing

$  make testacc TESTS=TestAccEMRServerlessApplication_arch  PKG=emrserverless
--- PASS: TestAccEMRServerlessApplication_basic (99.03s)
--- PASS: TestAccEMRServerlessApplication_network (113.05s)
--- PASS: TestAccEMRServerlessApplication_disappears (117.02s)
--- PASS: TestAccEMRServerlessApplication_arch (119.54s)
--- PASS: TestAccEMRServerlessApplication_maxCapacity (120.41s)
--- PASS: TestAccEMRServerlessApplication_initialCapacity (120.55s)
--- PASS: TestAccEMRServerlessApplication_tags (141.68s)

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/emrserverless Issues and PRs that pertain to the emrserverless service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 26, 2022
@DrFaust92 DrFaust92 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 26, 2022
@DrFaust92 DrFaust92 marked this pull request as ready for review November 26, 2022 22:22
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccEMRServerlessApplication_' PKG=emrserverless ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/emrserverless/... -v -count 1 -parallel 2  -run=TestAccEMRServerlessApplication_ -timeout 180m
=== RUN   TestAccEMRServerlessApplication_basic
=== PAUSE TestAccEMRServerlessApplication_basic
=== RUN   TestAccEMRServerlessApplication_arch
=== PAUSE TestAccEMRServerlessApplication_arch
=== RUN   TestAccEMRServerlessApplication_initialCapacity
=== PAUSE TestAccEMRServerlessApplication_initialCapacity
=== RUN   TestAccEMRServerlessApplication_maxCapacity
=== PAUSE TestAccEMRServerlessApplication_maxCapacity
=== RUN   TestAccEMRServerlessApplication_network
=== PAUSE TestAccEMRServerlessApplication_network
=== RUN   TestAccEMRServerlessApplication_disappears
=== PAUSE TestAccEMRServerlessApplication_disappears
=== RUN   TestAccEMRServerlessApplication_tags
=== PAUSE TestAccEMRServerlessApplication_tags
=== CONT  TestAccEMRServerlessApplication_basic
=== CONT  TestAccEMRServerlessApplication_network
--- PASS: TestAccEMRServerlessApplication_basic (81.03s)
=== CONT  TestAccEMRServerlessApplication_initialCapacity
--- PASS: TestAccEMRServerlessApplication_network (89.77s)
=== CONT  TestAccEMRServerlessApplication_maxCapacity
--- PASS: TestAccEMRServerlessApplication_initialCapacity (92.16s)
=== CONT  TestAccEMRServerlessApplication_tags
--- PASS: TestAccEMRServerlessApplication_maxCapacity (91.96s)
=== CONT  TestAccEMRServerlessApplication_disappears
--- PASS: TestAccEMRServerlessApplication_tags (104.94s)
=== CONT  TestAccEMRServerlessApplication_arch
--- PASS: TestAccEMRServerlessApplication_disappears (104.07s)
--- PASS: TestAccEMRServerlessApplication_arch (91.41s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/emrserverless	374.351s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 7a6e850 into hashicorp:main Nov 28, 2022
@github-actions github-actions bot added this to the v4.42.0 milestone Nov 28, 2022
@github-actions
Copy link

This functionality has been released in v4.42.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 29, 2022
@DrFaust92 DrFaust92 deleted the emr-serverless-arch branch December 29, 2022 12:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/emrserverless Issues and PRs that pertain to the emrserverless service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add architecture option to aws_emrserverless_application
2 participants