Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Resource]: Amazon SES account VDM attributes #28249

Closed
atsushi-ishibashi opened this issue Dec 8, 2022 · 6 comments · Fixed by #28812
Closed

[New Resource]: Amazon SES account VDM attributes #28249

atsushi-ishibashi opened this issue Dec 8, 2022 · 6 comments · Fixed by #28812
Labels
new-resource Introduces a new resource. service/sesv2 Issues and PRs that pertain to the sesv2 service.
Milestone

Comments

@atsushi-ishibashi
Copy link
Contributor

atsushi-ishibashi commented Dec 8, 2022

Description

Amazon SES account VDM attributes
https://docs.aws.amazon.com/ses/latest/dg/vdm.html

Virtual Deliverability Manager is an Amazon SES feature that helps you enhance email deliverability, like increasing inbox deliverability and email conversions, by providing insights into your sending and delivery data, and giving advice on how to fix the issues that are negatively affecting your delivery success rate and reputation.

Requested Resource(s) and/or Data Source(s)

  • aws_sesv2_account_vdm_attributes

Potential Terraform Configuration

resource "aws_sesv2_account_vdm_attributes" "main" {
  enabled = "ENABLED|DISABLED"
  dashboard {
    engagement_metrics = "ENABLED|DISABLED"
  }
  guardian {
    optimized_shared_delivery = "ENABLED|DISABLED"
  }
}

References

https://docs.aws.amazon.com/ses/latest/APIReference-V2/API_PutAccountVdmAttributes.html

Would you like to implement a fix?

Yes

@atsushi-ishibashi atsushi-ishibashi added the needs-triage Waiting for first response or review from a maintainer. label Dec 8, 2022
@github-actions
Copy link

github-actions bot commented Dec 8, 2022

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/sesv2 Issues and PRs that pertain to the sesv2 service. label Dec 8, 2022
@atsushi-ishibashi
Copy link
Contributor Author

I found #26796 which plans to aggregate some configs in one tf-resource.
Should I add VDM into aws_sesv2_configuration_set?
But I prefer to avoid to abstract and aggregate AWS APIs on terraform provider layer so I'd like to create this feature independently.

@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 8, 2022
@kamilturek
Copy link
Collaborator

Hey @atsushi-ishibashi, thank you for looking into this!

When it comes to configuration sets, given that CreateConfigurationSet accepts VDM options, I think we should follow the approach and add this argument to the aws_sesv2_configuration_set.

But since it can be also specified on the account level using PutAccountVdmAttributes, I think we could also have the aws_sesv2_account_vdm_attributes as you proposed 🙂

@atsushi-ishibashi
Copy link
Contributor Author

atsushi-ishibashi commented Jan 10, 2023

@kamilturek
I don't know this API. So I agree that aws_sesv2_configuration_set contains VDM options👍 Thanks!
https://docs.aws.amazon.com/ses/latest/APIReference-V2/API_CreateConfigurationSet.html

I won't create aws_sesv2_account_vdm_attributes so please close this issue via 28812

@github-actions github-actions bot added this to the v4.58.0 milestone Mar 7, 2023
@github-actions
Copy link

This functionality has been released in v4.58.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-resource Introduces a new resource. service/sesv2 Issues and PRs that pertain to the sesv2 service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants