Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_eks_addon with custom configuration_values #28295

Merged
merged 10 commits into from
Dec 15, 2022

Conversation

vara-bonthu
Copy link
Contributor

@vara-bonthu vara-bonthu commented Dec 12, 2022

Description

AWS EKS team recently launched a new feature to pass the custom configuration_values for EKS managed add-ons. This feature allows users to pass the configuration_values while creating or updating the EKS addon.

EKS API config configurationValues
createAddon -> https://docs.aws.amazon.com/eks/latest/APIReference/API_CreateAddon.html
updateAddon -> https://docs.aws.amazon.com/eks/latest/APIReference/API_UpdateAddon.html

Check the output of the below API
describeAddon -> https://docs.aws.amazon.com/eks/latest/APIReference/API_DescribeAddon.html

This implements and solves #28287

Relations

Closes #28287.
Closes #28374.

References

Output from Acceptance Testing

➜  terraform-provider-aws git:(f-eks_addon-customconfig) ✗ make testacc TESTARGS='-run=TestAccEKSAddon_configurationValues' PKG=eks
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/eks/... -v -count 1 -parallel 20  -run=TestAccEKSAddon_configurationValues -timeout 180m
=== RUN   TestAccEKSAddon_configurationValues
=== PAUSE TestAccEKSAddon_configurationValues
=== CONT  TestAccEKSAddon_configurationValues
--- PASS: TestAccEKSAddon_configurationValues (836.79s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/eks        859.155s

Data Source test results

➜  terraform-provider-aws git:(f-eks_addon-customconfig) ✗ make testacc TESTARGS='-run=TestAccEKSAddonDataSource_configurationValues' PKG=eks
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/eks/... -v -count 1 -parallel 20  -run=TestAccEKSAddonDataSource_configurationValues -timeout 180m
=== RUN   TestAccEKSAddonDataSource_configurationValues
=== PAUSE TestAccEKSAddonDataSource_configurationValues
=== CONT  TestAccEKSAddonDataSource_configurationValues
--- PASS: TestAccEKSAddonDataSource_configurationValues (724.36s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/eks        746.529s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/eks Issues and PRs that pertain to the eks service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 12, 2022
Copy link
Collaborator

@AdamTylerLynch AdamTylerLynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments.

internal/service/eks/addon_data_source.go Show resolved Hide resolved
internal/service/eks/addon_data_source.go Show resolved Hide resolved
internal/service/eks/addon_test.go Show resolved Hide resolved
internal/service/eks/addon_test.go Show resolved Hide resolved
internal/service/eks/addon_test.go Outdated Show resolved Hide resolved
internal/service/eks/addon_test.go Outdated Show resolved Hide resolved
@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 13, 2022
@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Dec 15, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccEKSAddon_configurationValues\|TestAccEKSAddon_basic\|TestAccEKSAddonDataSource_' PKG=eks ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/eks/... -v -count 1 -parallel 2  -run=TestAccEKSAddon_configurationValues\|TestAccEKSAddon_basic\|TestAccEKSAddonDataSource_ -timeout 180m
=== RUN   TestAccEKSAddonDataSource_basic
=== PAUSE TestAccEKSAddonDataSource_basic
=== RUN   TestAccEKSAddonDataSource_configurationValues
=== PAUSE TestAccEKSAddonDataSource_configurationValues
=== RUN   TestAccEKSAddon_basic
=== PAUSE TestAccEKSAddon_basic
=== RUN   TestAccEKSAddon_configurationValues
=== PAUSE TestAccEKSAddon_configurationValues
=== CONT  TestAccEKSAddonDataSource_basic
=== CONT  TestAccEKSAddon_basic
--- PASS: TestAccEKSAddon_basic (645.38s)
=== CONT  TestAccEKSAddonDataSource_configurationValues
--- PASS: TestAccEKSAddonDataSource_basic (720.78s)
=== CONT  TestAccEKSAddon_configurationValues
--- PASS: TestAccEKSAddonDataSource_configurationValues (747.90s)
--- PASS: TestAccEKSAddon_configurationValues (714.50s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/eks	1440.696s

@ewbankkit ewbankkit merged commit 490a482 into hashicorp:main Dec 15, 2022
@github-actions github-actions bot added this to the v4.47.0 milestone Dec 15, 2022
@ewbankkit
Copy link
Contributor

@vara-bonthu Thanks for the contribution 🎉 👏.

@github-actions
Copy link

This functionality has been released in v4.47.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/eks Issues and PRs that pertain to the eks service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
3 participants