Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: aws_db_instance lacks Listener_Endpoint attribute #28389

Closed
ghost opened this issue Dec 16, 2022 · 3 comments · Fixed by #28434
Closed

[Enhancement]: aws_db_instance lacks Listener_Endpoint attribute #28389

ghost opened this issue Dec 16, 2022 · 3 comments · Fixed by #28434
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service.
Milestone

Comments

@ghost
Copy link

ghost commented Dec 16, 2022

Description

The aws_db_instance should have a Listener_Endpoint (or similar) attribute when using MS SQL Server with multi_az set to true. This exposes the Always On availability group listener endpoint when using multi az mode on SQL Server 2016 or later.

Affected Resource(s) and/or Data Source(s)

aws_db_instance

Potential Terraform Configuration

resource "aws_db_instance" "testmssql" {
  identifier = "test-mssql"

  vpc_security_group_ids = var.vpc_security_group_ids
  publicly_accessible    = false

  engine         = "sqlserver-ee"
  engine_version = "15.00.4236.7.v1"
  license_model  = "license-included"

  username = "test"
  password = "test"

  deletion_protection = false
  instance_class      = "db.t3.xlarge"
  multi_az            = true
}

resource "aws_secretsmanager_secret" "test_password" {
  name = "test_password"
}

resource "aws_secretsmanager_secret_version" "test_password" {
  secret_id = aws_secretsmanager_secret.test_password.id
  secret_string = jsonencode({
    "endpoint" = aws_db_instance.testmssql.listener_endpoint 
  })
}

References

https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/USER_SQLServerMultiAZ.html#USER_SQLServerMultiAZ.Recommendations

Would you like to implement a fix?

No

@ghost ghost added enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels Dec 16, 2022
@github-actions github-actions bot added service/rds Issues and PRs that pertain to the rds service. service/secretsmanager Issues and PRs that pertain to the secretsmanager service. labels Dec 16, 2022
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@DrFaust92 DrFaust92 removed needs-triage Waiting for first response or review from a maintainer. service/secretsmanager Issues and PRs that pertain to the secretsmanager service. labels Dec 17, 2022
@github-actions github-actions bot added this to the v4.58.0 milestone Mar 7, 2023
@github-actions
Copy link

This functionality has been released in v4.58.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant