Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs]: import aws_storagegateway_upload_buffer example not correct #28425

Open
MartinBaas-Tivian opened this issue Dec 16, 2022 · 3 comments
Open
Labels
documentation Introduces or discusses updates to documentation.

Comments

@MartinBaas-Tivian
Copy link

Documentation Link

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/storagegateway_upload_buffer

Description

The import example is not correct anymore. Disk IDs changed from path-by-id to unique hexadecimal IDs

e.g.: pci-0000:03:00.0-scsi-0:0:0:0 -> a36d4361-3578-76ea-78ae-12a4f41eace6

References

No response

Would you like to implement a fix?

None

@MartinBaas-Tivian MartinBaas-Tivian added documentation Introduces or discusses updates to documentation. needs-triage Waiting for first response or review from a maintainer. labels Dec 16, 2022
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@justinretzolk
Copy link
Member

Hey @MartinBaas-Tivian 👋 Thank you for taking the time to raise this! I took a look around, more specifically at the aws_storagegateway_local_disk data source, since that's where the documentation shows grabbing the disk_id from. That data source uses the ListLocalDisks function from the AWS Go SDK to read information about the disks. Looking at the API reference for the underlying API call, it still shows disk IDs as being in the current format.

With that said, are you seeing differing behavior that led you to initially filing this?

@justinretzolk justinretzolk added waiting-response Maintainers are waiting on response from community or contributor. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 27, 2023
@github-actions github-actions bot removed the waiting-response Maintainers are waiting on response from community or contributor. label Jun 27, 2023
@MartinBaas-Tivian
Copy link
Author

Hi @justinretzolk :)
First: Thank you for looking into this. To be honest, I totally forgot about this issue and I first had to look at what I was doing, when it was raised ^^'

Yes, I vaguely remember seeing a different behavior than the one in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation.
Projects
None yet
Development

No branches or pull requests

2 participants