Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Add support for credentials SecretArn attribute in quicksight_data_source #28484

Open
grzegorzb1990 opened this issue Dec 20, 2022 · 3 comments · May be fixed by #29034
Open

[Enhancement]: Add support for credentials SecretArn attribute in quicksight_data_source #28484

grzegorzb1990 opened this issue Dec 20, 2022 · 3 comments · May be fixed by #29034
Labels
enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/quicksight Issues and PRs that pertain to the quicksight service.

Comments

@grzegorzb1990
Copy link

Description

According to the AWS API documentation, it is possible to create a new data source, using credentials stored in Secret Manager . This way I would not have to store credentials in plain text in the terraform state.
image

Affected Resource(s) and/or Data Source(s)

quicksight_data_source

Potential Terraform Configuration

resource "aws_quicksight_data_source" "snowflake" {
  data_source_id = "snowflake"
  name           = "SNOWFLAKE"

  type = "SNOWFLAKE"

  parameters {
    snowflake {
      database  = "SNOWFLAKE"
      host      = "snowflakecomputing.com"
      warehouse = "SNOWFLAKE_WH"
    }
  }

  credentials {
    secret_arn = "arn:aws:secretsmanager:us-west-2:123456789012:secret:my-path/my-secret-name-1a2b3c"
  }
}

References

https://docs.aws.amazon.com/quicksight/latest/APIReference/API_CreateDataSource.html
https://docs.aws.amazon.com/quicksight/latest/APIReference/API_DataSourceCredentials.html#QS-Type-DataSourceCredentials-SecretArn

Would you like to implement a fix?

No

@grzegorzb1990 grzegorzb1990 added enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels Dec 20, 2022
@github-actions github-actions bot added the service/quicksight Issues and PRs that pertain to the quicksight service. label Dec 20, 2022
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@justinretzolk justinretzolk added good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 19, 2023
@alfredgamulo
Copy link

There's a PR for this. Can it be reviewed, please?

@shahriteshj
Copy link

@justinretzolk : Who can help review this PR or is there anything pending because of which PR is not being reviewed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/quicksight Issues and PRs that pertain to the quicksight service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants