Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_gateway_integration: connection_type shows drift #29016

Merged
merged 6 commits into from
Jan 20, 2023

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Jan 20, 2023

Description

Fix regression with aws_gateway_integration.connection_type.

Relations

Closes #28997.
Relates #16682.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccAPIGatewayIntegration_\|TestAccAPIGatewayDeployment_' PKG=apigateway ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apigateway/... -v -count 1 -parallel 3  -run=TestAccAPIGatewayIntegration_\|TestAccAPIGatewayDeployment_ -timeout 180m
=== RUN   TestAccAPIGatewayDeployment_basic
=== PAUSE TestAccAPIGatewayDeployment_basic
=== RUN   TestAccAPIGatewayDeployment_Disappears_restAPI
=== PAUSE TestAccAPIGatewayDeployment_Disappears_restAPI
=== RUN   TestAccAPIGatewayDeployment_triggers
=== PAUSE TestAccAPIGatewayDeployment_triggers
=== RUN   TestAccAPIGatewayDeployment_description
=== PAUSE TestAccAPIGatewayDeployment_description
=== RUN   TestAccAPIGatewayDeployment_stageDescription
=== PAUSE TestAccAPIGatewayDeployment_stageDescription
=== RUN   TestAccAPIGatewayDeployment_stageName
=== PAUSE TestAccAPIGatewayDeployment_stageName
=== RUN   TestAccAPIGatewayDeployment_StageName_emptyString
=== PAUSE TestAccAPIGatewayDeployment_StageName_emptyString
=== RUN   TestAccAPIGatewayDeployment_variables
=== PAUSE TestAccAPIGatewayDeployment_variables
=== RUN   TestAccAPIGatewayDeployment_conflictingConnectionType
=== PAUSE TestAccAPIGatewayDeployment_conflictingConnectionType
=== RUN   TestAccAPIGatewayIntegration_basic
=== PAUSE TestAccAPIGatewayIntegration_basic
=== RUN   TestAccAPIGatewayIntegration_contentHandling
=== PAUSE TestAccAPIGatewayIntegration_contentHandling
=== RUN   TestAccAPIGatewayIntegration_CacheKey_parameters
=== PAUSE TestAccAPIGatewayIntegration_CacheKey_parameters
=== RUN   TestAccAPIGatewayIntegration_integrationType
=== PAUSE TestAccAPIGatewayIntegration_integrationType
=== RUN   TestAccAPIGatewayIntegration_TLS_insecureSkipVerification
=== PAUSE TestAccAPIGatewayIntegration_TLS_insecureSkipVerification
=== RUN   TestAccAPIGatewayIntegration_disappears
=== PAUSE TestAccAPIGatewayIntegration_disappears
=== CONT  TestAccAPIGatewayDeployment_basic
=== CONT  TestAccAPIGatewayDeployment_conflictingConnectionType
=== CONT  TestAccAPIGatewayDeployment_stageDescription
--- PASS: TestAccAPIGatewayDeployment_stageDescription (25.39s)
=== CONT  TestAccAPIGatewayIntegration_disappears
--- PASS: TestAccAPIGatewayIntegration_disappears (34.92s)
=== CONT  TestAccAPIGatewayIntegration_TLS_insecureSkipVerification
--- PASS: TestAccAPIGatewayIntegration_TLS_insecureSkipVerification (30.12s)
=== CONT  TestAccAPIGatewayIntegration_integrationType
--- PASS: TestAccAPIGatewayDeployment_conflictingConnectionType (130.15s)
=== CONT  TestAccAPIGatewayIntegration_CacheKey_parameters
--- PASS: TestAccAPIGatewayDeployment_basic (201.56s)
=== CONT  TestAccAPIGatewayIntegration_contentHandling
--- PASS: TestAccAPIGatewayIntegration_contentHandling (42.75s)
=== CONT  TestAccAPIGatewayIntegration_basic
--- PASS: TestAccAPIGatewayIntegration_basic (65.65s)
=== CONT  TestAccAPIGatewayDeployment_triggers
--- PASS: TestAccAPIGatewayDeployment_triggers (53.85s)
=== CONT  TestAccAPIGatewayDeployment_description
--- PASS: TestAccAPIGatewayDeployment_description (38.43s)
=== CONT  TestAccAPIGatewayDeployment_Disappears_restAPI
--- PASS: TestAccAPIGatewayDeployment_Disappears_restAPI (42.03s)
=== CONT  TestAccAPIGatewayDeployment_StageName_emptyString
--- PASS: TestAccAPIGatewayDeployment_StageName_emptyString (28.27s)
=== CONT  TestAccAPIGatewayDeployment_variables
--- PASS: TestAccAPIGatewayDeployment_variables (44.37s)
=== CONT  TestAccAPIGatewayDeployment_stageName
--- PASS: TestAccAPIGatewayDeployment_stageName (75.43s)
--- PASS: TestAccAPIGatewayIntegration_CacheKey_parameters (601.21s)
--- PASS: TestAccAPIGatewayIntegration_integrationType (667.96s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apigateway	767.663s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/apigateway Issues and PRs that pertain to the apigateway service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/L Managed by automation to categorize the size of a PR. labels Jan 20, 2023
@ewbankkit ewbankkit changed the title B aws api gateway integration.connection type r/aws_gateway_integration: connection_type shows drift Jan 20, 2023
@ewbankkit ewbankkit added the bug Addresses a defect in current functionality. label Jan 20, 2023
@ewbankkit ewbankkit merged commit e686a1e into main Jan 20, 2023
@ewbankkit ewbankkit deleted the b-aws_api_gateway_integration.connection_type branch January 20, 2023 19:13
@github-actions github-actions bot added this to the v4.52.0 milestone Jan 20, 2023
@github-actions
Copy link

This functionality has been released in v4.52.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/apigateway Issues and PRs that pertain to the apigateway service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
1 participant