Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Data Source: aws_redshiftserverless_workgroup #29208

Conversation

bradsheppard
Copy link
Contributor

Description

New Data Source for aws_redshiftserverless_workgroup.

Relations

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccRedshiftServerlessWorkgroupDataSource PKG=redshiftserverless
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/redshiftserverless/... -v -count 1 -parallel 20 -run='TestAccRedshiftServerlessWorkgroupDataSource'  -timeout 180m
=== RUN   TestAccRedshiftServerlessWorkgroupDataSource_basic
=== PAUSE TestAccRedshiftServerlessWorkgroupDataSource_basic
=== CONT  TestAccRedshiftServerlessWorkgroupDataSource_basic
--- PASS: TestAccRedshiftServerlessWorkgroupDataSource_basic (552.32s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/redshiftserverless	552.406s

...

@github-actions
Copy link

github-actions bot commented Feb 2, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/redshiftserverless Issues and PRs that pertain to the redshiftserverless service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 2, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @bradsheppard 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 2, 2023
@bradsheppard bradsheppard marked this pull request as ready for review February 3, 2023 01:30
Copy link
Collaborator

@DrFaust92 DrFaust92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor issue, otherwise LGTM

@github-actions github-actions bot added generators Relates to code generators. and removed provider Pertains to the provider itself, rather than any interaction with AWS. labels Mar 17, 2023
@bradsheppard
Copy link
Contributor Author

@DrFaust92 Comments addressed! Also fixed merged conflicts, and switched to the SDKDataSource annotation, based on recent changes.

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRedshiftServerlessWorkgroupDataSource_' PKG=redshiftserverless
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/redshiftserverless/... -v -count 1 -parallel 20  -run=TestAccRedshiftServerlessWorkgroupDataSource_ -timeout 180m
=== RUN   TestAccRedshiftServerlessWorkgroupDataSource_basic
=== PAUSE TestAccRedshiftServerlessWorkgroupDataSource_basic
=== CONT  TestAccRedshiftServerlessWorkgroupDataSource_basic
--- PASS: TestAccRedshiftServerlessWorkgroupDataSource_basic (728.21s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/redshiftserverless	733.574s

@ewbankkit
Copy link
Contributor

@bradsheppard Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 3b6ff57 into hashicorp:main Apr 19, 2023
45 checks passed
@github-actions github-actions bot added this to the v4.64.0 milestone Apr 19, 2023
@github-actions
Copy link

This functionality has been released in v4.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-data-source Introduces a new data source. service/redshiftserverless Issues and PRs that pertain to the redshiftserverless service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants