Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Add ScaleInProtectedInstances on InstanceRefresh preferences #29827

Closed
Billaguana opened this issue Mar 7, 2023 · 3 comments · Fixed by #33310
Closed

[Enhancement]: Add ScaleInProtectedInstances on InstanceRefresh preferences #29827

Billaguana opened this issue Mar 7, 2023 · 3 comments · Fixed by #33310
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/autoscaling Issues and PRs that pertain to the autoscaling service.
Milestone

Comments

@Billaguana
Copy link

Description

Both through the CLI and through the portal, you can initiate an Instance Refresh with a preference for ScaleInProtectedInstances. This is especially useful when you want ECS managed scaling instances to refresh on launch template change. Adding this under the existing preferences block would be great.

Affected Resource(s) and/or Data Source(s)

No response

Potential Terraform Configuration

resource "aws_autoscaling_group" "asgs" {
  ...
  protect_from_scale_in = true

  instance_refresh {
    strategy = "Rolling"
    preferences {
      checkpoint_delay       = 600
      checkpoint_percentages = [50, 100]
      instance_warmup        = 300
      min_healthy_percentage = 50
      scale_in_protected_instances = {"Refresh"|"Ignore"|"Wait"}
    }
  }

  lifecycle {
    ignore_changes = [desired_capacity]
  }
}

References

https://docs.aws.amazon.com/cli/latest/reference/autoscaling/start-instance-refresh.html

Would you like to implement a fix?

No

@Billaguana Billaguana added enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels Mar 7, 2023
@github-actions
Copy link

github-actions bot commented Mar 7, 2023

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/autoscaling Issues and PRs that pertain to the autoscaling service. label Mar 7, 2023
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Mar 7, 2023
@github-actions github-actions bot added this to the v5.16.0 milestone Sep 5, 2023
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

This functionality has been released in v5.16.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Oct 8, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/autoscaling Issues and PRs that pertain to the autoscaling service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants