Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disable cross zone load balancing option to target group #29920

Merged

Conversation

teru01
Copy link
Contributor

@teru01 teru01 commented Mar 11, 2023

Description

add load_balancing_cross_zone_enabled option to aws_lb_target_group

Relations

Closes #28041

References

Output from Acceptance Testing

  • resource
$ make testacc TESTS=TestAccELBV2TargetGroup_ALBAlias_updateLoadBalancingCrossZoneEnabled PKG=elbv2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elbv2/... -v -count 1 -parallel 20 -run='TestAccELBV2TargetGroup_ALBAlias_updateLoadBalancingCrossZoneEnabled'  -timeout 180m
=== RUN   TestAccELBV2TargetGroup_ALBAlias_updateLoadBalancingCrossZoneEnabled
=== PAUSE TestAccELBV2TargetGroup_ALBAlias_updateLoadBalancingCrossZoneEnabled
=== CONT  TestAccELBV2TargetGroup_ALBAlias_updateLoadBalancingCrossZoneEnabled
--- PASS: TestAccELBV2TargetGroup_ALBAlias_updateLoadBalancingCrossZoneEnabled (82.35s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elbv2      86.437s

...
  • data source
make testacc TESTS=TestAccELBV2TargetGroupDataSource PKG=elbv2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elbv2/... -v -count 1 -parallel 20 -run='TestAccELBV2TargetGroupDataSource'  -timeout 180m
=== RUN   TestAccELBV2TargetGroupDataSource_basic
=== PAUSE TestAccELBV2TargetGroupDataSource_basic
=== RUN   TestAccELBV2TargetGroupDataSource_appCookie
=== PAUSE TestAccELBV2TargetGroupDataSource_appCookie
=== RUN   TestAccELBV2TargetGroupDataSource_backwardsCompatibility
=== PAUSE TestAccELBV2TargetGroupDataSource_backwardsCompatibility
=== RUN   TestAccELBV2TargetGroupDataSource_tags
=== PAUSE TestAccELBV2TargetGroupDataSource_tags
=== CONT  TestAccELBV2TargetGroupDataSource_basic
=== CONT  TestAccELBV2TargetGroupDataSource_backwardsCompatibility
=== CONT  TestAccELBV2TargetGroupDataSource_appCookie
=== CONT  TestAccELBV2TargetGroupDataSource_tags
--- PASS: TestAccELBV2TargetGroupDataSource_tags (37.69s)
--- PASS: TestAccELBV2TargetGroupDataSource_appCookie (172.77s)
--- PASS: TestAccELBV2TargetGroupDataSource_backwardsCompatibility (180.41s)
--- PASS: TestAccELBV2TargetGroupDataSource_basic (183.54s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elbv2      186.737s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. service/elbv2 Issues and PRs that pertain to the elbv2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Mar 11, 2023
@teru01 teru01 changed the title Target group cross zone load balancing Add disable cross zone load balancing option to target group Mar 11, 2023
@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 14, 2023
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. and removed size/M Managed by automation to categorize the size of a PR. labels Mar 14, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccELBV2TargetGroup_Stickiness_updateAppEnabled\|TestAccELBV2TargetGroupDataSource_basic\|TestAccELBV2TargetGroupDataSource_tags\|TestAccELBV2TargetGroup_ALBAlias_updateLoadBalancingCrossZoneEnabled\|TestAccELBV2TargetGroup_ProtocolVersion_basic' PKG=elbv2 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elbv2/... -v -count 1 -parallel 3  -run=TestAccELBV2TargetGroup_Stickiness_updateAppEnabled\|TestAccELBV2TargetGroupDataSource_basic\|TestAccELBV2TargetGroupDataSource_tags\|TestAccELBV2TargetGroup_ALBAlias_updateLoadBalancingCrossZoneEnabled\|TestAccELBV2TargetGroup_ProtocolVersion_basic -timeout 180m
=== RUN   TestAccELBV2TargetGroupDataSource_basic
=== PAUSE TestAccELBV2TargetGroupDataSource_basic
=== RUN   TestAccELBV2TargetGroupDataSource_tags
=== PAUSE TestAccELBV2TargetGroupDataSource_tags
=== RUN   TestAccELBV2TargetGroup_ProtocolVersion_basic
=== PAUSE TestAccELBV2TargetGroup_ProtocolVersion_basic
=== RUN   TestAccELBV2TargetGroup_Stickiness_updateAppEnabled
=== PAUSE TestAccELBV2TargetGroup_Stickiness_updateAppEnabled
=== RUN   TestAccELBV2TargetGroup_ALBAlias_updateLoadBalancingCrossZoneEnabled
=== PAUSE TestAccELBV2TargetGroup_ALBAlias_updateLoadBalancingCrossZoneEnabled
=== CONT  TestAccELBV2TargetGroupDataSource_basic
=== CONT  TestAccELBV2TargetGroup_Stickiness_updateAppEnabled
=== CONT  TestAccELBV2TargetGroup_ALBAlias_updateLoadBalancingCrossZoneEnabled
--- PASS: TestAccELBV2TargetGroup_Stickiness_updateAppEnabled (50.48s)
=== CONT  TestAccELBV2TargetGroup_ProtocolVersion_basic
--- PASS: TestAccELBV2TargetGroup_ALBAlias_updateLoadBalancingCrossZoneEnabled (50.48s)
=== CONT  TestAccELBV2TargetGroupDataSource_tags
--- PASS: TestAccELBV2TargetGroupDataSource_tags (18.44s)
--- PASS: TestAccELBV2TargetGroup_ProtocolVersion_basic (35.06s)
--- PASS: TestAccELBV2TargetGroupDataSource_basic (169.01s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	174.628s

@ewbankkit
Copy link
Contributor

@teru01 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit force-pushed the target-group-cross-zone-load-balancing branch from 6f81efa to 26940ab Compare March 14, 2023 15:40
@ewbankkit ewbankkit merged commit 6c5e3d0 into hashicorp:main Mar 14, 2023
46 checks passed
@github-actions github-actions bot added this to the v4.59.0 milestone Mar 14, 2023
@github-actions
Copy link

This functionality has been released in v4.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/elbv2 Issues and PRs that pertain to the elbv2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Disable Cross Zone Load Balancing for Application Load Balancer
2 participants