r/aws_ecr_repository: handle err, nil output on read

[jar-b]

Description

Fix to properly handle errors that aren't ResourceNotFound and nil output values.

Relations

Closes #30068

Output from Acceptance Testing

$ make testacc PKG=ecr TESTS=TestAccECRRepository_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecr/... -v -count 1 -parallel 20 -run='TestAccECRRepository_'  -timeout 180m
=== RUN   TestAccECRRepository_basic
=== PAUSE TestAccECRRepository_basic
=== RUN   TestAccECRRepository_disappears
=== PAUSE TestAccECRRepository_disappears
=== RUN   TestAccECRRepository_tags
=== PAUSE TestAccECRRepository_tags
=== RUN   TestAccECRRepository_immutability
=== PAUSE TestAccECRRepository_immutability
=== RUN   TestAccECRRepository_Image_scanning
=== PAUSE TestAccECRRepository_Image_scanning
=== RUN   TestAccECRRepository_Encryption_kms
=== PAUSE TestAccECRRepository_Encryption_kms
=== RUN   TestAccECRRepository_Encryption_aes256
=== PAUSE TestAccECRRepository_Encryption_aes256
=== CONT  TestAccECRRepository_basic
=== CONT  TestAccECRRepository_Image_scanning
=== CONT  TestAccECRRepository_Encryption_aes256
=== CONT  TestAccECRRepository_Encryption_kms
=== CONT  TestAccECRRepository_tags
=== CONT  TestAccECRRepository_disappears
=== CONT  TestAccECRRepository_immutability
--- PASS: TestAccECRRepository_disappears (26.36s)
--- PASS: TestAccECRRepository_basic (34.35s)
--- PASS: TestAccECRRepository_immutability (34.42s)
--- PASS: TestAccECRRepository_Encryption_kms (48.77s)
--- PASS: TestAccECRRepository_Encryption_aes256 (49.34s)
--- PASS: TestAccECRRepository_tags (53.78s)
--- PASS: TestAccECRRepository_Image_scanning (56.39s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ecr        59.599s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

Shouldn't be necessary as FindRepository already does the nil check.

[jar-b]

In theory the added err check should prevent this nil check from ever executing, but since we do an unchecked type assertion immediately following (which caused the reported panic) it felt reasonable to add for absolute safety.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccECRRepository_' PKG=ecr ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecr/... -v -count 1 -parallel 2  -run=TestAccECRRepository_ -timeout 180m
=== RUN   TestAccECRRepository_basic
=== PAUSE TestAccECRRepository_basic
=== RUN   TestAccECRRepository_disappears
=== PAUSE TestAccECRRepository_disappears
=== RUN   TestAccECRRepository_tags
=== PAUSE TestAccECRRepository_tags
=== RUN   TestAccECRRepository_immutability
=== PAUSE TestAccECRRepository_immutability
=== RUN   TestAccECRRepository_Image_scanning
=== PAUSE TestAccECRRepository_Image_scanning
=== RUN   TestAccECRRepository_Encryption_kms
=== PAUSE TestAccECRRepository_Encryption_kms
=== RUN   TestAccECRRepository_Encryption_aes256
=== PAUSE TestAccECRRepository_Encryption_aes256
=== CONT  TestAccECRRepository_basic
=== CONT  TestAccECRRepository_Image_scanning
--- PASS: TestAccECRRepository_basic (19.42s)
=== CONT  TestAccECRRepository_tags
--- PASS: TestAccECRRepository_Image_scanning (45.75s)
=== CONT  TestAccECRRepository_immutability
--- PASS: TestAccECRRepository_tags (40.29s)
=== CONT  TestAccECRRepository_Encryption_aes256
--- PASS: TestAccECRRepository_immutability (17.03s)
=== CONT  TestAccECRRepository_Encryption_kms
--- PASS: TestAccECRRepository_Encryption_aes256 (43.93s)
=== CONT  TestAccECRRepository_disappears
--- PASS: TestAccECRRepository_Encryption_kms (42.76s)
--- PASS: TestAccECRRepository_disappears (13.41s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecr	123.098s

[github-actions]

This functionality has been released in v4.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.