Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds placement_group_config block to aws_emr_cluster resource #30121

Conversation

gcardonag
Copy link
Contributor

Description

This introduces the ability to deploy EMR master nodes in an EC2 Placement Group: https://docs.aws.amazon.com/emr/latest/ManagementGuide/emr-plan-ha-placementgroup.html

This is a reopening of #24494, which updates the tests to match the latest test patterns.

Relations

Relates #24494
Closes #29665

References

N/A

Output from Acceptance Testing

$ make testacc PKG=emr TESTS=TestAccEMRCluster_PlacementGroupConfigs
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/emr/... -v -count 1 -parallel 20 -run='TestAccEMRCluster_PlacementGroupConfigs'  -timeout 180m
=== RUN   TestAccEMRCluster_PlacementGroupConfigs
=== PAUSE TestAccEMRCluster_PlacementGroupConfigs
=== CONT  TestAccEMRCluster_PlacementGroupConfigs
--- PASS: TestAccEMRCluster_PlacementGroupConfigs (1525.74s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/emr        1525.984s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/L Managed by automation to categorize the size of a PR. service/emr Issues and PRs that pertain to the emr service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 19, 2023
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Mar 19, 2023
@breathingdust breathingdust added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 6, 2023
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Apr 20, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccEMRCluster_basic\|TestAccEMRCluster_PlacementGroupConfigs' PKG=emr
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/emr/... -v -count 1 -parallel 20  -run=TestAccEMRCluster_basic\|TestAccEMRCluster_PlacementGroupConfigs -timeout 180m
=== RUN   TestAccEMRCluster_basic
=== PAUSE TestAccEMRCluster_basic
=== RUN   TestAccEMRCluster_PlacementGroupConfigs
=== PAUSE TestAccEMRCluster_PlacementGroupConfigs
=== CONT  TestAccEMRCluster_basic
=== CONT  TestAccEMRCluster_PlacementGroupConfigs
--- PASS: TestAccEMRCluster_basic (391.53s)
--- PASS: TestAccEMRCluster_PlacementGroupConfigs (709.49s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/emr	715.078s

@ewbankkit
Copy link
Contributor

@gcardonag Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 3e6e029 into hashicorp:main Apr 20, 2023
45 checks passed
@github-actions github-actions bot added this to the v4.64.0 milestone Apr 20, 2023
@github-actions
Copy link

This functionality has been released in v4.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@gcardonag gcardonag deleted the f-aws_emr_cluster-adds_placement_group_config branch April 22, 2023 12:31
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/emr Issues and PRs that pertain to the emr service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add support for PlacementGroups for EMR Cluster
3 participants