d/aws_ecs_task_execution: Fix interface conversion panics
#30214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems like many of these type assertions are incorrect, running
locally I found terraform would panic with things like:
panic: interface conversion: interface {} is *schema.Set, not []interface {}
These changes correct many of them however it's far from incomplete
because the overrides end up with the zero values in places like cpu,
memory etc.
Someone who knows more about terraform internal types could use this as
a starting point. I can take it forward if I have the time.
Community NoteVoting for Prioritization
For Submitters
|
github-actions
bot
added
service/ecs
jar-b
removed
the
needs-triage
jar-b
added
the
crash
github-actions
bot
added
size/M
jar-b
changed the title
d/aws_ecs_task_execution: Fix interface conversion panics
jar-b
approved these changes
Mar 29, 2023
There was a problem hiding this comment.
LGTM 🎸
$ make testacc PKG=ecs TESTS=TestAccECSTaskExecutionDataSource_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecs/... -v -count 1 -parallel 20 -run='TestAccECSTaskExecutionDataSource_' -timeout 180m
=== RUN TestAccECSTaskExecutionDataSource_basic
=== PAUSE TestAccECSTaskExecutionDataSource_basic
=== RUN TestAccECSTaskExecutionDataSource_overrides
=== PAUSE TestAccECSTaskExecutionDataSource_overrides
=== RUN TestAccECSTaskExecutionDataSource_tags
=== PAUSE TestAccECSTaskExecutionDataSource_tags
=== CONT TestAccECSTaskExecutionDataSource_basic
=== CONT TestAccECSTaskExecutionDataSource_tags
=== CONT TestAccECSTaskExecutionDataSource_overrides
--- PASS: TestAccECSTaskExecutionDataSource_overrides (288.81s)
--- PASS: TestAccECSTaskExecutionDataSource_tags (362.57s)
--- PASS: TestAccECSTaskExecutionDataSource_basic (414.80s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ecs 418.147s
|
Thanks for your contribution, @davbo! 👏 |
|
This functionality has been released in v4.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It seems like many of these type assertions are incorrect, running locally I found terraform would panic with things like:
These changes correct many of them however it's far from complete because the overrides end up with the zero values in places like cpu, memory etc.
Someone who knows more about terraform internal types could use this as a starting point. I can take it forward if I have the time.
Relations
Relates #29783
References
Output from Acceptance Testing