Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Use features instead of dataSources in aws_guardduty_detector #30303

Closed
sakojun opened this issue Mar 29, 2023 · 4 comments · Fixed by #31463
Closed

[Enhancement]: Use features instead of dataSources in aws_guardduty_detector #30303

sakojun opened this issue Mar 29, 2023 · 4 comments · Fixed by #31463
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/guardduty Issues and PRs that pertain to the guardduty service.
Milestone

Comments

@sakojun
Copy link

sakojun commented Mar 29, 2023

Description

The use of dataSources is deprecated and the use of features is recommended.
https://docs.aws.amazon.com/guardduty/latest/ug/guardduty-feature-object-api-changes-march2023.html
If new features are added to GuardDuty in the future, they will not be available.

GuardDuty will not add new data source after this modification.

Adding RDS Login events (#28229) requires support for this issue.

Affected Resource(s) and/or Data Source(s)

aws_guardduty_detector

Potential Terraform Configuration

No response

References

https://docs.aws.amazon.com/guardduty/latest/ug/guardduty-feature-object-api-changes-march2023.html
https://docs.aws.amazon.com/guardduty/latest/APIReference/API_DetectorFeatureConfiguration.html
https://docs.aws.amazon.com/guardduty/latest/APIReference/API_DataSourceConfigurations.html

Would you like to implement a fix?

None

@sakojun sakojun added enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels Mar 29, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@justinretzolk justinretzolk added service/guardduty Issues and PRs that pertain to the guardduty service. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 29, 2023
@bstoutenburgh
Copy link

Is there any progress on this getting attention? Their new EKS Runtime Monitoring is also only available through features.

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

This functionality has been released in v5.20.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Nov 6, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/guardduty Issues and PRs that pertain to the guardduty service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants