Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_wafv2_ip_set: unknown addresses produce error #30352

Merged
merged 3 commits into from Mar 30, 2023

Conversation

johnsonaj
Copy link
Contributor

@johnsonaj johnsonaj commented Mar 30, 2023

Description

Diff suppression causes error when all values in addresses are not known during plan.

Relations

Closes #30351

References

Output from Acceptance Testing

$ make testacc PKG=wafv2 TESTS="TestAccWAFV2IPSet_"

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/wafv2/... -v -count 1 -parallel 20 -run='TestAccWAFV2IPSet_'  -timeout 180m
--- PASS: TestAccWAFV2IPSet_disappears (11.70s)
--- PASS: TestAccWAFV2IPSet_ipv6 (16.13s)
--- PASS: TestAccWAFV2IPSet_minimal (21.74s)
--- PASS: TestAccWAFV2IPSet_large (22.03s)
--- PASS: TestAccWAFV2IPSet_basic (25.49s)
--- PASS: TestAccWAFV2IPSet_changeNameForceNew (29.61s)
--- PASS: TestAccWAFV2IPSet_addresses (30.94s)
--- PASS: TestAccWAFV2IPSet_tags (34.71s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/wafv2	38.483s
...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/wafv2 Issues and PRs that pertain to the wafv2 service. size/S Managed by automation to categorize the size of a PR. and removed service/wafv2 Issues and PRs that pertain to the wafv2 service. labels Mar 30, 2023
@johnsonaj johnsonaj added bug Addresses a defect in current functionality. service/wafv2 Issues and PRs that pertain to the wafv2 service. labels Mar 30, 2023
@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed size/S Managed by automation to categorize the size of a PR. labels Mar 30, 2023
@johnsonaj johnsonaj marked this pull request as ready for review March 30, 2023 16:23
@johnsonaj johnsonaj merged commit 1d1717d into main Mar 30, 2023
39 checks passed
@johnsonaj johnsonaj deleted the b-aws_wafv2_ip_set-computed-addresses branch March 30, 2023 16:57
@github-actions github-actions bot added this to the v4.61.0 milestone Mar 30, 2023
github-actions bot pushed a commit that referenced this pull request Mar 30, 2023
@github-actions
Copy link

This functionality has been released in v4.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 1, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/wafv2 Issues and PRs that pertain to the wafv2 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Unknown values in aws_wafv2_ip_set.addresses provide inconsistent final plan
1 participant