Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VPC Lattice Listener resource #30711

Merged
merged 19 commits into from
Apr 19, 2023

Conversation

ddericco
Copy link
Contributor

@ddericco ddericco commented Apr 13, 2023

Description

Adds support for the VPC Lattice listener resource.

Relations

Closes #30494
Relates #30380

References

SDK: https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/vpclattice@v1.0.2
API: https://docs.aws.amazon.com/sdk-for-go/api/service/vpclattice/
Documentation: https://docs.aws.amazon.com/vpc-lattice/latest/ug/listeners.html

Output from Acceptance Testing

$ make testacc TESTARGS='-run=TestAccVPCLatticeListener_' PKG=vpclattice ACCTEST_PARALLELISM=3                                                                <aws:ddericco+netops-AdminAccess>
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/vpclattice/... -v -count 1 -parallel 3  -run=TestAccVPCLatticeListener_ -timeout 180m
=== RUN   TestAccVPCLatticeListener_defaultActionUpdate
=== PAUSE TestAccVPCLatticeListener_defaultActionUpdate
=== RUN   TestAccVPCLatticeListener_fixedResponsehttp
=== PAUSE TestAccVPCLatticeListener_fixedResponsehttp
=== RUN   TestAccVPCLatticeListener_fixedResponsehttps
=== PAUSE TestAccVPCLatticeListener_fixedResponsehttps
=== RUN   TestAccVPCLatticeListener_forwardhttpTargetGroup
=== PAUSE TestAccVPCLatticeListener_forwardhttpTargetGroup
=== RUN   TestAccVPCLatticeListener_forwardhttpTargetGroupCustomPort
=== PAUSE TestAccVPCLatticeListener_forwardhttpTargetGroupCustomPort
=== RUN   TestAccVPCLatticeListener_forwardhttpsTargetGroupArn
=== PAUSE TestAccVPCLatticeListener_forwardhttpsTargetGroupArn
=== RUN   TestAccVPCLatticeListener_forwardhttpsTargetGroupCustomPort
=== PAUSE TestAccVPCLatticeListener_forwardhttpsTargetGroupCustomPort
=== RUN   TestAccVPCLatticeListener_forwardhttpMultipleTargetGroups
=== PAUSE TestAccVPCLatticeListener_forwardhttpMultipleTargetGroups
=== RUN   TestAccVPCLatticeListener_disappears
=== PAUSE TestAccVPCLatticeListener_disappears
=== RUN   TestAccVPCLatticeListener_tags
=== PAUSE TestAccVPCLatticeListener_tags
=== CONT  TestAccVPCLatticeListener_defaultActionUpdate
=== CONT  TestAccVPCLatticeListener_forwardhttpTargetGroup
=== CONT  TestAccVPCLatticeListener_forwardhttpsTargetGroupArn
--- PASS: TestAccVPCLatticeListener_forwardhttpsTargetGroupArn (61.06s)
=== CONT  TestAccVPCLatticeListener_disappears
--- PASS: TestAccVPCLatticeListener_forwardhttpTargetGroup (77.55s)
=== CONT  TestAccVPCLatticeListener_forwardhttpMultipleTargetGroups
--- PASS: TestAccVPCLatticeListener_defaultActionUpdate (95.08s)
=== CONT  TestAccVPCLatticeListener_tags
--- PASS: TestAccVPCLatticeListener_disappears (56.21s)
=== CONT  TestAccVPCLatticeListener_forwardhttpsTargetGroupCustomPort
--- PASS: TestAccVPCLatticeListener_forwardhttpMultipleTargetGroups (82.18s)
=== CONT  TestAccVPCLatticeListener_fixedResponsehttp
--- PASS: TestAccVPCLatticeListener_forwardhttpsTargetGroupCustomPort (62.27s)
=== CONT  TestAccVPCLatticeListener_forwardhttpTargetGroupCustomPort
--- PASS: TestAccVPCLatticeListener_tags (107.21s)
=== CONT  TestAccVPCLatticeListener_fixedResponsehttps
--- PASS: TestAccVPCLatticeListener_fixedResponsehttp (56.93s)
--- PASS: TestAccVPCLatticeListener_forwardhttpTargetGroupCustomPort (71.80s)
--- PASS: TestAccVPCLatticeListener_fixedResponsehttps (70.02s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/vpclattice 275.553s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. service/vpclattice Issues and PRs that pertain to the vpclattice service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Apr 13, 2023
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. generators Relates to code generators. labels Apr 15, 2023
@ewbankkit ewbankkit added partner Contribution from a partner. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 17, 2023
@ddericco ddericco marked this pull request as ready for review April 18, 2023 14:20
@ewbankkit ewbankkit added the new-resource Introduces a new resource. label Apr 19, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccVPCLatticeListener_' PKG=vpclattice ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/vpclattice/... -v -count 1 -parallel 3  -run=TestAccVPCLatticeListener_ -timeout 180m
=== RUN   TestAccVPCLatticeListener_defaultActionUpdate
=== PAUSE TestAccVPCLatticeListener_defaultActionUpdate
=== RUN   TestAccVPCLatticeListener_fixedResponseHTTP
=== PAUSE TestAccVPCLatticeListener_fixedResponseHTTP
=== RUN   TestAccVPCLatticeListener_fixedResponseHTTPS
=== PAUSE TestAccVPCLatticeListener_fixedResponseHTTPS
=== RUN   TestAccVPCLatticeListener_forwardHTTPTargetGroup
=== PAUSE TestAccVPCLatticeListener_forwardHTTPTargetGroup
=== RUN   TestAccVPCLatticeListener_forwardHTTPTargetGroupCustomPort
=== PAUSE TestAccVPCLatticeListener_forwardHTTPTargetGroupCustomPort
=== RUN   TestAccVPCLatticeListener_forwardHTTPSTargetGroupARN
=== PAUSE TestAccVPCLatticeListener_forwardHTTPSTargetGroupARN
=== RUN   TestAccVPCLatticeListener_forwardHTTPSTargetGroupCustomPort
=== PAUSE TestAccVPCLatticeListener_forwardHTTPSTargetGroupCustomPort
=== RUN   TestAccVPCLatticeListener_forwardHTTPMultipleTargetGroups
=== PAUSE TestAccVPCLatticeListener_forwardHTTPMultipleTargetGroups
=== RUN   TestAccVPCLatticeListener_disappears
=== PAUSE TestAccVPCLatticeListener_disappears
=== RUN   TestAccVPCLatticeListener_tags
=== PAUSE TestAccVPCLatticeListener_tags
=== CONT  TestAccVPCLatticeListener_defaultActionUpdate
=== CONT  TestAccVPCLatticeListener_forwardHTTPSTargetGroupARN
=== CONT  TestAccVPCLatticeListener_disappears
--- PASS: TestAccVPCLatticeListener_defaultActionUpdate (73.18s)
=== CONT  TestAccVPCLatticeListener_forwardHTTPTargetGroup
--- PASS: TestAccVPCLatticeListener_disappears (73.29s)
=== CONT  TestAccVPCLatticeListener_forwardHTTPTargetGroupCustomPort
--- PASS: TestAccVPCLatticeListener_forwardHTTPSTargetGroupARN (113.43s)
=== CONT  TestAccVPCLatticeListener_tags
--- PASS: TestAccVPCLatticeListener_forwardHTTPTargetGroup (74.26s)
=== CONT  TestAccVPCLatticeListener_forwardHTTPMultipleTargetGroups
--- PASS: TestAccVPCLatticeListener_forwardHTTPTargetGroupCustomPort (93.88s)
=== CONT  TestAccVPCLatticeListener_forwardHTTPSTargetGroupCustomPort
--- PASS: TestAccVPCLatticeListener_tags (92.33s)
=== CONT  TestAccVPCLatticeListener_fixedResponseHTTPS
--- PASS: TestAccVPCLatticeListener_forwardHTTPSTargetGroupCustomPort (63.55s)
=== CONT  TestAccVPCLatticeListener_fixedResponseHTTP
--- PASS: TestAccVPCLatticeListener_forwardHTTPMultipleTargetGroups (83.62s)
--- PASS: TestAccVPCLatticeListener_fixedResponseHTTPS (58.47s)
--- PASS: TestAccVPCLatticeListener_fixedResponseHTTP (59.85s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/vpclattice	296.008s

@ewbankkit
Copy link
Contributor

@ddericco Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 84707bf into hashicorp:main Apr 19, 2023
45 checks passed
@github-actions github-actions bot added this to the v4.64.0 milestone Apr 19, 2023
@ddericco ddericco deleted the f-aws_vpclattice_listener_resource branch April 19, 2023 23:10
@meetreks
Copy link
Contributor

Thanks a million @ddericco & @ewbankkit

@github-actions
Copy link

This functionality has been released in v4.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. partner Contribution from a partner. service/vpclattice Issues and PRs that pertain to the vpclattice service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Resource]: aws_vpclattice_listener
3 participants